maemachinebroke/hakurei
1
0
Fork 0
forked from security/hakurei
Code Pull Requests Activity

internal/app: copy parts of config to state

Browse Source 
This is less error-prone than passing the address to the entire hst.Config struct, and reduces the likelihood of accidentally clobbering hst.Config. This also improves ease of testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra
2025-10-10 03:19:09 +09:00
parent 22ee5ae151
commit 109aaee659
8 changed files with 45 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/app/spfinal.go
View File

@@ -13,15 +13,15 @@ import (
"hakurei.app/system/acl"
)
func init() { gob.Register(spFinal{}) }
func init() { gob.Register(spFinalOp{}) }
// spFinal is a transitional op destined for removal after #3, #8, #9 has been resolved.
// spFinalOp is a transitional op destined for removal after #3, #8, #9 has been resolved.
// It exists to avoid reordering the expected entries in test cases.
type spFinal struct{}
type spFinalOp struct{}
func (s spFinal) toSystem(state *outcomeStateSys) error {
func (s spFinalOp) toSystem(state *outcomeStateSys) error {
// append ExtraPerms last
for _, p := range state.config.ExtraPerms {
for _, p := range state.extraPerms {
if p == nil || p.Path == nil {
continue
}
@@ -45,7 +45,7 @@ func (s spFinal) toSystem(state *outcomeStateSys) error {
return nil
}
func (s spFinal) toContainer(state *outcomeStateParams) error {
func (s spFinalOp) toContainer(state *outcomeStateParams) error {
// TODO(ophestra): move this to spFilesystemOp after #8 and #9
// mount root read-only as the final setup Op