maemachinebroke/hakurei
1
0
Fork 0
forked from security/hakurei
Code Pull Requests Activity

app: defer system.I revert

Browse Source 
Just returning an error after a successful call of commit will leave garbage behind with no way for the caller to clean them. This change ensures revert is always called after successful commit with at least per-process state enabled.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra
2025-02-19 21:05:48 +09:00
parent ef81828e0c
commit 3c80fd2b0f
5 changed files with 152 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/app/app.go
View File

@@ -5,7 +5,6 @@ import (
"sync"
"git.gensokyo.uk/security/fortify/fst"
"git.gensokyo.uk/security/fortify/internal/app/shim"
"git.gensokyo.uk/security/fortify/internal/fmsg"
"git.gensokyo.uk/security/fortify/internal/sys"
)
@@ -22,15 +21,11 @@ func New(os sys.State) (fst.App, error) {
}
type app struct {
// application unique identifier
id *stringPair[fst.ID]
// operating system interface
id *stringPair[fst.ID]
sys sys.State
// shim process manager
shim *shim.Shim
mu sync.RWMutex
*appSeal
mu sync.RWMutex
}
func (a *app) ID() fst.ID { return a.id.unwrap() }
@@ -43,10 +38,6 @@ func (a *app) String() string {
a.mu.RLock()
defer a.mu.RUnlock()
if a.shim != nil {
return a.shim.String()
}
if a.appSeal != nil {
if a.appSeal.user.uid == nil {
return fmt.Sprintf("(sealed app %s with invalid uid)", a.id)