internal/rosa/git: determine reporting name from url

This is generally correct, and is a lot cleaner to call.

Signed-off-by: Ophestra <cat@gensokyo.uk>

internal/rosa/git.go

@@ -2,6 +2,7 @@ package rosa
 
 import (
 	"path"
+	"strings"
 
 	"hakurei.app/internal/pkg"
 )
@@ -91,10 +92,13 @@ func init() {
 
 // NewViaGit returns a [pkg.Artifact] for cloning a git repository.
 func (t Toolchain) NewViaGit(
-	name, url, rev string,
+	url, rev string,
 	checksum pkg.Checksum,
 ) pkg.Artifact {
-	return t.New(name+"-"+path.Base(rev), 0, t.AppendPresets(nil,
+	return t.New(strings.TrimSuffix(
+		path.Base(url),
+		".git",
+	)+"-src-"+path.Base(rev), 0, t.AppendPresets(nil,
 		NSSCACert,
 		Git,
 	), &checksum, nil, `

internal/rosa/p11.go

@@ -8,7 +8,7 @@ func (t Toolchain) newP11Kit() (pkg.Artifact, string) {
 		checksum = "3ei-6DUVtYzrRVe-SubtNgRlweXd6H2qHmUu-_5qVyIn6gSTvZbGS2u79Y8IFb2N"
 	)
 	return t.NewPackage("p11-kit", version, t.NewViaGit(
-		"p11-kit-src", "https://github.com/p11-glue/p11-kit.git",
+		"https://github.com/p11-glue/p11-kit.git",
 		"refs/tags/"+version, mustDecode(checksum),
 	), nil, &MesonHelper{
 		Setup: []KV{