From b2b40b07e83af85330157e134d1cc591ed4f7c76 Mon Sep 17 00:00:00 2001 From: Ophestra Date: Mon, 4 May 2026 04:00:33 +0900 Subject: [PATCH] cmd/dist: optional verbosity This makes output less noisy. The build is fast enough not to require progress indication. Signed-off-by: Ophestra --- all.sh | 8 ++++++-- cmd/dist/main.go | 25 +++++++++++++++++-------- internal/rosa/hakurei.go | 5 ++--- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/all.sh b/all.sh index 17b6b862..a7db6d61 100755 --- a/all.sh +++ b/all.sh @@ -2,5 +2,9 @@ TOOLCHAIN_VERSION="$(go version)" cd "$(dirname -- "$0")/" -echo "# Building cmd/dist using ${TOOLCHAIN_VERSION}." -go run -v --tags=dist ./cmd/dist +echo "Building cmd/dist using ${TOOLCHAIN_VERSION}." +FLAGS='' +if test -n "$VERBOSE"; then + FLAGS="$FLAGS -v" +fi +go run $FLAGS --tags=dist ./cmd/dist diff --git a/cmd/dist/main.go b/cmd/dist/main.go index b949be47..5b4594d4 100644 --- a/cmd/dist/main.go +++ b/cmd/dist/main.go @@ -42,14 +42,18 @@ func mustRun(ctx context.Context, name string, arg ...string) { var comp []byte func main() { - fmt.Println() log.SetFlags(0) - log.SetPrefix("# ") + log.SetPrefix("") + verbose := os.Getenv("VERBOSE") != "" version := getenv("HAKUREI_VERSION", "untagged") prefix := getenv("PREFIX", "/usr") destdir := getenv("DESTDIR", "dist") + if verbose { + log.Println() + } + if err := os.MkdirAll(destdir, 0755); err != nil { log.Fatal(err) } @@ -76,12 +80,17 @@ func main() { ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt) defer cancel() - log.Println("Building hakurei.") + verboseFlag := "-v" + if !verbose { + verboseFlag = "-buildvcs=false" + } + + log.Printf("Building hakurei for %s/%s.", runtime.GOOS, runtime.GOARCH) mustRun(ctx, "go", "generate", "./...") mustRun( ctx, "go", "build", "-trimpath", - "-v", "-o", s, + verboseFlag, "-o", s, "-ldflags=-s -w "+ "-buildid= -linkmode external -extldflags=-static "+ "-X hakurei.app/internal/info.buildVersion="+version+" "+ @@ -90,17 +99,17 @@ func main() { "-X main.hakureiPath="+prefix+"/bin/hakurei", "./...", ) - fmt.Println() + log.Println() - log.Println("Testing Hakurei.") + log.Println("##### Testing Hakurei.") mustRun( ctx, "go", "test", "-ldflags=-buildid= -linkmode external -extldflags=-static", "./...", ) - fmt.Println() + log.Println() - log.Println("Creating distribution.") + log.Println("##### Creating distribution.") const suffix = ".tar.gz" distName := "hakurei-" + version + "-" + runtime.GOARCH var f *os.File diff --git a/internal/rosa/hakurei.go b/internal/rosa/hakurei.go index eb28fee7..2d30e094 100644 --- a/internal/rosa/hakurei.go +++ b/internal/rosa/hakurei.go @@ -7,9 +7,8 @@ func (t Toolchain) newHakurei( withHostname bool, ) pkg.Artifact { hostname := ` -echo '# Building test helper (hostname).' -go build -v -o /bin/hostname /usr/src/hostname/main.go -echo +echo 'Building test helper (hostname).' +go build -o /bin/hostname /usr/src/hostname/main.go ` if !withHostname { hostname = ""