rosa/hakurei
6
4
Fork 2
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

cmd/mbf: bring back pkgserver's favicon! #38

Manually merged
kat merged 1 commits from kat/hakurei:favicon into staging 2026-05-17 18:53:22 +09:00
Conversation 2 Commits 1 Files Changed 1
+2 -1
kat commented 2026-05-15 18:52:55 +09:00
Contributor
Copy Link
Copy Source

It existed in mae's #33, but ozy was not satisfied with including a binary file identical to https://hakurei.app's favicon, and hence removed it. However, it's possible to explicitly specify the favicon with a link tag; provided a content security policy that isn't too strong, this should work fine.

It existed in mae's #33, but ozy was not satisfied with including a binary file identical to <https://hakurei.app>'s favicon, and hence removed it. However, it's possible to [explicitly specify the favicon] with a link tag; provided a content security policy that isn't too strong, this should work fine. [explicitly specify the favicon]: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/rel#icon
kat requested review from cat 2026-05-15 18:52:56 +09:00
kat marked the pull request as work in progress 2026-05-16 14:22:31 +09:00
kat marked the pull request as ready for review 2026-05-17 18:42:33 +09:00
kat commented 2026-05-17 18:46:33 +09:00
Author
Contributor
Copy Link
Copy Source

Nota bene: MDN notes something that I won't pretend to understand (CSPs are magic to me):

Note: The crossorigin attribute is not supported for rel="icon" in Chromium-based browsers. See the open Chromium issue.

To me that just means “try it in Chromium before merging”. I only have various Electrons, from which I can't easily test favicons, so @cat'll have to do that.

Nota bene: MDN notes something that I won't pretend to understand (CSPs are magic to me): > <strong>Note</strong>: The [`crossorigin`](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/crossorigin) attribute is not supported for `rel="icon"` in Chromium-based browsers. See the [open Chromium issue](https://crbug.com/1121645). To me that just means “try it in Chromium before merging”. I only have various Electrons, from which I can't easily test favicons, so @cat'll have to do that.
kat added 1 commit 2026-05-17 18:47:47 +09:00
cmd/mbf: bring back pkgserver's favicon!
Test / Create distribution (push) Successful in 1m4s
Details
Test / Sandbox (push) Successful in 2m56s
Details
Test / ShareFS (push) Successful in 3m42s
Details
Test / Hakurei (push) Successful in 3m56s
Details
Test / Sandbox (race detector) (push) Successful in 5m19s
Details
Test / Hakurei (race detector) (push) Successful in 6m26s
Details
Test / Flake checks (push) Successful in 1m31s
Details
6f50811dc9 
It existed in mae's #33, but ozy was not satisfied with including
a binary file identical to https://hakurei.app's favicon, and hence
removed it. However, it's possible to explicitly specify the favicon
with a link tag [1]; provided a content security policy that isn't too
strong, this should work fine.

[1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/rel#icon
kat force-pushed favicon from 2a0d2301ea to 6f50811dc9 2026-05-17 18:47:47 +09:00 Compare
ophestra approved these changes 2026-05-17 18:48:24 +09:00
ophestra left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
🚀 1
kat manually merged commit 6f50811dc9 into staging 2026-05-17 18:53:22 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
cat
ophestra
Labels
Clear labels
Compat
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cat (Ophestra) maemachinebroke noir ophestra
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rosa/hakurei#38