security/fortify
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 35 Wiki Activity

helper/stub: copy args to stderr
All checks were successful
Test / Create distribution (push) Successful in 25s
Details
Test / Fortify (push) Successful in 2m33s
Details
Test / Fpkg (push) Successful in 3m30s
Details
Test / Data race detector (push) Successful in 3m52s
Details
Test / Flake checks (push) Successful in 53s
Details

Browse Source 
Some helpers are implemented via go test itself in tests, and as a result stdout gets clobbered.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra 2025-03-16 00:39:42 +09:00
parent 9f5dad1998
commit 891316d924
Signed by: cat
SSH Key Fingerprint: SHA256:gQ67O0enBZ7UdZypgtspB2FDM1g3GVw8nX0XSdcFw8Q
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
helper/helper_test.go
View File

@ -100,8 +100,8 @@ func testHelper(t *testing.T,
} }
}) })
if got := stdout.String(); !strings.HasPrefix(got, wantPayload) { if got := stderr.String(); got != wantPayload {
t.Errorf("Start: stdout = %v, want %v", t.Errorf("Start: stderr = %v, want %v",
got, wantPayload) got, wantPayload)
} }
}) })
@ -123,8 +123,8 @@ func testHelper(t *testing.T,
err, stdout, stderr) err, stdout, stderr)
} }
if got := stdout.String(); !strings.HasPrefix(got, wantPayload) { if got := stderr.String(); got != wantPayload {
t.Errorf("Start() stdout = %v, want %v", t.Errorf("Start() stderr = %v, want %v",
got, wantPayload) got, wantPayload)
} }
}) })

2
helper/stub.go
View File

@ -74,7 +74,7 @@ func flagRestoreFiles(offset int, ap, sp string) (argsFile, statFile *os.File) {
func genericStub(argsFile, statFile *os.File) { func genericStub(argsFile, statFile *os.File) {
if argsFile != nil { if argsFile != nil {
// this output is checked by parent // this output is checked by parent
if _, err := io.Copy(os.Stdout, argsFile); err != nil { if _, err := io.Copy(os.Stderr, argsFile); err != nil {
panic("cannot read args: " + err.Error()) panic("cannot read args: " + err.Error())
} }
} }