security/fortify
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 35 Wiki Activity

ldd: always copy stderr
All checks were successful
Test / Create distribution (push) Successful in 25s
Details
Test / Fortify (push) Successful in 2m30s
Details
Test / Fpkg (push) Successful in 3m34s
Details
Test / Data race detector (push) Successful in 3m55s
Details
Test / Flake checks (push) Successful in 53s
Details

Browse Source 
Dropping the buffer on success is unhelpful and could hide some useful information.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra 2025-03-17 00:08:00 +09:00
parent bf07b7cd9e
commit bc54db54d2
Signed by: cat
SSH Key Fingerprint: SHA256:gQ67O0enBZ7UdZypgtspB2FDM1g3GVw8nX0XSdcFw8Q
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ldd/exec.go
View File

@ -3,6 +3,7 @@ package ldd
import ( import (
"bytes" "bytes"
"context" "context"
"io"
"os" "os"
"os/exec" "os/exec"
"time" "time"
@ -35,7 +36,9 @@ func ExecFilter(ctx context.Context,
if err := container.Start(); err != nil { if err := container.Start(); err != nil {
return nil, err return nil, err
} else if err = container.Serve(); err != nil { }
defer func() { _, _ = io.Copy(os.Stderr, stderr) }()
if err := container.Serve(); err != nil {
return nil, err return nil, err
} }
if err := container.Wait(); err != nil { if err := container.Wait(); err != nil {
@ -44,8 +47,6 @@ func ExecFilter(ctx context.Context,
bytes.Contains(m, msgStaticGlibc) { bytes.Contains(m, msgStaticGlibc) {
return nil, nil return nil, nil
} }
_, _ = os.Stderr.Write(m)
return nil, err return nil, err
} }