fortify

Author	SHA1	Message	Date
Ophestra	db71fbe22b	system/tmpfiles: fail gracefully in API misuse All checks were successful Test / Create distribution (push) Successful in 25s Details Test / Run NixOS test (push) Successful in 3m25s Details Panicking here leaves garbage behind. Not ideal if this package is going to be exported. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-17 12:17:01 +09:00
Ophestra	83e72c2b59	release: 0.2.15 All checks were successful Test / Create distribution (push) Successful in 19s Details Release / Create release (push) Successful in 33s Details Test / Run NixOS test (push) Successful in 3m12s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-17 00:13:04 +09:00
Ophestra	82a072f641	system/tmpfiles: implement private tmpfiles All checks were successful Test / Create distribution (push) Successful in 19s Details Test / Run NixOS test (push) Successful in 3m30s Details These are only available within the mount namespace and should significantly reduce attack surface. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-17 00:07:52 +09:00
Ophestra	60c10c3f4a	nix: run integration tests with race detector All checks were successful Test / Create distribution (push) Successful in 25s Details Test / Run NixOS test (push) Successful in 3m4s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 20:58:08 +09:00
Ophestra	468696f611	internal: beforeExit before reachable fatal calls All checks were successful Test / Create distribution (push) Successful in 18s Details Test / Run NixOS test (push) Successful in 47s Details These are the only two calls to log.Fatal* reachable during suspended output. Call fmsg.BeforeExit here to catch that. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 19:03:34 +09:00
Ophestra	29c38caac8	app/shim/manager: return error on bad fsu path All checks were successful Test / Create distribution (push) Successful in 24s Details Test / Run NixOS test (push) Successful in 2m9s Details This results in a graceful failure that does not leave garbage behind. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 18:59:45 +09:00
Ophestra	e599b5583d	fmsg: implement suspend in writer All checks were successful Test / Create distribution (push) Successful in 24s Details Test / Run NixOS test (push) Successful in 2m18s Details This removes the requirement to call fmsg.Exit on every exit path, and enables direct use of the "log" package. However, fmsg.BeforeExit is still encouraged when possible to catch exit on suspended output. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 18:51:53 +09:00
Ophestra	33a4ab11c2	internal: move shim and init into app All checks were successful Test / Create distribution (push) Successful in 24s Details Test / Run NixOS test (push) Successful in 2m7s Details This structure makes more sense, as both processes are part of an app's lifecycle. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 16:28:46 +09:00
Ophestra	1fa5e992e4	helper/bwrap: expose address of DataConfig All checks were successful Test / Create distribution (push) Successful in 24s Details Test / Run NixOS test (push) Successful in 2m7s Details This allows the caller to defer fulfilling its payload. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 12:33:59 +09:00
Ophestra	c667b13a00	system: separate link Op implementation All checks were successful Test / Create distribution (push) Successful in 24s Details Test / Run NixOS test (push) Successful in 2m13s Details This Op would still be useful after replacing the Tmpfiles interface, so isolate it here. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-16 12:15:26 +09:00
Ophestra	90b86a5531	release: 0.2.14 All checks were successful Release / Create release (push) Successful in 24s Details Test / Create distribution (push) Successful in 18s Details Test / Run NixOS test (push) Successful in 50s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 23:05:02 +09:00
Ophestra	f545e154f0	workflows: use native nix runner All checks were successful Test / Create distribution (push) Successful in 20s Details Test / Run NixOS test (push) Successful in 51s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 22:58:04 +09:00
Ophestra	268a90f1a5	app: improve WAYLAND_DISPLAY correctness All checks were successful Test / Create distribution (push) Successful in 46s Details Test / Run NixOS test (push) Successful in 3m35s Details This now has identical behaviour as wayland C library. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 14:45:09 +09:00
Ophestra	3054527ca5	fortify: prevent exit status 0 on app failure All checks were successful Test / Create distribution (push) Successful in 46s Details Test / Run NixOS test (push) Successful in 3m37s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 14:40:19 +09:00
Ophestra	ddb2f9c11b	app: remove wayland socket hard link All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m32s Details This Op was not doing anything useful. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 10:54:00 +09:00
Ophestra	6ae02e72fa	nix: test direct_wayland behaviour All checks were successful Test / Create distribution (push) Successful in 47s Details Test / Run NixOS test (push) Successful in 3m35s Details This should never be used outside tests unless you absolutely know what you're doing or are using GNOME. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 10:45:27 +09:00
Ophestra	989fb5395f	nix: remove unused configuration All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m30s Details User setup no longer depends on userdb. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 10:10:42 +09:00
Ophestra	f955b15b84	system: remove write mode tmpfiles All checks were successful Test / Create distribution (push) Successful in 57s Details Test / Run NixOS test (push) Successful in 3m42s Details This interface is ugly and bug-prone. This change removes its write mode which has been obsoleted by CopyBind. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 03:22:20 +09:00
Ophestra	0340c67995	app: port passwd and group files to copy All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m41s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 03:19:06 +09:00
Ophestra	72b0160aad	helper/bwrap: implement file copy flags All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m42s Details These are significantly more efficient and less error-prone than mounting an external tmpfile. This should also reduce attack surface as the resulting files are private to its specific sandbox. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 03:13:15 +09:00
Ophestra	ea8d1c07df	priv/shim: move /sbin/init setup to app All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m36s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 03:06:10 +09:00
Ophestra	a0062d8275	fmsg: resume on exit All checks were successful Test / Create distribution (push) Successful in 47s Details Test / Run NixOS test (push) Successful in 3m32s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 02:22:09 +09:00
Ophestra	43d2e4f5d7	nix: sway increase resolution All checks were successful Test / Create distribution (push) Successful in 50s Details Test / Run NixOS test (push) Successful in 3m46s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 02:21:24 +09:00
Ophestra	be7d944b39	helper/bwrap: PositionalArg implement fmt.Stringer All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m28s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-15 00:11:48 +09:00
Ophestra	ace97952cc	helper/bwrap: merge Args and FDArgs All checks were successful Test / Create distribution (push) Successful in 1m13s Details Test / Run NixOS test (push) Successful in 4m34s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 18:13:06 +09:00
Ophestra	73146ea7fa	dbus: remove BwrapStatic method All checks were successful Test / Create distribution (push) Successful in 54s Details Test / Run NixOS test (push) Successful in 8m20s Details This method does not do anything and is not called from anywhere. It also does not make any sense as a public interface since the argument builder is no longer stateless. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 18:09:59 +09:00
Ophestra	88040504b2	helper/bwrap: remove fmsg import All checks were successful Test / Create distribution (push) Successful in 57s Details Test / Run NixOS test (push) Successful in 8m13s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 18:05:00 +09:00
Ophestra	1fd571d561	cmd/fsu: check parse behaviour All checks were successful Test / Run NixOS test (push) Successful in 10m33s Details Test / Create distribution (push) Successful in 1m8s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 16:43:55 +09:00
Ophestra	be30e2f11e	cmd/fsu: revert offset in error message All checks were successful Test / Create distribution (push) Successful in 51s Details Test / Run NixOS test (push) Successful in 3m39s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 15:31:39 +09:00
Ophestra	aaebb8f3ab	fortify: check print behaviour All checks were successful Test / Create distribution (push) Successful in 1m10s Details Test / Run NixOS test (push) Successful in 3m59s Details These output are supposed to be deterministic, so checking them is a good way to catch regressions. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 14:44:28 +09:00
Ophestra	1f74b636d3	state/join: use Join method when available All checks were successful Test / Create distribution (push) Successful in 1m4s Details Test / Run NixOS test (push) Successful in 4m11s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 14:11:02 +09:00
Ophestra	e431ab3c24	app: check username length against LOGIN_NAME_MAX All checks were successful Test / Create distribution (push) Successful in 49s Details Test / Run NixOS test (push) Successful in 3m46s Details This limit is arbitrary, but it's good to enforce it anyway. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 12:44:55 +09:00
Ophestra	3fba33687b	fortify: print line after ps output All checks were successful Test / Create distribution (push) Successful in 1m43s Details Test / Run NixOS test (push) Successful in 9m18s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-14 12:23:20 +09:00
Ophestra	820f48ef94	release: 0.2.13 All checks were successful Test / Create distribution (push) Successful in 1m56s Details Release / Create release (push) Successful in 2m9s Details Test / Run NixOS test (push) Successful in 4m38s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 23:45:54 +09:00
Ophestra	fe7d208cf7	helper: use generic extra files interface All checks were successful Test / Create distribution (push) Successful in 1m38s Details Test / Run NixOS test (push) Successful in 4m36s Details This replaces the pipes object and integrates context into helper process lifecycle. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 23:34:15 +09:00
Ophestra	60c2873750	helper/proc: cancel ec on parent ctx All checks were successful Test / Create distribution (push) Successful in 1m31s Details Test / Run NixOS test (push) Successful in 4m13s Details This allows errors written during a timeout to be received and handled. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 23:08:28 +09:00
Ophestra	d1d20c06fb	helper/seccomp: use sync.Once for closeWrite All checks were successful Test / Create distribution (push) Successful in 1m29s Details Test / Run NixOS test (push) Successful in 4m13s Details This makes the code much cleaner, and eliminates the intermittent ErrInvalid errors. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 22:49:16 +09:00
Ophestra	1e6a059668	helper/seccomp: benchmark exporter All checks were successful Test / Create distribution (push) Successful in 1m44s Details Test / Run NixOS test (push) Successful in 4m32s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 22:37:51 +09:00
Ophestra	318df0f7e1	nix: test syscall filter All checks were successful Test / Create distribution (push) Successful in 1m30s Details Test / Run NixOS test (push) Successful in 4m17s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 22:01:16 +09:00
Ophestra	58eb8f971d	proc/pipe: implement args and stat file All checks were successful Test / Create distribution (push) Successful in 1m30s Details Test / Run NixOS test (push) Successful in 4m11s Details This is a generic implementation of helper/pipe. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 19:57:24 +09:00
Ophestra	0a1d7c01cd	helper/proc: count dispatched errs All checks were successful Test / Create distribution (push) Successful in 1m28s Details Test / Run NixOS test (push) Successful in 3m59s Details This helps debug implementation errors of [proc.File]. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 19:55:37 +09:00
Ophestra	60ca1c6c55	helper/proc: store file addresses in linked list All checks were successful Test / Create distribution (push) Successful in 1m28s Details Test / Run NixOS test (push) Successful in 4m5s Details Storing extra files as a slice requires the caller to allocate a large enough slice before initialising any file and never grow the slice. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 17:42:12 +09:00
Ophestra	099da78af5	helper/seccomp: eliminate data race on pfd All checks were successful Test / Create distribution (push) Successful in 2m10s Details Test / Run NixOS test (push) Successful in 4m50s Details Turns out the doc comment on os.File was lying about its methods being safe for concurrent use. The race detector picked up a data race from concurrent use of Fd and Close. This change eliminates that by calling Fd in the prepare routine. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-13 10:40:51 +09:00
Ophestra	18466cfd02	helper/proc: declare generic extra files interface All checks were successful Test / Create distribution (push) Successful in 1m29s Details Test / Run NixOS test (push) Successful in 4m4s Details Helpers use extra files for various purposes. This provides a generic interface for implementing the fulfillment of these extra files without having to specifically handle them in the process creation code. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-11 16:34:47 +09:00
Ophestra	e14923ae53	helper/proc: move package out of internal All checks were successful Test / Create distribution (push) Successful in 1m32s Details Test / Run NixOS test (push) Successful in 4m6s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-08 13:03:45 +09:00
Ophestra	7aff3ead3a	nix: vm test remove unnecessary setup All checks were successful Test / Create distribution (push) Successful in 1m27s Details Test / Run NixOS test (push) Successful in 4m10s Details This step is no longer required as the NixOS module is responsible for home directory creation. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-07 22:29:56 +09:00
Ophestra	72fb13dccc	dbus: lock for read in public args interface All checks were successful Test / Create distribution (push) Successful in 1m27s Details Test / Run NixOS test (push) Successful in 4m2s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-07 13:42:29 +09:00
Ophestra	a48386bd56	system/dbus: dump messages on early fault All checks were successful Test / Create distribution (push) Successful in 1m27s Details Test / Run NixOS test (push) Successful in 4m14s Details In the current app implementation this gets dumped in the wait method after resuming output. Wait is never called in an early fault condition, so any error messages get lost. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-07 13:20:56 +09:00
Ophestra	2e52191404	system/dbus: dump method prints msgbuf All checks were successful Test / Create distribution (push) Successful in 1m27s Details Test / Run NixOS test (push) Successful in 4m1s Details Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-07 13:16:54 +09:00
Ophestra	568d7758d5	helper/seccomp: panic on invalid closeWrite use All checks were successful Test / Create distribution (push) Successful in 1m46s Details Test / Run NixOS test (push) Successful in 4m39s Details Returning an error here puts exporter in an invalid state. The caller should guard against this condition instead. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-02-07 12:58:20 +09:00

1 2 3 4 5 ...

480 Commits