system: optimise string formatting

Signed-off-by: Ophestra <cat@gensokyo.uk>

cmd/fpkg/app.go

@@ -65,7 +65,6 @@ type appInfo struct {
 func (app *appInfo) toFst(pathSet *appPathSet, argv []string, flagDropShell bool) *fst.Config {
 	config := &fst.Config{
 		ID:   app.ID,
-		Path: argv[0],
 		Args: argv,
 		Confinement: fst.ConfinementConfig{
 			AppID:    app.AppID,

cmd/fpkg/with.go

@@ -16,8 +16,7 @@ func withNixDaemon(
 	app *appInfo, pathSet *appPathSet, dropShell bool, beforeFail func(),
 ) {
 	mustRunAppDropShell(ctx, updateConfig(&fst.Config{
-		ID:   app.ID,
-		Path: shellPath,
+		ID: app.ID,
 		Args: []string{shellPath, "-lc", "rm -f /nix/var/nix/daemon-socket/socket && " +
 			// start nix-daemon
 			"nix-daemon --store / & " +
@@ -65,7 +64,6 @@ func withCacheDir(
 	app *appInfo, pathSet *appPathSet, dropShell bool, beforeFail func()) {
 	mustRunAppDropShell(ctx, &fst.Config{
 		ID:   app.ID,
-		Path: shellPath,
 		Args: []string{shellPath, "-lc", strings.Join(command, " && ")},
 		Confinement: fst.ConfinementConfig{
 			AppID:    app.AppID,

sandbox/sequential.go

@@ -301,15 +301,7 @@ func (l *Symlink) apply(*Params) error {
 		return msg.WrapErr(syscall.EBADE,
 			fmt.Sprintf("path %q is not absolute", l[1]))
 	}
-
-	target := toSysroot(l[1])
-	if err := ensureFile(target, 0444, 0755); err != nil {
-		return err
-	}
-	if err := os.Remove(target); err != nil {
-		return msg.WrapErr(err, err.Error())
-	}
-	if err := os.Symlink(l[0], target); err != nil {
+	if err := os.Symlink(l[0], toSysroot(l[1])); err != nil {
 		return msg.WrapErr(err, err.Error())
 	}
 	return nil