internal/rosa: remove calls to low-level exec helper

This method predates the helper infrastructure, it is awkward to use and difficult to maintain for the replacement bootstrap mechanism. This change prepares for its removal.

Signed-off-by: Ophestra <cat@gensokyo.uk>

internal/rosa/git.go

@@ -17,22 +17,29 @@ func (t Toolchain) NewViaGit(
 	url, rev string,
 	checksum pkg.Checksum,
 ) pkg.Artifact {
-	return t.New(strings.TrimSuffix(
+	return t.NewPackage(strings.TrimSuffix(
 		path.Base(url),
 		".git",
-	)+"-src-"+path.Base(rev), THostNet, t.Append(nil,
-		_nssCACert,
-		_git,
-	), &checksum, nil, `
+	)+"-src", path.Base(rev), nil, &PackageAttr{
+		KnownChecksum: &checksum,
+
+		Flag:  THostNet,
+		Paths: []pkg.ExecPath{resolvconf()},
+	}, &GenericHelper{
+		Build: `
 git \
 	-c advice.detachedHead=false \
 	clone \
 	--depth=1 \
-	--revision=`+rev+` \
+	--revision=` + rev + ` \
 	--shallow-submodules \
 	--recurse-submodules \
-	`+url+` \
+	` + url + ` \
 	/work
 rm -rf /work/.git
-`, resolvconf())
+`,
+	},
+		_nssCACert,
+		_git,
+	)
 }

internal/rosa/llvm.go

@@ -83,9 +83,11 @@ func init() {
 			{"LIBCXX_ENABLE_STATIC_ABI_LIBRARY", "OFF"},
 			{"LIBCXX_HAS_MUSL_LIBC", "ON"},
 			{"LIBCXX_HARDENING_MODE", "fast"},
+			{"LIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY", "ON"},
 			{"LIBCXXABI_USE_LLVM_UNWINDER", "ON"},
-			{"LIBCXXABI_ENABLE_STATIC_UNWINDER", "OFF"},
+			{"LIBCXXABI_ENABLE_STATIC_UNWINDER", "ON"},
 			{"LIBCXXABI_USE_COMPILER_RT", "ON"},
+			{"LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_STATIC_LIBRARY", "ON"},
 			{"LLVM_INSTALL_BINUTILS_SYMLINKS", "ON"},
 			{"LLVM_INSTALL_UTILS", "ON"},
 			{"LLVM_BUILD_LLVM_DYLIB", "ON"},
@@ -138,6 +140,10 @@ func init() {
 				"CodeGen/PowerPC/ppc-tmmintrin.c",
 				"CodeGen/PowerPC/ppc-smmintrin.c",
 				"CodeGenCUDA/amdgpu-alias-undef-symbols.cu",
+				// clang: deadlocks with LIBCXXABI_ENABLE_STATIC_UNWINDER
+				"global-value-regex",
+				"global-hex-value-regex",
+				"check-globals",
 				// cxx: fails on musl
 				"close.dont-get-rid-of-buffer",
 				"re/re.traits",
@@ -196,6 +202,7 @@ ln -s ld.lld /work/system/bin/ld
 ln -s clang /work/system/bin/cc
 ln -s clang /work/system/bin/cpp
 ln -s clang++ /work/system/bin/c++
+echo '-static-libstdc++' > /work/system/bin/clang++.cfg
 `,
 
 			// LLVM_LINK_LLVM_DYLIB causes llvm test suite to leak system

internal/rosa/rosa.go

@@ -363,9 +363,14 @@ function apply {
 			buf.WriteString("'\n")
 		}
 	}
-	return t.New(name+"-src", 0, t.Append(nil,
+
+	return t.NewPackage(name+"-src", Unversioned, nil, &PackageAttr{
+		Paths: paths,
+	}, &GenericHelper{
+		Build: buf.String(),
+	},
 		_patch,
-	), nil, nil, buf.String(), paths...)
+	)
 }
 
 // helperInPlace is a special directory value for omitting the cd statement.