Ophestra Umiker
1906853382
In the past Wayland, X and PulseAudio are shared unconditionally. This can unnecessarily increase attack surface as some of these resources might not be needed at all. This commit moves all environment preparation code to the internal app package and selectively call them based on flags. An "enablements" bitfield is introduced tracking all enabled shares. This value is registered after successful child process launch and stored in launcher states. Code responsible for running the child process is isolated to its own app/run file and cleaned up. Launch method selection is also extensively cleaned up. The internal state/track readLaunchers function now takes uid as an argument. Launcher state is now printed using text/tabwriter and argv is only emitted when verbose. Signed-off-by: Ophestra Umiker <cat@ophivana.moe>
69 lines
2.1 KiB
Go
69 lines
2.1 KiB
Go
package app
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io/fs"
|
|
"os"
|
|
"path"
|
|
|
|
"git.ophivana.moe/cat/fortify/internal/acl"
|
|
"git.ophivana.moe/cat/fortify/internal/state"
|
|
"git.ophivana.moe/cat/fortify/internal/system"
|
|
"git.ophivana.moe/cat/fortify/internal/util"
|
|
)
|
|
|
|
func (a *App) SharePulse() {
|
|
a.setEnablement(state.EnablePulse)
|
|
|
|
// ensure PulseAudio directory ACL (e.g. `/run/user/%d/pulse`)
|
|
pulse := path.Join(system.V.Runtime, "pulse")
|
|
pulseS := path.Join(pulse, "native")
|
|
if s, err := os.Stat(pulse); err != nil {
|
|
if !errors.Is(err, fs.ErrNotExist) {
|
|
state.Fatal("Error accessing PulseAudio directory:", err)
|
|
}
|
|
state.Fatal(fmt.Sprintf("PulseAudio dir '%s' not found", pulse))
|
|
} else {
|
|
// add environment variable for new process
|
|
a.AppendEnv(util.PulseServer, "unix:"+pulseS)
|
|
if err = acl.UpdatePerm(pulse, a.UID(), acl.Execute); err != nil {
|
|
state.Fatal("Error preparing PulseAudio:", err)
|
|
} else {
|
|
state.RegisterRevertPath(pulse)
|
|
}
|
|
|
|
// ensure PulseAudio socket permission (e.g. `/run/user/%d/pulse/native`)
|
|
if s, err = os.Stat(pulseS); err != nil {
|
|
if errors.Is(err, fs.ErrNotExist) {
|
|
state.Fatal("PulseAudio directory found but socket does not exist")
|
|
}
|
|
state.Fatal("Error accessing PulseAudio socket:", err)
|
|
} else {
|
|
if m := s.Mode(); m&0o006 != 0o006 {
|
|
state.Fatal(fmt.Sprintf("Unexpected permissions on '%s':", pulseS), m)
|
|
}
|
|
}
|
|
|
|
// Publish current user's pulse-cookie for target user
|
|
pulseCookieSource := util.DiscoverPulseCookie()
|
|
pulseCookieFinal := path.Join(system.V.Share, "pulse-cookie")
|
|
a.AppendEnv(util.PulseCookie, pulseCookieFinal)
|
|
if system.V.Verbose {
|
|
fmt.Printf("Publishing PulseAudio cookie '%s' to '%s'\n", pulseCookieSource, pulseCookieFinal)
|
|
}
|
|
if err = util.CopyFile(pulseCookieFinal, pulseCookieSource); err != nil {
|
|
state.Fatal("Error copying PulseAudio cookie:", err)
|
|
}
|
|
if err = acl.UpdatePerm(pulseCookieFinal, a.UID(), acl.Read); err != nil {
|
|
state.Fatal("Error publishing PulseAudio cookie:", err)
|
|
} else {
|
|
state.RegisterRevertPath(pulseCookieFinal)
|
|
}
|
|
|
|
if system.V.Verbose {
|
|
fmt.Printf("PulseAudio dir '%s' configured\n", pulse)
|
|
}
|
|
}
|
|
}
|