diff --git a/static/build.html b/static/build.html
index 97bb9c2f..dc1a41f7 100644
--- a/static/build.html
+++ b/static/build.html
@@ -124,439 +124,438 @@
Smartphone targets: Smartphone targets: These are all fully supported production-ready targets supporting all the baseline
- security features and receiving full monthly security updates covering all firmware,
- kernel drivers, driver libraries / services and other device-specific code. A fully
- signed user build for these devices is a proper GrapheneOS release. Newer generation
- devices have stronger hardware / firmware security and hardware-based OS security
- features and are better development devices for that reason. It's not possible to work
- on everything via past generation devices. The best development devices are the Pixel
- 3, Pixel 3 XL, Pixel 3a, Pixel 3a XL, Pixel 4, Pixel 4 XL and Pixel 4a. These are all fully supported production-ready targets supporting all the baseline
+ security features and receiving full monthly security updates covering all firmware,
+ kernel drivers, driver libraries / services and other device-specific code. A fully
+ signed user build for these devices is a proper GrapheneOS release. Newer generation
+ devices have stronger hardware / firmware security and hardware-based OS security
+ features and are better development devices for that reason. It's not possible to work
+ on everything via past generation devices. The best development devices are the Pixel
+ 3, Pixel 3 XL, Pixel 3a, Pixel 3a XL, Pixel 4, Pixel 4 XL and Pixel 4a. Generic targets: Generic targets: These generic targets can be used with the emulator along with many smartphones,
- tablets and other devices. These targets don't receive full monthly security updates,
- don't offer all of the baseline security features and are intended for development
- usage. These generic targets can be used with the emulator along with many smartphones,
+ tablets and other devices. These targets don't receive full monthly security updates,
+ don't offer all of the baseline security features and are intended for development
+ usage. Providing proper support for a device or generic device family requires providing
- an up-to-date kernel and device support code including driver libraries, firmware and
- device SELinux policy extensions. Other than some special cases like the emulator, the
- generic targets rely on the device support code present on the device. Shipping all of
- this is necessary for full security updates and is tied to enabling verified boot /
- attestation. Pixel targets have a lot of device-specific hardening in the AOSP base
- along with some in GrapheneOS which needs to be ported over too. For example, various
- security features in the kernel including type-based Control Flow Integrity (CFI) and
- the shadow call stack are currently specific to the kernels for these devices. Providing proper support for a device or generic device family requires providing
+ an up-to-date kernel and device support code including driver libraries, firmware and
+ device SELinux policy extensions. Other than some special cases like the emulator, the
+ generic targets rely on the device support code present on the device. Shipping all of
+ this is necessary for full security updates and is tied to enabling verified boot /
+ attestation. Pixel targets have a lot of device-specific hardening in the AOSP base
+ along with some in GrapheneOS which needs to be ported over too. For example, various
+ security features in the kernel including type-based Control Flow Integrity (CFI) and
+ the shadow call stack are currently specific to the kernels for these devices. SDK emulator targets: SDK emulator targets: These are extended versions of the generic targets with extra components for the
- SDK. These targets don't receive full monthly security updates, don't provide all of
- the baseline security features and are intended for development usage. These are extended versions of the generic targets with extra components for the
+ SDK. These targets don't receive full monthly security updates, don't provide all of
+ the baseline security features and are intended for development usage. Arch Linux, Debian buster and Ubuntu 20.04 LTS are the officially supported
- operating systems for building GrapheneOS. Arch Linux, Debian buster and Ubuntu 20.04 LTS are the officially supported
+ operating systems for building GrapheneOS. Dependencies for fetching and verifying the sources: Dependencies for fetching and verifying the sources: Baseline build dependencies: Baseline build dependencies: You can either obtain You can either obtain The Android Open Source Project build system is designed to provide reliable and
- reproducible builds. To accomplish this, it provides a prebuilt toolchain and other
- utilities fulfilling most of the build dependency requirements itself. These prebuilt
- tools have reproducible builds themselves. It runs the build process within a loose
- sandbox to avoid accidental dependencies on the host system. The process of moving to
- a fully self-contained build process with minimal external dependencies is gradual and
- there are still dependencies that need to be installed on the host system. The Android Open Source Project build system is designed to provide reliable and
+ reproducible builds. To accomplish this, it provides a prebuilt toolchain and other
+ utilities fulfilling most of the build dependency requirements itself. These prebuilt
+ tools have reproducible builds themselves. It runs the build process within a loose
+ sandbox to avoid accidental dependencies on the host system. The process of moving to
+ a fully self-contained build process with minimal external dependencies is gradual and
+ there are still dependencies that need to be installed on the host system. The Linux kernel build process is not integrated into the rest of the AOSP build
- process, but does reuse the same prebuilts to make the build reproducible. The Linux kernel build process is not integrated into the rest of the AOSP build
+ process, but does reuse the same prebuilts to make the build reproducible. Additional Linux kernel build dependencies not provided by the source tree: Additional Linux kernel build dependencies not provided by the source tree: The dependency on the host libgcc and binutils for building utilities during the
- build process will be phased out by moving to a pure LLVM-based toolchain alongside
- doing it for the target. This is lagging a bit behind for the kernel, particularly
- code built for the host. The dependency on the host libgcc and binutils for building utilities during the
+ build process will be phased out by moving to a pure LLVM-based toolchain alongside
+ doing it for the target. This is lagging a bit behind for the kernel, particularly
+ code built for the host. Additional Android Open Source Project build dependencies not provided by the
- source tree: Additional Android Open Source Project build dependencies not provided by the
+ source tree: Additional android-prepare-vendor (for Pixel phones) dependencies: Additional android-prepare-vendor (for Pixel phones) dependencies: The The Since this is syncing the sources for the entire operating system and application
- layer, it will use a lot of bandwidth and storage space. Since this is syncing the sources for the entire operating system and application
+ layer, it will use a lot of bandwidth and storage space. You likely want to use the most recent stable tag, not the development branch, even
- for developing a feature. It's easier to port between stable tags that are known to
- work properly than dealing with a moving target. You likely want to use the most recent stable tag, not the development branch, even
+ for developing a feature. It's easier to port between stable tags that are known to
+ work properly than dealing with a moving target. The The If your network is unreliable and If your network is unreliable and Pick a specific release for a device from the releases page
- and download the source tree. Note that some devices use different Android Open Source
- Project branches so they can end up with different tags. Make sure to use the correct
- tag for a device. For devices without official support, use the latest tag marked as
- being appropriate for generic / other devices in the release notes. Pick a specific release for a device from the releases page
+ and download the source tree. Note that some devices use different Android Open Source
+ Project branches so they can end up with different tags. Make sure to use the correct
+ tag for a device. For devices without official support, use the latest tag marked as
+ being appropriate for generic / other devices in the release notes. Verify the manifest: Verify the manifest: Complete the source tree download: Complete the source tree download: The manifest for the latest stable release refers to the revisions in other
- repositories via commit hashes rather than tag names. This avoids the need to use a
- script to verify tag signatures across all the repositories, since they simply point
- to the same commits with the same hashes. The manifest for the latest stable release refers to the revisions in other
+ repositories via commit hashes rather than tag names. This avoids the need to use a
+ script to verify tag signatures across all the repositories, since they simply point
+ to the same commits with the same hashes. Note that the repo command itself takes care of updating itself and uses gpg to
- verify by default. Note that the repo command itself takes care of updating itself and uses gpg to
+ verify by default. The kernel needs to be built in advance, since it uses a separate build system. The kernel needs to be built in advance, since it uses a separate build system. Prebuilts are provided for the Pixel 4, 4 XL and 4a so this step is optional for
- those. This will be done for the other devices in the future. Prebuilts are provided for the Pixel 4, 4 XL and 4a so this step is optional for
+ those. This will be done for the other devices in the future. List of kernels corresponding to officially supported devices: List of kernels corresponding to officially supported devices: As part of the hardening in GrapheneOS, it uses fully monolithic kernel builds with
- dynamic kernel modules disabled. This improves the effectiveness of mitigations like
- Control Flow Integrity benefiting from whole program analysis. It also reduces attack
- surface and complexity including making the build system simpler. The kernel trees
- marked as using a separate build above need to have the device variant passed to the
- GrapheneOS kernel build script to select the device. As part of the hardening in GrapheneOS, it uses fully monolithic kernel builds with
+ dynamic kernel modules disabled. This improves the effectiveness of mitigations like
+ Control Flow Integrity benefiting from whole program analysis. It also reduces attack
+ surface and complexity including making the build system simpler. The kernel trees
+ marked as using a separate build above need to have the device variant passed to the
+ GrapheneOS kernel build script to select the device. For the Pixel 3, Pixel 3 XL, Pixel 3a, Pixel 3a XL, Pixel 4, Pixel 4 XL and Pixel
- 4a the kernel repository uses submodules for building in out-of-tree modules. You need
- to make sure the submodule sources are updated before building. In the future, this
- should end up being handled automatically by For the Pixel 3, Pixel 3 XL, Pixel 3a, Pixel 3a XL, Pixel 4, Pixel 4 XL and Pixel
+ 4a the kernel repository uses submodules for building in out-of-tree modules. You need
+ to make sure the submodule sources are updated before building. In the future, this
+ should end up being handled automatically by For example, to build the kernel for blueline: For example, to build the kernel for blueline: The build has to be done from bash as envsetup.sh is not compatible with other
- shells like zsh. The build has to be done from bash as envsetup.sh is not compatible with other
+ shells like zsh. Set up the build environment: Set up the build environment: Select the desired build target ( Select the desired build target ( For a development build, you may want to replace For a development build, you may want to replace Set Set To reproduce a past build, you need to export To reproduce a past build, you need to export The signing process for release builds is done after completing builds and replaces
- the dm-verity trees, apk signatures, etc. and can only be reproduced with access to
- the same private keys. If you want to compare to production builds signed with
- different keys you need to stick to comparing everything other than the
- signatures. The signing process for release builds is done after completing builds and replaces
+ the dm-verity trees, apk signatures, etc. and can only be reproduced with access to
+ the same private keys. If you want to compare to production builds signed with
+ different keys you need to stick to comparing everything other than the
+ signatures. Additionally, set Additionally, set This section is specific to Pixel devices. The emulator and generic targets don't
- require extra vendor files. This section is specific to Pixel devices. The emulator and generic targets don't
+ require extra vendor files. Many of these components are already open source, but not everything is set up to
- be built by the Android Open Source Project build system. Switching to building these
- components from source will be an incremental effort. In many cases, the vendor files
- simply need to be ignored and AOSP will already provide them instead. Firmware cannot
- generally be built from source even when sources are available, other than to verify
- that the official builds match the sources, since it has signature verification (which
- is an important part of the verified boot and attestation security model). Many of these components are already open source, but not everything is set up to
+ be built by the Android Open Source Project build system. Switching to building these
+ components from source will be an incremental effort. In many cases, the vendor files
+ simply need to be ignored and AOSP will already provide them instead. Firmware cannot
+ generally be built from source even when sources are available, other than to verify
+ that the official builds match the sources, since it has signature verification (which
+ is an important part of the verified boot and attestation security model). Extract the vendor files corresponding to the matching release: Extract the vendor files corresponding to the matching release: Note that android-prepare-vendor is non-deterministic unless a timestamp parameter is
- passed with Note that android-prepare-vendor is non-deterministic unless a timestamp parameter is
+ passed with Incremental builds (i.e. starting from the old build) usually work for development
- and are the normal way to develop changes. However, there are cases where changes are
- not properly picked up by the build system. For production builds, you should remove
- the remnants of any past builds before starting, particularly if there were
- non-trivial changes: Incremental builds (i.e. starting from the old build) usually work for development
+ and are the normal way to develop changes. However, there are cases where changes are
+ not properly picked up by the build system. For production builds, you should remove
+ the remnants of any past builds before starting, particularly if there were
+ non-trivial changes: Next, start the build process with the Next, start the build process with the The The For an emulator build, always use the development build approach below. For an emulator build, always use the development build approach below. The normal production build process involves building a target files package to be
- resigned with secure release keys and then converted into factory images and/or an
- update zip via the sections below. If you have a dedicated development device with no
- security requirements, you can save time by using the default build target rather than
- target-files-package. Leave the bootloader unlocked and flashing the raw images that
- are signed with the default public test keys. The normal production build process involves building a target files package to be
+ resigned with secure release keys and then converted into factory images and/or an
+ update zip via the sections below. If you have a dedicated development device with no
+ security requirements, you can save time by using the default build target rather than
+ target-files-package. Leave the bootloader unlocked and flashing the raw images that
+ are signed with the default public test keys. To build the default build target: To build the default build target: Technically, you could generate test key signed update packages. However, there's
- no point of sideloading update packages when the bootloader is unlocked and there's no
- value in a locked bootloader without signing the build using release keys, since
- verified boot will be meaningless and the keys used to verify sideloaded updates are
- also public. The only reason to use update packages or a locked bootloader without
- signing the build with release keys would be testing that functionality and it makes a
- lot more sense to test it with proper signing keys rather than the default public test
- keys. Technically, you could generate test key signed update packages. However, there's
+ no point of sideloading update packages when the bootloader is unlocked and there's no
+ value in a locked bootloader without signing the build using release keys, since
+ verified boot will be meaningless and the keys used to verify sideloaded updates are
+ also public. The only reason to use update packages or a locked bootloader without
+ signing the build with release keys would be testing that functionality and it makes a
+ lot more sense to test it with proper signing keys rather than the default public test
+ keys. Keys need to be generated for resigning completed builds from the publicly
- available test keys. The keys must then be reused for subsequent builds and cannot be
- changed without flashing the generated factory images again which will perform a
- factory reset. Note that the keys are used for a lot more than simply verifying
- updates and verified boot. Keys need to be generated for resigning completed builds from the publicly
+ available test keys. The keys must then be reused for subsequent builds and cannot be
+ changed without flashing the generated factory images again which will perform a
+ factory reset. Note that the keys are used for a lot more than simply verifying
+ updates and verified boot. The sample certificate subject ( The sample certificate subject ( You should set a passphrase for the signing keys to keep them at rest until you
- need to sign a release with them. The GrapheneOS scripts ( You should set a passphrase for the signing keys to keep them at rest until you
+ need to sign a release with them. The GrapheneOS scripts ( The encryption passphrase for all the keys generated for a device needs to
- match for compatibility with the GrapheneOS scripts. The encryption passphrase for all the keys generated for a device needs to
+ match for compatibility with the GrapheneOS scripts. To generate keys for crosshatch (you should use unique keys per device
- variant): To generate keys for crosshatch (you should use unique keys per device
+ variant): The The Generate a signify key for signing factory images: Generate a signify key for signing factory images: Remove the Remove the You can (re-)encrypt your signing keys using the You can (re-)encrypt your signing keys using the The The GrapheneOS disables updatable APEX components for the officially supported devices
- and targets inheriting from the mainline target, so APEX signing keys are not needed
- and this section can be ignored for unmodified builds. GrapheneOS disables updatable APEX components for the officially supported devices
+ and targets inheriting from the mainline target, so APEX signing keys are not needed
+ and this section can be ignored for unmodified builds. GrapheneOS uses the GrapheneOS uses the If you don't disable updatable APEX packages, you need to generate an APK and
- AVB key for each APEX component and extend the GrapheneOS release.sh script to pass
- the appropriate parameters to replace the APK and AVB keys for each APEX
- component. If you don't disable updatable APEX packages, you need to generate an APK and
+ AVB key for each APEX component and extend the GrapheneOS release.sh script to pass
+ the appropriate parameters to replace the APK and AVB keys for each APEX
+ component. APEX components that are not flattened are a signed APK (used to verify updates)
- with an embedded filesystem image signed with an AVB key (for verified boot). Each
- APEX package must have a unique set of keys. GrapheneOS has no use for these
- out-of-band updates at this time and flattening APEX components avoids needing a bunch
- of extra keys and complexity. APEX components that are not flattened are a signed APK (used to verify updates)
+ with an embedded filesystem image signed with an AVB key (for verified boot). Each
+ APEX package must have a unique set of keys. GrapheneOS has no use for these
+ out-of-band updates at this time and flattening APEX components avoids needing a bunch
+ of extra keys and complexity. For now, consult the upstream documentation on generating these keys. It will be
- covered here in the future. For now, consult the upstream documentation on generating these keys. It will be
+ covered here in the future. Build and package up the tools needed to generate over-the-air update packages: Build and package up the tools needed to generate over-the-air update packages: Generate a signed release build with the release.sh script: Generate a signed release build with the release.sh script: The factory images and update package will be in
- The factory images and update package will be in
+ See the install guide for information on how to use the
- factory images. See the usage guide section on
- sideloading updates for information on how to use the update packages. See the install guide for information on how to use the
+ factory images. See the usage guide section on
+ sideloading updates for information on how to use the update packages. Running Running For GrapheneOS itself, the testing channel is used to push out updates to developer
- devices, followed by a sample future release to test that the release which is about
- to be pushed out to the Beta channel is able to update to a future release. Once it's
- tested internally, the release is pushed out to the Beta channel, and finally to the
- Stable channel after public testing. A similar approach is recommended for derivatives
- of GrapheneOS. For GrapheneOS itself, the testing channel is used to push out updates to developer
+ devices, followed by a sample future release to test that the release which is about
+ to be pushed out to the Beta channel is able to update to a future release. Once it's
+ tested internally, the release is pushed out to the Beta channel, and finally to the
+ Stable channel after public testing. A similar approach is recommended for derivatives
+ of GrapheneOS. Incremental updates shipping only the changes between two versions can be generated
- as a much more efficient way of shipping updates than a full update package containing
- the entire operating system. The GrapheneOS Updater app will automatically use a delta
- update if one exists for going directly from the currently installed version to the
- latest release. In order to generate a delta update, the original signed target files
- package for both the source version and target version are needed. The
- Incremental updates shipping only the changes between two versions can be generated
+ as a much more efficient way of shipping updates than a full update package containing
+ the entire operating system. The GrapheneOS Updater app will automatically use a delta
+ update if one exists for going directly from the currently installed version to the
+ latest release. In order to generate a delta update, the original signed target files
+ package for both the source version and target version are needed. The
+ The script assumes that the releases are organized in the following directory
- structure: The script assumes that the releases are organized in the following directory
+ structure: Incremental updates are uploaded alongside the update packages and update metadata
- on the static web server used as an update server. The update client will
- automatically check for an incremental update and use it if available. No additional
- metadata is needed to make incremental updates work. Incremental updates are uploaded alongside the update packages and update metadata
+ on the static web server used as an update server. The update client will
+ automatically check for an incremental update and use it if available. No additional
+ metadata is needed to make incremental updates work.Building GrapheneOS
-
- Build targets
-
+ Build targets
-
-
+
+
-
-
+
+
-
-
+
+
-
- Build dependencies
-
+ Build dependencies
-
-
+
+
-
-
+
+
- repo
as a distribution package or the
- self-updating standalone version from the Android Open Source Project. The
- self-updating variant avoids dealing with out-of-date distribution packages and
- depends on GPG to verify updates.repo
as a distribution package or the
+ self-updating standalone version from the Android Open Source Project. The
+ self-updating variant avoids dealing with out-of-date distribution packages and
+ depends on GPG to verify updates.
-
+
+
-
-
+
+
-
-
+
+
- signify
tool (with the proper naming) is also required for signing
- factory images zips.signify
tool (with the proper naming) is also required for signing
+ factory images zips.
- Downloading source code
-
+ Downloading source code
-
- Development branch
-
+
+ Development branch
+
- 11
branch is the only active development branch for GrapheneOS
- development. Older branches are no longer maintained. It is currently used for all
- officially supported devices and should be used for the basis of ports to other
- devices. Occasionally, some devices may be supported through device support branches
- to avoid impacting other devices with changes needed to support them.11
branch is the only active development branch for GrapheneOS
+ development. Older branches are no longer maintained. It is currently used for all
+ officially supported devices and should be used for the basis of ports to other
+ devices. Occasionally, some devices may be supported through device support branches
+ to avoid impacting other devices with changes needed to support them.mkdir grapheneos-11
+
mkdir grapheneos-11
cd grapheneos-11
repo init -u https://github.com/GrapheneOS/platform_manifest.git -b 11
repo sync -j32
- repo sync
fails, you can run the
- repo sync
command again to continue from where it was interrupted. It
- handles connection failures robustly and you shouldn't start over from scratch.repo sync
fails, you can run the
+ repo sync
command again to continue from where it was interrupted. It
+ handles connection failures robustly and you shouldn't start over from scratch.
- Stable release
-
+
+ Stable release
+
- mkdir grapheneos-TAG_NAME
+
mkdir grapheneos-TAG_NAME
cd grapheneos-TAG_NAME
repo init -u https://github.com/GrapheneOS/platform_manifest.git -b refs/tags/TAG_NAME
- gpg --recv-keys 65EEFE022108E2B708CBFCF7F9E712E59AF5F22A
+
gpg --recv-keys 65EEFE022108E2B708CBFCF7F9E712E59AF5F22A
cd .repo/manifests
git verify-tag $(git describe)
cd ../..
- repo sync -j32
+ repo sync -j32
-
- Updating and switching branches or tags
-
+
-
- Kernel
-
+ Kernel
-
-
+
-
-
-
-
+
-
+
+
+
+ repo
. There's no harm in
- running the submodule commands for other devices as they will simply not do
- anything.repo
. There's no harm in
+ running the submodule commands for other devices as they will simply not do
+ anything.cd kernel/google/crosshatch
+
cd kernel/google/crosshatch
git submodule sync
git submodule update --init --recursive
./build.sh blueline
+
- Setting up the OS build environment
-
+ Setting up the OS build environment
- source script/envsetup.sh
+ source script/envsetup.sh
- aosp_crosshatch
is the Pixel 3 XL):aosp_crosshatch
is the Pixel 3 XL):choosecombo release aosp_crosshatch user
+ choosecombo release aosp_crosshatch user
- user
with
- userdebug
in order to have better debugging support. Production builds
- should be user
builds as they are significantly more secure and don't
- make additional performance sacrifices to improve debugging.user
with
+ userdebug
in order to have better debugging support. Production builds
+ should be user
builds as they are significantly more secure and don't
+ make additional performance sacrifices to improve debugging.OFFICIAL_BUILD=true
to include the Updater app. You
- must change the URL in
- packages/apps/Updater/res/values/config.xml
to your own update server
- URL. Using the official update server with a build signed with different keys will not
- work and will essentially perform a denial of service attack on our update service. If
- you try to use the official URL, the app will download an official update and will
- detect it as corrupted or tampered. It will delete the update and try to download it
- over and over again since it will never be signed with your key.OFFICIAL_BUILD=true
to include the Updater app. You
+ must change the URL in
+ packages/apps/Updater/res/values/config.xml
to your own update server
+ URL. Using the official update server with a build signed with different keys will not
+ work and will essentially perform a denial of service attack on our update service. If
+ you try to use the official URL, the app will download an official update and will
+ detect it as corrupted or tampered. It will delete the update and try to download it
+ over and over again since it will never be signed with your key.export OFFICIAL_BUILD=true
+ export OFFICIAL_BUILD=true
+
- Reproducible builds
-
+ Reproducible builds
- BUILD_DATETIME
and
- BUILD_NUMBER
to the values set for the past build. These can be obtained
- from out/build_date.txt
and out/build_number.txt
in a build
- output directory and the ro.build.date.utc
and
- ro.build.version.incremental
properties which are also included in the
- over-the-air zip metadata rather than just the OS itself.BUILD_DATETIME
and
+ BUILD_NUMBER
to the values set for the past build. These can be obtained
+ from out/build_date.txt
and out/build_number.txt
in a build
+ output directory and the ro.build.date.utc
and
+ ro.build.version.incremental
properties which are also included in the
+ over-the-air zip metadata rather than just the OS itself.OFFICIAL_BUILD=true
per the instructions above to
- reproduce the official builds. Note that if you do not change the URL to your own
- domain, you must disable the Updater app before connecting the device
- to the internet, or you will be performing a denial of service attack on our official
- update server.OFFICIAL_BUILD=true
per the instructions above to
+ reproduce the official builds. Note that if you do not change the URL to your own
+ domain, you must disable the Updater app before connecting the device
+ to the internet, or you will be performing a denial of service attack on our official
+ update server.
- Extracting vendor files for Pixel devices
-
+ Extracting vendor files for Pixel devices
- vendor/android-prepare-vendor/execute-all.sh -d DEVICE -b BUILD_ID -o vendor/android-prepare-vendor
+
vendor/android-prepare-vendor/execute-all.sh -d DEVICE -b BUILD_ID -o vendor/android-prepare-vendor
mkdir -p vendor/google_devices
rm -rf vendor/google_devices/DEVICE
mv vendor/android-prepare-vendor/DEVICE/BUILD_ID/vendor/google_devices/* vendor/google_devices/
- --timestamp
(seconds since Epoch).--timestamp
(seconds since Epoch).
- Building
-
+ Building
- rm -r out
+ rm -r out
- m
command:m
command:m target-files-package
+ m target-files-package
- -j
parameter can be passed to m
to set a specific
- number of jobs such as -j4
to use 4 jobs. By default, the build system
- sets the number of jobs to NumCPU() + 2
where NumCPU()
is the
- number of available logical CPUs.-j
parameter can be passed to m
to set a specific
+ number of jobs such as -j4
to use 4 jobs. By default, the build system
+ sets the number of jobs to NumCPU() + 2
where NumCPU()
is the
+ number of available logical CPUs.
- Faster builds for development use only
-
+ Faster builds for development use only
- m
+ m
-
- Generating release signing keys
-
+ Generating release signing keys
- CN=GrapheneOS
) should be replaced with
- your own information.CN=GrapheneOS
) should be replaced with
+ your own information.make_key
and
- encrypt_keys.sh
) encrypt the signing keys using scrypt for key derivation
- and AES256 as the cipher. If you use swap, make sure it's encrypted, ideally with an
- ephemeral key rather a persistent key to support hibernation. Even with an ephemeral
- key, swap will reduce the security gained from encrypting the keys since it breaks the
- guarantee that they become at rest as soon as the signing process is finished.
- Consider disabling swap, at least during the signing process.make_key
and
+ encrypt_keys.sh
) encrypt the signing keys using scrypt for key derivation
+ and AES256 as the cipher. If you use swap, make sure it's encrypted, ideally with an
+ ephemeral key rather a persistent key to support hibernation. Even with an ephemeral
+ key, swap will reduce the security gained from encrypting the keys since it breaks the
+ guarantee that they become at rest as soon as the signing process is finished.
+ Consider disabling swap, at least during the signing process.mkdir -p keys/crosshatch
+
mkdir -p keys/crosshatch
cd keys/crosshatch
../../development/tools/make_key releasekey '/CN=GrapheneOS/'
../../development/tools/make_key platform '/CN=GrapheneOS/'
@@ -567,121 +566,121 @@ openssl genrsa 4096 | openssl pkcs8 -topk8 -scrypt -out avb.pem
../../external/avb/avbtool extract_public_key --key avb.pem --output avb_pkmd.bin
cd ../..
- avb_pkmd.bin
file isn't needed for generating a signed release but
- rather to set the public key used by the device to enforce verified boot.avb_pkmd.bin
file isn't needed for generating a signed release but
+ rather to set the public key used by the device to enforce verified boot.signify -G -n -p keys/crosshatch/factory.pub -s keys/crosshatch/factory.sec
+ signify -G -n -p keys/crosshatch/factory.pub -s keys/crosshatch/factory.sec
- -n
switch to set a passphrase. The signify
- tool doesn't provide a way to change the passphrase without generating a new key, so
- this is currently handled separately from encrypting the other keys and there will be
- a separate prompt for the passphrase. In the future, expect this to be handled by the
- same scripts along with the expectation of it using the same passphrase as the other
- keys.-n
switch to set a passphrase. The signify
+ tool doesn't provide a way to change the passphrase without generating a new key, so
+ this is currently handled separately from encrypting the other keys and there will be
+ a separate prompt for the passphrase. In the future, expect this to be handled by the
+ same scripts along with the expectation of it using the same passphrase as the other
+ keys.
- Encrypting keys
-
+
+ Encrypting keys
+
- encrypt_keys
script,
- which will prompt for the old passphrase (if any) and new passphrase:encrypt_keys
script,
+ which will prompt for the old passphrase (if any) and new passphrase:script/encrypt_keys.sh keys/crosshatch
+ script/encrypt_keys.sh keys/crosshatch
- script/decrypt_keys.sh
script can be used to remove encryption,
- which is not recommended. The script exists primarily for internal usage to decrypt
- the keys in tmpfs to perform signing.script/decrypt_keys.sh
script can be used to remove encryption,
+ which is not recommended. The script exists primarily for internal usage to decrypt
+ the keys in tmpfs to perform signing.
- Enabling updatable APEX components
-
+
+ Enabling updatable APEX components
+
- TARGET_FLATTEN_APEX := true
format to include APEX
- components as part of the base OS without supporting out-of-band updates.TARGET_FLATTEN_APEX := true
format to include APEX
+ components as part of the base OS without supporting out-of-band updates.
- Generating signed factory images and full update packages
-
+ Generating signed factory images and full update packages
- m otatools-package
+ m otatools-package
- script/release.sh crosshatch
+ script/release.sh crosshatch
- out/release-crosshatch-$BUILD_NUMBER
. The update zip performs a full OS
- installation so it can be used to update from any previous version. More efficient
- incremental updates are used for official over-the-air GrapheneOS updates and can be
- generated by keeping around past signed target_files
zips and generating
- incremental updates from those to the most recent signed target_files
- zip.out/release-crosshatch-$BUILD_NUMBER
. The update zip performs a full OS
+ installation so it can be used to update from any previous version. More efficient
+ incremental updates are used for official over-the-air GrapheneOS updates and can be
+ generated by keeping around past signed target_files
zips and generating
+ incremental updates from those to the most recent signed target_files
+ zip.script/release.sh
also generates channel metadata for the
- update server. If you configured the Updater client URL and set the build to include
- it (see the information on OFFICIAL_BUILD
above), you can push signed
- over-the-air updates via the update system. Simply upload the update package to the
- update server along with the channel metadata for the release channel, and it will be
- pushed out to the update client. The $DEVICE-beta
and
- $DEVICE-stable
metadata provide the Beta and Stable release channels used
- by the update client. The $DEVICE-testing
metadata provides
- provides an internal testing channel for the OS developers, which can be temporarily
- enabled using adb shell setprop sys.update.channel testing
. The name is
- arbitrary and you can also use any other name for internal testing channels.script/release.sh
also generates channel metadata for the
+ update server. If you configured the Updater client URL and set the build to include
+ it (see the information on OFFICIAL_BUILD
above), you can push signed
+ over-the-air updates via the update system. Simply upload the update package to the
+ update server along with the channel metadata for the release channel, and it will be
+ pushed out to the update client. The $DEVICE-beta
and
+ $DEVICE-stable
metadata provide the Beta and Stable release channels used
+ by the update client. The $DEVICE-testing
metadata provides
+ provides an internal testing channel for the OS developers, which can be temporarily
+ enabled using adb shell setprop sys.update.channel testing
. The name is
+ arbitrary and you can also use any other name for internal testing channels.
- Generating delta updates
-
+
+ Generating delta updates
+
- script/generate_delta.sh
script provides a wrapper script for generating
- delta updates by passing the device, source version build number and target version
- build number. For example:script/generate_delta.sh
script provides a wrapper script for generating
+ delta updates by passing the device, source version build number and target version
+ build number. For example:script/generate_delta.sh crosshatch 2019.09.25.00 2019.10.07.21
+ script/generate_delta.sh crosshatch 2019.09.25.00 2019.10.07.21
- releases
+
- releases
├── 2019.09.25.00
│ └── release-crosshatch-2019.09.25.00
│ ├── crosshatch-factory-2019.09.25.00.zip
@@ -699,10 +698,11 @@ cd ../..
├── crosshatch-target_files-2019.10.07.21.zip
└── crosshatch-testing
Vanadium is a hardened fork of Chromium developed by GrapheneOS and used to provide - the WebView and optionally the standalone browser app. It tracks the Chromium - release cycles along with having additional updates for downstream changes to the - privacy and security hardening patches, so it's updated at a different schedule than - the monthly Android releases.
+Vanadium is a hardened fork of Chromium developed by GrapheneOS and used to provide + the WebView and optionally the standalone browser app. It tracks the Chromium + release cycles along with having additional updates for downstream changes to the + privacy and security hardening patches, so it's updated at a different schedule than + the monthly Android releases.
-The browser and the WebView are independent applications built from the Chromium - source tree. The GrapheneOS browser build is located at external/vanadium and the - WebView is at external/chromium-webview.
+The browser and the WebView are independent applications built from the Chromium + source tree. The GrapheneOS browser build is located at external/vanadium and the + WebView is at external/chromium-webview.
-See - Chromium's Android build instructions for details on obtaining the - prerequisites.
+See + Chromium's Android build instructions for details on obtaining the + prerequisites.
-git clone https://github.com/GrapheneOS/Vanadium.git +git clone https://github.com/GrapheneOS/Vanadium.git cd Vanadium git checkout $CORRECT_BRANCH_OR_TAG-Generate a signing key for Vanadium if this is the initial build:
+Generate a signing key for Vanadium if this is the initial build:
-keytool -genkey -v -keystore vanadium.keystore -storetype pkcs12 -alias vanadium -keyalg RSA -keysize 4096 -sigalg SHA512withRSA -validity 10000 -dname "cn=GrapheneOS"+keytool -genkey -v -keystore vanadium.keystore -storetype pkcs12 -alias vanadium -keyalg RSA -keysize 4096 -sigalg SHA512withRSA -validity 10000 -dname "cn=GrapheneOS"-You will be prompted to enter a password which will be requested by the -
+generate_release.sh
script for signing releases. You should back up - the generated keystore with your other keys.You will be prompted to enter a password which will be requested by the +
-generate_release.sh
script for signing releases. You should back up + the generated keystore with your other keys.Fetch the Chromium sources:
+Fetch the Chromium sources:
-fetch --nohooks android+fetch --nohooks android-Sync to the latest stable release for Android (replace
+$VERSION
with - the correct value):Sync to the latest stable release for Android (replace
-$VERSION
with + the correct value):cd src +cd src git fetch --tags git checkout $VERSION gclient sync -D --with_branch_heads --with_tags --jobs 32-Apply the GrapheneOS patches on top of the tagged release:
+Apply the GrapheneOS patches on top of the tagged release:
-git am --whitespace=nowarn ../patches/*.patch+git am --whitespace=nowarn ../patches/*.patch-Then, configure the build in the
+src
directory:Then, configure the build in the
-src
directory:gn args out/Default+gn args out/Default-Copy the GrapheneOS configuration from
+../args.gn
and save/exit the - editor. Modifytarget_cpu
as needed if the target is not arm64. For - x86_64, the correct value fortarget_cpu
isx64
, but note - that the Android source tree refers to it as x86_64.Copy the GrapheneOS configuration from
-../args.gn
and save/exit the + editor. Modifytarget_cpu
as needed if the target is not arm64. For + x86_64, the correct value fortarget_cpu
isx64
, but note + that the Android source tree refers to it as x86_64.You need to set
+trichrome_certdigest
to the correct value for your - generated signing key. You can obtain this with the following command:You need to set
-trichrome_certdigest
to the correct value for your + generated signing key. You can obtain this with the following command:keytool -export-cert -alias vanadium -keystore vanadium.keystore | sha256sum+keytool -export-cert -alias vanadium -keystore vanadium.keystore | sha256sum-Build the components:
+Build the components:
-ninja -C out/Default/ trichrome_webview_64_32_apk trichrome_chrome_64_32_bundle trichrome_library_64_32_apk+ninja -C out/Default/ trichrome_webview_64_32_apk trichrome_chrome_64_32_bundle trichrome_library_64_32_apk-Generate TrichromeChrome.apk from the bundle and sign the apks:
+Generate TrichromeChrome.apk from the bundle and sign the apks:
-../generate_release.sh+../generate_release.sh-The apks need to be copied from
+out/Default/apks/release/*.apk
- into the Android source tree at -external/vanadium/prebuilt/arm64/
with arm64 - substituted with the correct value for other architectures (arm, x86, x86_64).The apks need to be copied from
-out/Default/apks/release/*.apk
+ into the Android source tree at +external/vanadium/prebuilt/arm64/
with arm64 + substituted with the correct value for other architectures (arm, x86, x86_64).WebView provider apps need to be whitelisted in -
+frameworks/base/core/res/res/xml/config_webview_packages
. By default, - only the Vanadium WebView is whitelisted.WebView provider apps need to be whitelisted in +
+frameworks/base/core/res/res/xml/config_webview_packages
. By default, + only the Vanadium WebView is whitelisted.
The official releases of the Auditor and PdfViewer apps are bundled as an apk into
- external/ repositories. There are no modifications to these for GrapheneOS. These are
- built and signed with the standard gradle
Android plugin build
- system.
The official releases of the Auditor and PdfViewer apps are bundled as an apk into
+ external/ repositories. There are no modifications to these for GrapheneOS. These are
+ built and signed with the standard gradle
Android plugin build
+ system.
A build of Seedvault is bundled as an apk into an external/ repository. There are - no modifications made to it.
+A build of Seedvault is bundled as an apk into an external/ repository. There are + no modifications made to it.
+To test a build for the emulator, run emulator
within the build
- environment. The emulator will use CPU hardware acceleration via KVM along with
- optional graphics acceleration via the host GPU if these are available.
To test a build for the emulator, run emulator
within the build
+ environment. The emulator will use CPU hardware acceleration via KVM along with
+ optional graphics acceleration via the host GPU if these are available.
Testing with the Compatibility Test Suite (CTS) can be done by either building the - test suite from source or using the official releases.
-Official releases of the CTS can be downloaded from - the Compatibility - Suite Downloads page. You should download the CTS for the relevant release - (Android 11) and architecture (ARM). There's a separate zip for the main CTS, the - manual portion (CTS Verifier) and the CTS for Instant Apps. The latest release of the - CTS Media Files also needs to be downloaded from that section.
+Testing with the Compatibility Test Suite (CTS) can be done by either building the + test suite from source or using the official releases.
+Official releases of the CTS can be downloaded from + the Compatibility + Suite Downloads page. You should download the CTS for the relevant release + (Android 11) and architecture (ARM). There's a separate zip for the main CTS, the + manual portion (CTS Verifier) and the CTS for Instant Apps. The latest release of the + CTS Media Files also needs to be downloaded from that section.
-mkdir -p ~/android/cts/{arm,x86} +mkdir -p ~/android/cts/{arm,x86} cd ~/android/cts/arm curl -O https://dl.google.com/dl/android/cts/android-cts-11_r1-linux_x86-arm.zip unzip android-cts-11_r1-linux_x86-arm.zip @@ -998,65 +997,66 @@ curl -O https://dl.google.com/dl/android/cts/android-cts-media-1.5.zip unzip android-cts-media-1.5.zip rm android-cts-media-1.5.zip-- Setup -
-You'll need a device attached to your computer with ADB enabled along with the - Android SDK installed. The build-tools and platform-tools packages need to be - installed and the binaries need to be added to your PATH. See the - standalone SDK installation instructions above.
++ Setup +
+You'll need a device attached to your computer with ADB enabled along with the + Android SDK installed. The build-tools and platform-tools packages need to be + installed and the binaries need to be added to your PATH. See the + standalone SDK installation instructions above.
-Copy media onto the device:
-cd android-cts-media-1.5 +Copy media onto the device:
+cd android-cts-media-1.5 ./copy_images.sh ./copy_media.sh-You also need to do some basic setup for the device. It's possible for changes from - a baseline install to cause interference, so it can be a good idea to factory reset - the device if assorted changes have been made. The device needs to be running a user - build for the security model to be fully intact in order to pass all the security - tests. A userdebug build is expected to fail some of the tests. GrapheneOS also makes - various changes intentionally deviating from the requirements expected by the CTS, so - there will always be some expected failures. A few of the tests are also known to be - quite flaky or broken even with the stock OS and/or AOSP. These will be documented - here at some point.
+You also need to do some basic setup for the device. It's possible for changes from + a baseline install to cause interference, so it can be a good idea to factory reset + the device if assorted changes have been made. The device needs to be running a user + build for the security model to be fully intact in order to pass all the security + tests. A userdebug build is expected to fail some of the tests. GrapheneOS also makes + various changes intentionally deviating from the requirements expected by the CTS, so + there will always be some expected failures. A few of the tests are also known to be + quite flaky or broken even with the stock OS and/or AOSP. These will be documented + here at some point.
-
Run the test harness:
-./android-cts/tools/cts-tradefed-
Note that _JAVA_OPTIONS
being set will break the version detection.
To obtain a list of CTS modules:
-list modules-
To run a specific module and avoid wasting time capturing device information:
-run cts --skip-device-info --module CtsModuleName-
To speed up initialization after running some initial tests:
-run cts --skip-device-info --skip-preconditions --module CtsModuleName-
It's possible to run the whole standard CTS plan with a single command, but running - specific modules is recommended, especially if you don't have everything set up for - the entire test suite.
+Run the test harness:
+./android-cts/tools/cts-tradefed+
Note that _JAVA_OPTIONS
being set will break the version detection.
To obtain a list of CTS modules:
+list modules+
To run a specific module and avoid wasting time capturing device information:
+run cts --skip-device-info --module CtsModuleName+
To speed up initialization after running some initial tests:
+run cts --skip-device-info --skip-preconditions --module CtsModuleName+
It's possible to run the whole standard CTS plan with a single command, but running + specific modules is recommended, especially if you don't have everything set up for + the entire test suite.
+The following programming languages are acceptable for completely - new GrapheneOS projects:
-no_std
for low-level code used in a hypervisor, kernel,
- daemon, system library, etc. Keep in mind that low-level code is to be avoided
- whenever a higher-level language is better suited to the job. In general,
- the project aims to avoid creating more low-level code manually dealing with
- memory ownership and lifetimes in the first place.The following programming languages are acceptable for completely + new GrapheneOS projects:
+no_std
for low-level code used in a hypervisor, kernel,
+ daemon, system library, etc. Keep in mind that low-level code is to be avoided
+ whenever a higher-level language is better suited to the job. In general,
+ the project aims to avoid creating more low-level code manually dealing with
+ memory ownership and lifetimes in the first place.Much of the work is done on existing projects, and the existing languages should be - used unless there are already clear stable API boundaries where a different language - could be used without causing a substantial maintenance burden. The following - languages are typical from most to least common: Java, C++, C, JavaScript, arm64 - assembly, POSIX shell, Bash.
+Much of the work is done on existing projects, and the existing languages should be + used unless there are already clear stable API boundaries where a different language + could be used without causing a substantial maintenance burden. The following + languages are typical from most to least common: Java, C++, C, JavaScript, arm64 + assembly, POSIX shell, Bash.
+For existing projects, use the official upstream code style. Avoid using legacy - conventions that they're moving away from themselves. Follow the code style they use - for new additions. Some projects have different code styles for different directories - or files depending on their sources, in which case respect the per-file style.
+For existing projects, use the official upstream code style. Avoid using legacy + conventions that they're moving away from themselves. Follow the code style they use + for new additions. Some projects have different code styles for different directories + or files depending on their sources, in which case respect the per-file style.
-For new projects, follow the official code style for the language. Treat the
- standard library APIs as defining the naming style for usage of the language, i.e. C
- uses variable_or_function_name
, type_name
,
- MACRO_NAME
while JavaScript uses variable_or_function_name
,
- ClassName
and CONSTANT_NAME
. For Python, follow PEP8 and the
- same goes for other languages with official styles whether defined in a document or by
- the default mode for the official formatting tool like rustfmt
.
For new projects, follow the official code style for the language. Treat the
+ standard library APIs as defining the naming style for usage of the language, i.e. C
+ uses variable_or_function_name
, type_name
,
+ MACRO_NAME
while JavaScript uses variable_or_function_name
,
+ ClassName
and CONSTANT_NAME
. For Python, follow PEP8 and the
+ same goes for other languages with official styles whether defined in a document or by
+ the default mode for the official formatting tool like rustfmt
.
For cases where there isn't an official or prevailing code style for other things,
- avoid tabs, use 4-space indents, function_name
,
- variable_name
, TypeName
and CONSTANT_NAME
.
- Prefer single-line comment syntax other than rare cases where it makes sense to add a
- tiny comment within a line of code. In languages with the optional braces misfeature
- (C, C++, Java), always use them. Open braces on the same line as function definitions
- / statements. Wrap lines at 100 columns except in rare cases where it would be far
- uglier to wrap the line.
For cases where there isn't an official or prevailing code style for other things,
+ avoid tabs, use 4-space indents, function_name
,
+ variable_name
, TypeName
and CONSTANT_NAME
.
+ Prefer single-line comment syntax other than rare cases where it makes sense to add a
+ tiny comment within a line of code. In languages with the optional braces misfeature
+ (C, C++, Java), always use them. Open braces on the same line as function definitions
+ / statements. Wrap lines at 100 columns except in rare cases where it would be far
+ uglier to wrap the line.
For JavaScript, all code should be contained within ES6 modules. This means every
- script element should use type="module"
. Modules provide proper
- namespacing with explicit imports and exports. Modules automatically use strict mode,
- so "use strict";
is no longer needed. By default, modules are also
- deferred until after the DOM is ready, i.e. they have an implicit defer
- attribute. This should be relied upon rather than unnecessarily listening for an event
- to determine if the DOM is ready for use. It can make sense to use async
- to run the code earlier if the JavaScript is essential to the content and benefits
- from being able to start tasks before the DOM is ready, such as retrieving important
- content or checking if there's a login session. Always end lines with semicolons
- (since automatic insertion is poorly designed) and always use const
to
- declare variables, unless they are reassigned in which case they should be declared
- with let
but never use var
as it is effectively broken. Try
- to prefer loops with for..of
. JavaScript must pass verification with
- eslint
using the following .eslintrc.json
configuration:
For JavaScript, all code should be contained within ES6 modules. This means every
+ script element should use type="module"
. Modules provide proper
+ namespacing with explicit imports and exports. Modules automatically use strict mode,
+ so "use strict";
is no longer needed. By default, modules are also
+ deferred until after the DOM is ready, i.e. they have an implicit defer
+ attribute. This should be relied upon rather than unnecessarily listening for an event
+ to determine if the DOM is ready for use. It can make sense to use async
+ to run the code earlier if the JavaScript is essential to the content and benefits
+ from being able to start tasks before the DOM is ready, such as retrieving important
+ content or checking if there's a login session. Always end lines with semicolons
+ (since automatic insertion is poorly designed) and always use const
to
+ declare variables, unless they are reassigned in which case they should be declared
+ with let
but never use var
as it is effectively broken. Try
+ to prefer loops with for..of
. JavaScript must pass verification with
+ eslint
using the following .eslintrc.json
configuration:
{ +-{ "env": { "browser": true, "es2021": true @@ -1207,67 +1206,68 @@ rm android-cts-media-1.5.zip} }
Cookies are only used for login sessions. The only other use case considered valid
- would be optimizing HTTP/2 Server Push but the intention is only to use that for
- render blocking CSS and it's not really worth optimizing for caching when the CSS is
- tiny in practice. Every cookie must have the __Host
prefix to guarantee
- that it has the Secure
attribute and Path=/
. The
- HttpOnly
and SameSite=Strict
flags should also always be
- included. These kinds of cookies can provide secure login sessions in browsers with
- fully working SameSite=Strict
support. However, CSRF tokens should still
- be used for the near future in case there are browser issues.
Cookies are only used for login sessions. The only other use case considered valid
+ would be optimizing HTTP/2 Server Push but the intention is only to use that for
+ render blocking CSS and it's not really worth optimizing for caching when the CSS is
+ tiny in practice. Every cookie must have the __Host
prefix to guarantee
+ that it has the Secure
attribute and Path=/
. The
+ HttpOnly
and SameSite=Strict
flags should also always be
+ included. These kinds of cookies can provide secure login sessions in browsers with
+ fully working SameSite=Strict
support. However, CSRF tokens should still
+ be used for the near future in case there are browser issues.
For web content, use dashes as user-facing word separators rather than underscores. - Page titles should follow the scheme "Page | Directory | Higher-level directory | - Site" for usability with a traditional title as the Open Graph title.
+For web content, use dashes as user-facing word separators rather than underscores. + Page titles should follow the scheme "Page | Directory | Higher-level directory | + Site" for usability with a traditional title as the Open Graph title.
-HTML must pass verification with validatornu
and xmllint
.
- Ensuring that it parses as XML with xmllint
catches many common mistakes
- and typos that are missed by HTML validation due to the ridiculously permissive nature
- of HTML. This enforces closing every tag, using proper escaping and so on. XHTML does
- not really exist anymore and we simply use XML parsing as an enforced coding standard
- and lint pass. It can also be useful to make it compatible with XML-based tooling.
HTML must pass verification with validatornu
and xmllint
.
+ Ensuring that it parses as XML with xmllint
catches many common mistakes
+ and typos that are missed by HTML validation due to the ridiculously permissive nature
+ of HTML. This enforces closing every tag, using proper escaping and so on. XHTML does
+ not really exist anymore and we simply use XML parsing as an enforced coding standard
+ and lint pass. It can also be useful to make it compatible with XML-based tooling.
Avoid designing around class inheritance unless it's a rare case where it's an - extremely good fit or the language sucks (Java) and it's the least bad approach, but - still try to avoid it.
+Avoid designing around class inheritance unless it's a rare case where it's an + extremely good fit or the language sucks (Java) and it's the least bad approach, but + still try to avoid it.
-Use concise but self-explanatory variable names. Prefer communicating information
- via naming rather than using comments whenever possible. Don't name variables
- i
, j
, k
, etc. like C programmers. It's okay to
- use things like x
and y
for parameters if the function is
- genuinely that generic and operates on arbitrary values. In general, try to scope
- variables into the most limited scope (in C or C++, be careful about this when
- references are taken).
Use concise but self-explanatory variable names. Prefer communicating information
+ via naming rather than using comments whenever possible. Don't name variables
+ i
, j
, k
, etc. like C programmers. It's okay to
+ use things like x
and y
for parameters if the function is
+ genuinely that generic and operates on arbitrary values. In general, try to scope
+ variables into the most limited scope (in C or C++, be careful about this when
+ references are taken).
Write code that's clean and self-explanatory. Use comments to explain or justify - non-obvious things, but try to avoid needing them in the first place. In most cases, - they should just be communicating non-local information such as explaining why an - invariant is true based on the code elsewhere (consider a runtime check to make sure - it's true, or an assertion if performance would be an issue). Docstrings at the top of - top-level functions, modules, etc. are a different story and shouldn't be avoided.
+Write code that's clean and self-explanatory. Use comments to explain or justify + non-obvious things, but try to avoid needing them in the first place. In most cases, + they should just be communicating non-local information such as explaining why an + invariant is true based on the code elsewhere (consider a runtime check to make sure + it's true, or an assertion if performance would be an issue). Docstrings at the top of + top-level functions, modules, etc. are a different story and shouldn't be avoided.
+Make extensive usage of well designed standard library modules. For apps, treat - Jetpack (androidx) as part of the standard library and make good use of it. For Java, - Guava can also be treated as part of the standard library.
+Make extensive usage of well designed standard library modules. For apps, treat + Jetpack (androidx) as part of the standard library and make good use of it. For Java, + Guava can also be treated as part of the standard library.
-Libraries outside of the standard library should be used very cautiously. They - should be well maintained, stable, well tested and widely used. Libraries implemented - with memory unsafe languages should generally be avoided (one exception: SQLite).
+Libraries outside of the standard library should be used very cautiously. They + should be well maintained, stable, well tested and widely used. Libraries implemented + with memory unsafe languages should generally be avoided (one exception: SQLite).
-Generally, frameworks and libraries existing solely to provide different paradigms - and coding patterns are to be avoided. They increase barrier to entry for developers, - generally only increase complexity unless used at very large scales (and may not even - make things simpler in those cases) and come and go as fads. This is only okay when - it's part of the standard libraries or libraries that are considered standard - (androidx, Guava) by GrapheneOS and should still be approached cautiously. Only use it - if it truly makes the correct approach simpler. Ignore fads and figure out if it - actually makes sense to use, otherwise just stick to the old fashioned way if the - fancy alternatives aren't genuinely better.
+Generally, frameworks and libraries existing solely to provide different paradigms + and coding patterns are to be avoided. They increase barrier to entry for developers, + generally only increase complexity unless used at very large scales (and may not even + make things simpler in those cases) and come and go as fads. This is only okay when + it's part of the standard libraries or libraries that are considered standard + (androidx, Guava) by GrapheneOS and should still be approached cautiously. Only use it + if it truly makes the correct approach simpler. Ignore fads and figure out if it + actually makes sense to use, otherwise just stick to the old fashioned way if the + fancy alternatives aren't genuinely better.
+