internal/app: unexport outcome, remove app struct

The App struct no longer does anything, and the outcome struct is entirely opaque.

Signed-off-by: Ophestra <cat@gensokyo.uk>

cmd/hakurei/command.go

@@ -6,11 +6,9 @@ import (
 	"io"
 	"log"
 	"os"
-	"os/signal"
 	"os/user"
 	"strconv"
 	"sync"
-	"syscall"
 	"time"
 
 	"hakurei.app/command"
@@ -25,7 +23,7 @@ import (
 	"hakurei.app/system/dbus"
 )
 
-func buildCommand(out io.Writer) command.Command {
+func buildCommand(ctx context.Context, out io.Writer) command.Command {
 	var (
 		flagVerbose bool
 		flagJSON    bool
@@ -45,7 +43,7 @@ func buildCommand(out io.Writer) command.Command {
 		config := tryPath(args[0])
 		config.Args = append(config.Args, args[1:]...)
 
-		runApp(config)
+		app.Main(ctx, std, config)
 		panic("unreachable")
 	})
 
@@ -165,8 +163,7 @@ func buildCommand(out io.Writer) command.Command {
 				}
 			}
 
-			// invoke app
+			app.Main(ctx, std, config)
-			runApp(config)
 			panic("unreachable")
 		}).
 			Flag(&flagDBusConfigSession, "dbus-config", command.StringFlag("builtin"),
@@ -249,22 +246,3 @@ func buildCommand(out io.Writer) command.Command {
 
 	return c
 }
-
-func runApp(config *hst.Config) {
-	ctx, stop := signal.NotifyContext(context.Background(),
-		syscall.SIGINT, syscall.SIGTERM)
-	defer stop() // unreachable
-	a := app.MustNew(ctx, std)
-
-	if sa, err := a.Seal(config); err != nil {
-		hlog.BeforeExit()
-		if m, ok := container.GetErrorMessage(err); ok {
-			log.Fatal(m)
-		} else {
-			log.Fatalln("cannot seal app:", err)
-		}
-	} else {
-		sa.Main()
-		panic("unreachable")
-	}
-}

cmd/hakurei/command_test.go

@@ -68,7 +68,7 @@ Flags:
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
 			out := new(bytes.Buffer)
-			c := buildCommand(out)
+			c := buildCommand(t.Context(), out)
 			if err := c.Parse(tc.args); !errors.Is(err, command.ErrHelp) && !errors.Is(err, flag.ErrHelp) {
 				t.Errorf("Parse: error = %v; want %v",
 					err, command.ErrHelp)

cmd/hakurei/main.go

@@ -4,10 +4,13 @@ package main
 //go:generate cp ../../LICENSE .
 
 import (
+	"context"
 	_ "embed"
 	"errors"
 	"log"
 	"os"
+	"os/signal"
+	"syscall"
 
 	"hakurei.app/container"
 	"hakurei.app/internal"
@@ -44,7 +47,11 @@ func main() {
 		log.Fatal("this program must not run as root")
 	}
 
-	buildCommand(os.Stderr).MustParse(os.Args[1:], func(err error) {
+	ctx, stop := signal.NotifyContext(context.Background(),
+		syscall.SIGINT, syscall.SIGTERM)
+	defer stop() // unreachable
+
+	buildCommand(ctx, os.Stderr).MustParse(os.Args[1:], func(err error) {
 		hlog.Verbosef("command returned %v", err)
 		if errors.Is(err, errSuccess) {
 			hlog.BeforeExit()

internal/app/app.go

@@ -3,83 +3,28 @@ package app
 
 import (
 	"context"
-	"fmt"
 	"log"
-	"sync"
+	"os"
 
 	"hakurei.app/hst"
 	"hakurei.app/internal/app/state"
 	"hakurei.app/internal/sys"
 )
 
-// New returns the address of a newly initialised [App] struct.
+// Main runs an app according to [hst.Config] and terminates. Main does not return.
-func New(ctx context.Context, os sys.State) (*App, error) {
+func Main(ctx context.Context, k sys.State, config *hst.Config) {
-	a := new(App)
+	var id state.ID
-	a.sys = os
+	if err := state.NewAppID(&id); err != nil {
-	a.ctx = ctx
+		log.Fatal(err)
-
-	id := new(state.ID)
-	err := state.NewAppID(id)
-	a.id = newID(id)
-
-	return a, err
 	}
 
-// MustNew calls [New] and panics if an error is returned.
+	var seal outcome
-func MustNew(ctx context.Context, os sys.State) *App {
+	seal.id = &stringPair[state.ID]{id, id.String()}
-	a, err := New(ctx, os)
+	if err := seal.finalise(ctx, k, config); err != nil {
-	if err != nil {
+		printMessageError("cannot seal app:", err)
-		log.Fatalf("cannot create app: %v", err)
+		os.Exit(1)
-	}
-	return a
 	}
 
-// An App keeps track of the hakurei container lifecycle.
+	seal.main()
-type App struct {
+	panic("unreachable")
-	outcome *Outcome
-
-	id  *stringPair[state.ID]
-	sys sys.State
-	ctx context.Context
-	mu  sync.RWMutex
-}
-
-// ID returns a copy of [state.ID] held by App.
-func (a *App) ID() state.ID { a.mu.RLock(); defer a.mu.RUnlock(); return a.id.unwrap() }
-
-func (a *App) String() string {
-	if a == nil {
-		return "<nil>"
-	}
-
-	a.mu.RLock()
-	defer a.mu.RUnlock()
-
-	if a.outcome != nil {
-		if a.outcome.user.uid == nil {
-			return "<invalid>"
-		}
-		return fmt.Sprintf("sealed app %s as uid %s", a.id, a.outcome.user.uid)
-	}
-
-	return fmt.Sprintf("unsealed app %s", a.id)
-}
-
-// Seal determines the [Outcome] of [hst.Config].
-// Values stored in and referred to by [hst.Config] might be overwritten and must not be used again.
-func (a *App) Seal(config *hst.Config) (*Outcome, error) {
-	a.mu.Lock()
-	defer a.mu.Unlock()
-
-	if a.outcome != nil {
-		panic("attempting to seal app twice")
-	}
-
-	seal := new(Outcome)
-	seal.id = a.id
-	err := seal.finalise(a.ctx, a.sys, config)
-	if err == nil {
-		a.outcome = seal
-	}
-	return seal, err
 }

internal/app/app_test.go

@@ -21,7 +21,7 @@ type sealTestCase struct {
 	config     *hst.Config
 	id         state.ID
 	wantSys    *system.I
-	wantContainer *container.Params
+	wantParams *container.Params
 }
 
 func TestApp(t *testing.T) {
@@ -29,40 +29,29 @@ func TestApp(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			a := app.NewWithID(t.Context(), tc.id, tc.os)
+			t.Run("finalise", func(t *testing.T) {
-			var (
+				sys, params, err := app.FinaliseIParams(t.Context(), tc.os, tc.config, &tc.id)
-				gotSys       *system.I
+				if err != nil {
-				gotContainer *container.Params
-			)
-			if !t.Run("seal", func(t *testing.T) {
-				if sa, err := a.Seal(tc.config); err != nil {
 					if s, ok := container.GetErrorMessage(err); !ok {
-						t.Errorf("Seal: error = %v", err)
+						t.Fatalf("Seal: error = %v", err)
 					} else {
-						t.Errorf("Seal: %s", s)
+						t.Fatalf("Seal: %s", s)
 					}
-					return
-				} else {
-					gotSys, gotContainer = app.AppIParams(a, sa)
-				}
-			}) {
-				return
 				}
 
-			t.Run("compare sys", func(t *testing.T) {
+				t.Run("sys", func(t *testing.T) {
-				if !gotSys.Equal(tc.wantSys) {
+					if !sys.Equal(tc.wantSys) {
-					t.Errorf("Seal: sys = %#v, want %#v",
+						t.Errorf("Seal: sys = %#v, want %#v", sys, tc.wantSys)
-						gotSys, tc.wantSys)
 					}
 				})
 
-			t.Run("compare params", func(t *testing.T) {
+				t.Run("params", func(t *testing.T) {
-				if !reflect.DeepEqual(gotContainer, tc.wantContainer) {
+					if !reflect.DeepEqual(params, tc.wantParams) {
-					t.Errorf("seal: params =\n%s\n, want\n%s",
+						t.Errorf("seal: params =\n%s\n, want\n%s", mustMarshal(params), mustMarshal(tc.wantParams))
-						mustMarshal(gotContainer), mustMarshal(tc.wantContainer))
 					}
 				})
 			})
+		})
 	}
 }
 

internal/app/export_test.go

@@ -4,18 +4,13 @@ import (
 	"context"
 
 	"hakurei.app/container"
+	"hakurei.app/hst"
 	"hakurei.app/internal/app/state"
 	"hakurei.app/internal/sys"
 	"hakurei.app/system"
 )
 
-func NewWithID(ctx context.Context, id state.ID, os sys.State) *App {
+func FinaliseIParams(ctx context.Context, k sys.State, config *hst.Config, id *state.ID) (*system.I, *container.Params, error) {
-	return &App{id: newID(&id), sys: os, ctx: ctx}
+	seal := outcome{id: &stringPair[state.ID]{*id, id.String()}}
-}
+	return seal.sys, seal.container, seal.finalise(ctx, k, config)
-
-func AppIParams(a *App, seal *Outcome) (*system.I, *container.Params) {
-	if a.outcome != seal || a.id != seal.id {
-		panic("broken app/outcome link")
-	}
-	return seal.sys, seal.container
 }

internal/app/process.go

@@ -22,7 +22,7 @@ import (
 // duration to wait for shim to exit, after container WaitDelay has elapsed.
 const shimWaitTimeout = 5 * time.Second
 
-// mainState holds persistent state bound to [Outcome.Main].
+// mainState holds persistent state bound to outcome.main.
 type mainState struct {
 	// done is whether beforeExit has been called already.
 	done bool
@@ -33,7 +33,7 @@ type mainState struct {
 	// Time is nil if no process was ever created.
 	Time *time.Time
 
-	seal    *Outcome
+	seal    *outcome
 	store   state.Store
 	cancel  context.CancelFunc
 	cmd     *exec.Cmd
@@ -218,9 +218,8 @@ func (ms mainState) fatal(fallback string, ferr error) {
 	os.Exit(1)
 }
 
-// Main commits deferred system setup, runs the container, reverts changes to the system, and terminates the program.
+// main carries out outcome and terminates. main does not return.
-// Main does not return.
+func (seal *outcome) main() {
-func (seal *Outcome) Main() {
 	if !seal.f.CompareAndSwap(false, true) {
 		panic("outcome: attempted to run twice")
 	}

internal/app/seal.go

@@ -32,8 +32,8 @@ func newWithMessageError(msg string, err error) error {
 	return &hst.AppError{Step: "finalise", Err: err, Msg: msg}
 }
 
-// An Outcome is the runnable state of a hakurei container via [hst.Config].
+// An outcome is the runnable state of a hakurei container via [hst.Config].
-type Outcome struct {
+type outcome struct {
 	// copied from initialising [app]
 	id *stringPair[state.ID]
 	// copied from [sys.State]
@@ -66,7 +66,7 @@ type shareHost struct {
 	// process-specific directory in XDG_RUNTIME_DIR, empty if unused
 	runtimeSharePath *container.Absolute
 
-	seal *Outcome
+	seal *outcome
 	sc   hst.Paths
 }
 
@@ -119,7 +119,7 @@ type hsuUser struct {
 	username string
 }
 
-func (seal *Outcome) finalise(ctx context.Context, k sys.State, config *hst.Config) error {
+func (seal *outcome) finalise(ctx context.Context, k sys.State, config *hst.Config) error {
 	const (
 		home  = "HOME"
 		shell = "SHELL"

internal/app/strings.go

@@ -2,12 +2,9 @@ package app
 
 import (
 	"strconv"
-
-	"hakurei.app/internal/app/state"
 )
 
 func newInt(v int) *stringPair[int] { return &stringPair[int]{v, strconv.Itoa(v)} }
-func newID(id *state.ID) *stringPair[state.ID] { return &stringPair[state.ID]{*id, id.String()} }
 
 // stringPair stores a value and its string representation.
 type stringPair[T comparable] struct {