From 1e0d68a29e824b25c556d28b6a0cd0c3ab39ffef Mon Sep 17 00:00:00 2001 From: Ophestra Date: Fri, 6 Mar 2026 23:39:12 +0900 Subject: [PATCH] internal/pkg: move output buffer to reader This side is the read end of a pipe and buffering reads from it ended up performing better than buffering one half of the TeeReader (which already goes through the kernel page cache anyway). Signed-off-by: Ophestra --- internal/pkg/exec.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/internal/pkg/exec.go b/internal/pkg/exec.go index 4283113..eb72ccb 100644 --- a/internal/pkg/exec.go +++ b/internal/pkg/exec.go @@ -440,28 +440,23 @@ func (a *execArtifact) cure(f *FContext, hostNet bool) (err error) { } }() - bw := f.cache.getWriter(status) + brStdout, brStderr := f.cache.getReader(stdout), f.cache.getReader(stderr) stdoutDone, stderrDone := make(chan struct{}), make(chan struct{}) go scanVerbose( msg, cancel, stdoutDone, "("+a.name+":1)", - io.TeeReader(stdout, bw), + io.TeeReader(brStdout, status), ) go scanVerbose( msg, cancel, stderrDone, "("+a.name+":2)", - io.TeeReader(stderr, bw), + io.TeeReader(brStderr, status), ) defer func() { <-stdoutDone <-stderrDone - - flushErr := bw.Flush() - if err == nil { - err = flushErr - } - f.cache.putWriter(bw) - + f.cache.putReader(brStdout) + f.cache.putReader(brStderr) }() } else { z.Stdout, z.Stderr = status, status