internal/rosa/make: split build and check

Doing these together breaks far too many buggy makefiles.

Signed-off-by: Ophestra <cat@gensokyo.uk>

internal/rosa/git.go

@@ -1,8 +1,6 @@
 package rosa
 
-import (
-	"hakurei.app/internal/pkg"
-)
+import "hakurei.app/internal/pkg"
 
 func (t Toolchain) newGit() pkg.Artifact {
 	const (
@@ -21,20 +19,14 @@ func (t Toolchain) newGit() pkg.Artifact {
 		Writable: true,
 		InPlace:  true,
 
-		// test suite in subdirectory
-		SkipCheck: true,
-
-		Make: []string{"all"},
 		ScriptEarly: `
 cd /usr/src/git
 
 make configure
-`,
-		Script: `
 ln -s ../../system/bin/perl /usr/bin/ || true
 
 function disable_test {
-	local test=$1 pattern=$2
+	local test=$1 pattern=${2:-''}
 	if [ $# -eq 1 ]; then
 		rm "t/${test}.sh"
 	else
@@ -56,12 +48,12 @@ disable_test t9300-fast-import
 disable_test t0211-trace2-perf
 disable_test t1517-outside-repo
 disable_test t2200-add-update
-
-make \
-	-C t \
-	GIT_PROVE_OPTS="--jobs 32 --failures" \
-	prove
 `,
+		Check: []string{
+			"-C t",
+			`GIT_PROVE_OPTS="--jobs 32 --failures"`,
+			"prove",
+		},
 	},
 		t.Load(Perl),
 		t.Load(Diffutils),