cmd/hakurei/command: pd run dbus-verbose nil check
	
		
			
	
		
	
	
		
	
		
			All checks were successful
		
		
	
	
		
			
				
	
				Test / Create distribution (push) Successful in 26s
				
			
		
			
				
	
				Test / Sandbox (push) Successful in 40s
				
			
		
			
				
	
				Test / Sandbox (race detector) (push) Successful in 40s
				
			
		
			
				
	
				Test / Hakurei (race detector) (push) Successful in 43s
				
			
		
			
				
	
				Test / Hpkg (push) Successful in 41s
				
			
		
			
				
	
				Test / Hakurei (push) Successful in 2m23s
				
			
		
			
				
	
				Test / Flake checks (push) Successful in 1m33s
				
			
		
		
	
	
				
					
				
			
		
			All checks were successful
		
		
	
	Test / Create distribution (push) Successful in 26s
				
			Test / Sandbox (push) Successful in 40s
				
			Test / Sandbox (race detector) (push) Successful in 40s
				
			Test / Hakurei (race detector) (push) Successful in 43s
				
			Test / Hpkg (push) Successful in 41s
				
			Test / Hakurei (push) Successful in 2m23s
				
			Test / Flake checks (push) Successful in 1m33s
				
			This otherwise dereferences a nil pointer when dbus-verbose is set and either session or system bus are nil. Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
		
							parent
							
								
									acb6931f3e
								
							
						
					
					
						commit
						92f510a647
					
				| @ -162,8 +162,12 @@ func buildCommand(out io.Writer) command.Command { | |||||||
| 
 | 
 | ||||||
| 				// override log from configuration | 				// override log from configuration | ||||||
| 				if dbusVerbose { | 				if dbusVerbose { | ||||||
| 					config.SessionBus.Log = true | 					if config.SessionBus != nil { | ||||||
| 					config.SystemBus.Log = true | 						config.SessionBus.Log = true | ||||||
|  | 					} | ||||||
|  | 					if config.SystemBus != nil { | ||||||
|  | 						config.SystemBus.Log = true | ||||||
|  | 					} | ||||||
| 				} | 				} | ||||||
| 			} | 			} | ||||||
| 
 | 
 | ||||||
|  | |||||||
| @ -149,7 +149,7 @@ silent_output_interrupt("--wayland -X --dbus --pulse ") | |||||||
| print(machine.fail("sudo -u alice -i hakurei -v run --wayland true")) | print(machine.fail("sudo -u alice -i hakurei -v run --wayland true")) | ||||||
| 
 | 
 | ||||||
| # Start hakurei permissive defaults within Wayland session: | # Start hakurei permissive defaults within Wayland session: | ||||||
| hakurei('-v run --wayland --dbus notify-send -a "NixOS Tests" "Test notification" "Notification from within sandbox." && touch /tmp/dbus-ok') | hakurei('-v run --wayland --dbus --dbus-log notify-send -a "NixOS Tests" "Test notification" "Notification from within sandbox." && touch /tmp/dbus-ok') | ||||||
| machine.wait_for_file("/tmp/dbus-ok", timeout=15) | machine.wait_for_file("/tmp/dbus-ok", timeout=15) | ||||||
| collect_state_ui("dbus_notify_exited") | collect_state_ui("dbus_notify_exited") | ||||||
| # not in pid namespace, verify termination | # not in pid namespace, verify termination | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user