container/init: use absolute compare method

More checks are also added.

Signed-off-by: Ophestra <cat@gensokyo.uk>

container/autoroot.go

@@ -73,8 +73,7 @@ func (r *AutoRootOp) apply(state *setupState) error {
 func (r *AutoRootOp) Is(op Op) bool {
 	vr, ok := op.(*AutoRootOp)
 	return ok && ((r == nil && vr == nil) || (r != nil && vr != nil &&
-		r.Host != nil && vr.Host != nil &&
+		r.Host != nil && vr.Host != nil && r.Host.Is(vr.Host) &&
-		r.Host.String() == vr.Host.String() &&
 		r.Prefix == vr.Prefix && r.Flags == vr.Flags))
 }
 func (*AutoRootOp) prefix() string { return "setting up" }

container/autoroot_test.go

@@ -27,7 +27,7 @@ func TestAutoRootOp(t *testing.T) {
 			resolved: []Op{new(BindMountOp)},
 		}, true},
 
-		{"differs", &AutoRootOp{
+		{"prefix differs", &AutoRootOp{
 			Host:   MustAbs("/"),
 			Prefix: "\x00",
 			Flags:  BindWritable,
@@ -37,6 +37,26 @@ func TestAutoRootOp(t *testing.T) {
 			Flags:  BindWritable,
 		}, false},
 
+		{"flags differs", &AutoRootOp{
+			Host:   MustAbs("/"),
+			Prefix: ":3",
+			Flags:  BindWritable | BindDevice,
+		}, &AutoRootOp{
+			Host:   MustAbs("/"),
+			Prefix: ":3",
+			Flags:  BindWritable,
+		}, false},
+
+		{"host differs", &AutoRootOp{
+			Host:   MustAbs("/tmp/"),
+			Prefix: ":3",
+			Flags:  BindWritable,
+		}, &AutoRootOp{
+			Host:   MustAbs("/"),
+			Prefix: ":3",
+			Flags:  BindWritable,
+		}, false},
+
 		{"equals", &AutoRootOp{
 			Host:   MustAbs("/"),
 			Prefix: ":3",

container/initbind.go

@@ -88,10 +88,8 @@ func (b *BindMountOp) apply(*setupState) error {
 func (b *BindMountOp) Is(op Op) bool {
 	vb, ok := op.(*BindMountOp)
 	return ok && ((b == nil && vb == nil) || (b != nil && vb != nil &&
-		b.Source != nil && vb.Source != nil &&
+		b.Source != nil && vb.Source != nil && b.Source.Is(vb.Source) &&
-		b.Source.String() == vb.Source.String() &&
+		b.Target != nil && vb.Target != nil && b.Target.Is(vb.Target) &&
-		b.Target != nil && vb.Target != nil &&
-		b.Target.String() == vb.Target.String() &&
 		b.Flags == vb.Flags))
 }
 func (*BindMountOp) prefix() string { return "mounting" }

container/initbind_test.go

@@ -28,7 +28,7 @@ func TestBindMountOp(t *testing.T) {
 			sourceFinal: MustAbs("/etc/"),
 		}, true},
 
-		{"differs", &BindMountOp{
+		{"flags differs", &BindMountOp{
 			Source: MustAbs("/etc/"),
 			Target: MustAbs("/etc/.host/048090b6ed8f9ebb10e275ff5d8c0659"),
 		}, &BindMountOp{
@@ -37,6 +37,22 @@ func TestBindMountOp(t *testing.T) {
 			Flags:  BindOptional,
 		}, false},
 
+		{"source differs", &BindMountOp{
+			Source: MustAbs("/.hakurei/etc/"),
+			Target: MustAbs("/etc/.host/048090b6ed8f9ebb10e275ff5d8c0659"),
+		}, &BindMountOp{
+			Source: MustAbs("/etc/"),
+			Target: MustAbs("/etc/.host/048090b6ed8f9ebb10e275ff5d8c0659"),
+		}, false},
+
+		{"target differs", &BindMountOp{
+			Source: MustAbs("/etc/"),
+			Target: MustAbs("/etc/.host/048090b6ed8f9ebb10e275ff5d8c0659"),
+		}, &BindMountOp{
+			Source: MustAbs("/etc/"),
+			Target: MustAbs("/etc/"),
+		}, false},
+
 		{"equals", &BindMountOp{
 			Source: MustAbs("/etc/"),
 			Target: MustAbs("/etc/.host/048090b6ed8f9ebb10e275ff5d8c0659"),

container/initdev.go

@@ -129,8 +129,7 @@ func (d *MountDevOp) apply(state *setupState) error {
 func (d *MountDevOp) Is(op Op) bool {
 	vd, ok := op.(*MountDevOp)
 	return ok && ((d == nil && vd == nil) || (d != nil && vd != nil &&
-		d.Target != nil && vd.Target != nil &&
+		d.Target != nil && vd.Target != nil && d.Target.Is(vd.Target) &&
-		d.Target.String() == vd.Target.String() &&
 		d.Mqueue == vd.Mqueue && d.Write == vd.Write))
 }
 func (*MountDevOp) prefix() string { return "mounting" }

container/initdev_test.go

@@ -22,15 +22,7 @@ func TestMountDevOp(t *testing.T) {
 	checkOpIs(t, []opIsTestCase{
 		{"zero", new(MountDevOp), new(MountDevOp), false},
 
-		{"equals", &MountDevOp{
+		{"write differs", &MountDevOp{
-			Target: MustAbs("/dev/"),
-			Mqueue: true,
-		}, &MountDevOp{
-			Target: MustAbs("/dev/"),
-			Mqueue: true,
-		}, true},
-
-		{"differs", &MountDevOp{
 			Target: MustAbs("/dev/"),
 			Mqueue: true,
 		}, &MountDevOp{
@@ -39,13 +31,28 @@ func TestMountDevOp(t *testing.T) {
 			Write:  true,
 		}, false},
 
-		{"differs path", &MountDevOp{
+		{"mqueue differs", &MountDevOp{
+			Target: MustAbs("/dev/"),
+		}, &MountDevOp{
+			Target: MustAbs("/dev/"),
+			Mqueue: true,
+		}, false},
+
+		{"target differs", &MountDevOp{
 			Target: MustAbs("/"),
 			Mqueue: true,
 		}, &MountDevOp{
 			Target: MustAbs("/dev/"),
 			Mqueue: true,
 		}, false},
+
+		{"equals", &MountDevOp{
+			Target: MustAbs("/dev/"),
+			Mqueue: true,
+		}, &MountDevOp{
+			Target: MustAbs("/dev/"),
+			Mqueue: true,
+		}, true},
 	})
 
 	checkOpMeta(t, []opMetaTestCase{

container/initmkdir.go

@@ -32,8 +32,7 @@ func (m *MkdirOp) apply(*setupState) error {
 func (m *MkdirOp) Is(op Op) bool {
 	vm, ok := op.(*MkdirOp)
 	return ok && ((m == nil && vm == nil) || (m != nil && vm != nil &&
-		m.Path != nil && vm.Path != nil &&
+		m.Path != nil && vm.Path != nil && m.Path.Is(vm.Path) &&
-		m.Path.String() == vm.Path.String() &&
 		m.Perm == vm.Perm))
 }
 func (*MkdirOp) prefix() string   { return "creating" }

container/initmkdir_test.go

@@ -11,7 +11,8 @@ func TestMkdirOp(t *testing.T) {
 
 	checkOpIs(t, []opIsTestCase{
 		{"zero", new(MkdirOp), new(MkdirOp), false},
-		{"differs", &MkdirOp{Path: MustAbs("/"), Perm: 0755}, &MkdirOp{Path: MustAbs("/etc/"), Perm: 0755}, false},
+		{"path differs", &MkdirOp{Path: MustAbs("/"), Perm: 0755}, &MkdirOp{Path: MustAbs("/etc/"), Perm: 0755}, false},
+		{"perm differs", &MkdirOp{Path: MustAbs("/")}, &MkdirOp{Path: MustAbs("/"), Perm: 0755}, false},
 		{"equals", &MkdirOp{Path: MustAbs("/")}, &MkdirOp{Path: MustAbs("/")}, true},
 	})