security/hakurei
security/hakurei
6
3
Fork 0
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

internal/wayland: do not double close fd
All checks were successful
Test / Create distribution (push) Successful in 35s
Details
Test / Sandbox (push) Successful in 2m15s
Details
Test / Hakurei (push) Successful in 3m16s
Details
Test / Hpkg (push) Successful in 4m7s
Details
Test / Sandbox (race detector) (push) Successful in 4m14s
Details
Test / Hakurei (race detector) (push) Successful in 5m5s
Details
Test / Flake checks (push) Successful in 1m29s
Details

Browse Source 
These are already closed during securityContextBindPipe on a non-nil error.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra 2025-11-17 22:00:57 +09:00
parent 3afca2bd5b
commit a495e09a8f
Signed by: cat
SSH Key Fingerprint: SHA256:gQ67O0enBZ7UdZypgtspB2FDM1g3GVw8nX0XSdcFw8Q
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/wayland/conn.go
View File

@ -51,10 +51,8 @@ func New(displayPath, bindPath *check.Absolute, appID, instanceID string) (*Secu
} else { } else {
closeFds, bindErr := securityContextBindPipe(fd, bindPath, appID, instanceID) closeFds, bindErr := securityContextBindPipe(fd, bindPath, appID, instanceID)
if bindErr != nil { if bindErr != nil {
// do not leak the pipe and socket
err = errors.Join(bindErr, // already wrapped err = errors.Join(bindErr, // already wrapped
syscall.Close(closeFds[1]), // do not leak the socket
syscall.Close(closeFds[0]),
syscall.Close(fd), syscall.Close(fd),
) )
} }