internal/rosa/make: migrate to helper interface

This also updates all affected artifacts to use new behaviour.

Signed-off-by: Ophestra <cat@gensokyo.uk>

internal/rosa/acl.go

@@ -7,13 +7,14 @@ func (t Toolchain) newAttr() pkg.Artifact {
 		version  = "2.5.2"
 		checksum = "YWEphrz6vg1sUMmHHVr1CRo53pFXRhq_pjN-AlG8UgwZK1y6m7zuDhxqJhD0SV0l"
 	)
-	return t.NewViaMake("attr", version, t.NewPatchedSource(
-		"attr", version, pkg.NewHTTPGetTar(
-			nil, "https://download.savannah.nongnu.org/releases/attr/"+
-				"attr-"+version+".tar.gz",
-			mustDecode(checksum),
-			pkg.TarGzip,
-		), true, [2]string{"libgen-basename", `From 8a80d895dfd779373363c3a4b62ecce5a549efb2 Mon Sep 17 00:00:00 2001
+	return t.NewPackage("attr", version, pkg.NewHTTPGetTar(
+		nil, "https://download.savannah.nongnu.org/releases/attr/"+
+			"attr-"+version+".tar.gz",
+		mustDecode(checksum),
+		pkg.TarGzip,
+	), &PackageAttr{
+		Patches: [][2]string{
+			{"libgen-basename", `From 8a80d895dfd779373363c3a4b62ecce5a549efb2 Mon Sep 17 00:00:00 2001
 From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>
 Date: Sat, 30 Mar 2024 10:17:10 +0100
 Subject: tools/attr.c: Add missing libgen.h include for basename(3)
@@ -38,7 +39,9 @@ index f12e4af..6a3c1e9 100644
  #include <attr/attributes.h>
  
 -- 
-cgit v1.1`}, [2]string{"musl-errno", `diff --git a/test/attr.test b/test/attr.test
+cgit v1.1`},
+
+			{"musl-errno", `diff --git a/test/attr.test b/test/attr.test
 index 6ce2f9b..e9bde92 100644
 --- a/test/attr.test
 +++ b/test/attr.test
@@ -52,15 +55,13 @@ index 6ce2f9b..e9bde92 100644
  	$ setfattr -n user. -v value f
  	> setfattr: f: Invalid argument
 `},
-	), &MakeAttr{
+		},
+
 		ScriptEarly: `
 ln -s ../../system/bin/perl /usr/bin
 `,
-		Configure: [][2]string{
-			{"enable-static"},
-		},
-	},
-		t.Load(Perl),
+	}, (*MakeHelper)(nil),
+		Perl,
 	)
 }
 func init() { artifactsF[Attr] = Toolchain.newAttr }
@@ -70,21 +71,16 @@ func (t Toolchain) newACL() pkg.Artifact {
 		version  = "2.3.2"
 		checksum = "-fY5nwH4K8ZHBCRXrzLdguPkqjKI6WIiGu4dBtrZ1o0t6AIU73w8wwJz_UyjIS0P"
 	)
-	return t.NewViaMake("acl", version, pkg.NewHTTPGetTar(
-		nil,
-		"https://download.savannah.nongnu.org/releases/acl/"+
+	return t.NewPackage("acl", version, pkg.NewHTTPGetTar(
+		nil, "https://download.savannah.nongnu.org/releases/acl/"+
 			"acl-"+version+".tar.gz",
 		mustDecode(checksum),
 		pkg.TarGzip,
-	), &MakeAttr{
-		Configure: [][2]string{
-			{"enable-static"},
-		},
-
+	), nil, &MakeHelper{
 		// makes assumptions about uid_map/gid_map
 		SkipCheck: true,
 	},
-		t.Load(Attr),
+		Attr,
 	)
 }
 func init() { artifactsF[ACL] = Toolchain.newACL }