internal/rosa/make: migrate to helper interface

This also updates all affected artifacts to use new behaviour.

Signed-off-by: Ophestra <cat@gensokyo.uk>

internal/rosa/pcre2.go

@@ -9,17 +9,17 @@ func (t Toolchain) newPCRE2() pkg.Artifact {
 		version  = "10.43"
 		checksum = "iyNw-POPSJwiZVJfUK5qACA6q2uMzP-84WieimN_CskaEkuw5fRnRTZhEv6ry2Yo"
 	)
-	return t.NewViaMake("pcre2", version, pkg.NewHTTPGetTar(
+	return t.NewPackage("pcre2", version, pkg.NewHTTPGetTar(
 		nil, "https://github.com/PCRE2Project/pcre2/releases/download/"+
 			"pcre2-"+version+"/pcre2-"+version+".tar.bz2",
 		mustDecode(checksum),
 		pkg.TarBzip2,
-	), &MakeAttr{
+	), &PackageAttr{
 		ScriptEarly: `
 # RunGrepTest expects /bin/echo
 ln -s ../system/bin/toybox /bin/echo
 `,
-
+	}, &MakeHelper{
 		Configure: [][2]string{
 			{"enable-jit"},
 			{"enable-pcre2-8"},
@@ -27,7 +27,7 @@ ln -s ../system/bin/toybox /bin/echo
 			{"enable-pcre2-32"},
 		},
 	},
-		t.Load(Diffutils),
+		Diffutils,
 	)
 }
 func init() { artifactsF[PCRE2] = Toolchain.newPCRE2 }