security/hakurei
6
3
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 11 Wiki Activity

system: unexport Op implementations
All checks were successful
Test / Create distribution (push) Successful in 52s
Details
Test / Sandbox (push) Successful in 3m30s
Details
Test / Hakurei (push) Successful in 5m40s
Details
Test / Sandbox (race detector) (push) Successful in 6m30s
Details
Test / Hpkg (push) Successful in 7m21s
Details
Test / Hakurei (race detector) (push) Successful in 3m22s
Details
Test / Flake checks (push) Successful in 2m2s
Details

Browse Source 
None of these are valid with their zero value, and the implementations assume they are created by the builder methods. They are by all means an implementation detail and exporting them makes no sense.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra
2025-09-06 16:16:03 +09:00
parent ac81cfbedc
commit e68db7fbfc
12 changed files with 157 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
system/xhost.go
View File

@@ -4,24 +4,24 @@ import (
"hakurei.app/system/internal/xcb"
)
// ChangeHosts appends [XHostOp] to [I].
// ChangeHosts inserts the target user into X11 hosts and deletes it once its [Enablement] is no longer satisfied.
func (sys *I) ChangeHosts(username string) *I {
sys.ops = append(sys.ops, XHostOp(username))
sys.ops = append(sys.ops, xhostOp(username))
return sys
}
// XHostOp inserts the target user into X11 hosts and deletes it once its [Enablement] is no longer satisfied.
type XHostOp string
// xhostOp implements [I.ChangeHosts].
type xhostOp string
func (x XHostOp) Type() Enablement { return EX11 }
func (x xhostOp) Type() Enablement { return EX11 }
func (x XHostOp) apply(*I) error {
func (x xhostOp) apply(*I) error {
msg.Verbosef("inserting entry %s to X11", x)
return newOpError("xhost",
xcb.ChangeHosts(xcb.HostModeInsert, xcb.FamilyServerInterpreted, "localuser\x00"+string(x)), false)
}
func (x XHostOp) revert(_ *I, ec *Criteria) error {
func (x xhostOp) revert(_ *I, ec *Criteria) error {
if ec.hasType(x.Type()) {
msg.Verbosef("deleting entry %s from X11", x)
return newOpError("xhost",
@@ -32,6 +32,6 @@ func (x XHostOp) revert(_ *I, ec *Criteria) error {
}
}
func (x XHostOp) Is(o Op) bool { target, ok := o.(XHostOp); return ok && x == target }
func (x XHostOp) Path() string { return string(x) }
func (x XHostOp) String() string { return string("SI:localuser:" + x) }
func (x xhostOp) Is(o Op) bool { target, ok := o.(xhostOp); return ok && x == target }
func (x xhostOp) Path() string { return string(x) }
func (x xhostOp) String() string { return string("SI:localuser:" + x) }