31 Commits

Author	SHA1	Message	Date
Ophestra	b9b9705b52	internal/pipewire: specify opcode and file count with message ... This adds checking of FileCount while writing a message. Message encoding is relocated to an exported method to be used externally, probably for test stubbing. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-07 13:54:11 +09:00
Ophestra	0d3ae6cb23	internal/pipewire: improve protocol error messages ... These are mostly small formatting changes, with the biggest change being to UnexpectedEOFError where its kind is now described as part of the error type. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-04 03:15:58 +09:00
Ophestra	69b1131d66	internal/pipewire: use type name in error strings ... This provides more useful messages for protocol errors. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-04 02:29:27 +09:00
Ophestra	2c0b92771a	internal/pipewire: relocate constants ... This should make things easier to navigate, and possible to fully automatically generate the constants in the future. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-03 03:52:17 +09:00
Ophestra	7bc73afadd	internal/pipewire: wrap EOF error for deserialisation ... The io.ErrUnexpectedEOF error can be returned from multiple places. This change eases error handling. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-02 03:19:37 +09:00
Ophestra	647aa9d02f	internal/pipewire: preallocate for footer ... This is useful during serialisation. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-12-02 03:06:27 +09:00
Ophestra	de3fc7ba38	internal/pipewire: implement SecurityContext::Create ... This is finally the thing we are after. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-29 16:46:39 +09:00
Ophestra	5a5c4705dd	internal/pipewire: implement Registry::Bind ... This change also adds test cases for messages before this one. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-29 03:01:53 +09:00
Ophestra	cbe86dc4f0	internal/pipewire: add json struct tags ... These match the names found in documentation. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-28 01:33:32 +09:00
Ophestra	d08a1081bd	internal/pipewire: do not store spa_dict fields ... This is effectively a poor man's slice, it is entirely unnecessary here and can be handled internally. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-28 01:25:18 +09:00
Ophestra	91efeb101a	internal/pipewire: spa_dict size nil check ... This fixes serialisation of NULL spa_dict. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:51:36 +09:00
Ophestra	dcb22a61c0	internal/pipewire: require appending marshaler ... This eliminates all non-reflect allocations. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:33:19 +09:00
Ophestra	e028a61fc1	internal/pipewire: preallocate for known size ... This is still not efficient by any means, but it should eliminate most non-reflect allocation (all allocation if PODMarshaler is not used). Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:26:31 +09:00
Ophestra	73987be7d4	internal/pipewire: size without serialisation ... This is required to achieve zero allocation (other than reflect). Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:17:38 +09:00
Ophestra	563b5e66fc	internal/pipewire: simplify spa_dict appends ... This change uses the (somewhat) newly exposed MarshalAppend which improves readability. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 01:52:13 +09:00
Ophestra	2edcfe1e68	internal/pipewire: define size constants ... This gets rid of magic numbers in marshal/unmarshal. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 00:54:56 +09:00
Ophestra	1d0143386d	internal/pipewire: optional final trailing garbage check ... Omitting the check is only useful for custom unmarshaler. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 18:50:39 +09:00
Ophestra	14e33f17e5	internal/pipewire: check nil marshaler ... NULL values have special case in the format. This check ensures correctness serialising nil pointers. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 18:36:08 +09:00
Ophestra	05391da556	internal/pipewire: implement footer ... The POD itself is serialised without requiring a special case, however its presence is only indicated by the difference in size recorded in the header and payload. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:11:22 +09:00
Ophestra	463f8836e6	internal/pipewire: implement Long type ... Thankfully no special case here. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:05:37 +09:00
Ophestra	2e465c94da	internal/pipewire: implement Id type ... This is, in fact, just a glorified Int type. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:01:58 +09:00
Ophestra	26009fd3f7	internal/pipewire: slice at POD boundary ... This prevents incorrectly reading trailing data as part of the current POD. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 14:58:56 +09:00
Ophestra	2d7b896a8c	internal/pipewire: bounds check against wire size ... This covers cases where wire size is not known ahead of time. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 13:42:31 +09:00
Ophestra	a0eb010aab	internal/pipewire: spa_dict trailing garbage within POD ... This performs the check within the bounds of the POD only. This was not caught since spa_dict was only used as the final struct field until now. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 13:39:02 +09:00
Ophestra	b1b27ac1df	internal/pipewire: zero size before validation ... Leftover values from previous invocations cause incorrect behaviour here. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 12:21:37 +09:00
Ophestra	e51e81bb22	internal/pipewire: implement spa_dict type ... This is a terrible type that defies the type system. It is implemented on the concrete type to avoid special cases. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:08:52 +09:00
Ophestra	8f4a3bcf9f	internal/pipewire: use custom marshaler when available ... This reduces special cases. This change also exposes unmarshalled message size on the wire. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:05:22 +09:00
Ophestra	827dc9e1ba	internal/pipewire: implement string type ... This is still NUL terminated strings, and an extra NUL character on an 8-byte string does cause an extra 7 bytes of padding. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:00:59 +09:00
Ophestra	d92de1c709	internal/pipewire: check for trailing garbage ... This is useful during development. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 01:59:29 +09:00
Ophestra	5bcafcf734	internal/pipewire: implement Core::Hello ... This implements enough types to correctly marshal and unmarshal Core::Hello. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 01:20:30 +09:00
Ophestra	9f7b0c2f46	internal/pipewire: add type constants ... This change also centralises encoding testing. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-24 22:00:09 +09:00