487 Commits

Author	SHA1	Message	Date
Ophestra	72a2601d74	internal/pipewire: store sample iovec continuously ... This removes the need for manual splitting. The understanding of the format is robust enough to allow this to happen anyway. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-28 00:35:10 +09:00
Ophestra	1dab87aaf0	internal/pipewire: add missing constants ... These did not appear useful at first since it was assumed to be filenames for loading modules. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 21:28:16 +09:00
Ophestra	2bafde99e3	internal/pipewire: shorten test data filenames ... These were getting very annoying to type. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 20:06:01 +09:00
Ophestra	91efeb101a	internal/pipewire: spa_dict size nil check ... This fixes serialisation of NULL spa_dict. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:51:36 +09:00
Ophestra	dcb22a61c0	internal/pipewire: require appending marshaler ... This eliminates all non-reflect allocations. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:33:19 +09:00
Ophestra	e028a61fc1	internal/pipewire: preallocate for known size ... This is still not efficient by any means, but it should eliminate most non-reflect allocation (all allocation if PODMarshaler is not used). Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:26:31 +09:00
Ophestra	73987be7d4	internal/pipewire: size without serialisation ... This is required to achieve zero allocation (other than reflect). Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 02:17:38 +09:00
Ophestra	563b5e66fc	internal/pipewire: simplify spa_dict appends ... This change uses the (somewhat) newly exposed MarshalAppend which improves readability. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 01:52:13 +09:00
Ophestra	2edcfe1e68	internal/pipewire: define size constants ... This gets rid of magic numbers in marshal/unmarshal. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-27 00:54:56 +09:00
Ophestra	2698ca00e8	internal/pipewire: implement Core::Done ... The message in the sample does not correspond to any known method call. The spec does not mention what to do with messages like this, but all existing usage code simply drops it. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 19:02:21 +09:00
Ophestra	1d0143386d	internal/pipewire: optional final trailing garbage check ... Omitting the check is only useful for custom unmarshaler. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 18:50:39 +09:00
Ophestra	a55c209099	internal/pipewire: additional Client::Info test case ... This appears to add *one single entry* compared to the message before it. The inefficiency of this protocol is beyond imagination. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 16:28:57 +09:00
Ophestra	10ff276da1	internal/pipewire: additional Client::Info test case ... This message follows the other Client::Info event before it. No idea why. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 16:17:38 +09:00
Ophestra	fd4d379b67	internal/pipewire: implement Client::Info ... Everything is already supported, as usual. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-26 16:05:46 +09:00
Ophestra	77f5b89a41	internal/pipewire: implement Core::BoundProps ... Very straightforward type, everything is already supported. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 18:40:19 +09:00
Ophestra	14e33f17e5	internal/pipewire: check nil marshaler ... NULL values have special case in the format. This check ensures correctness serialising nil pointers. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 18:36:08 +09:00
Ophestra	cfeb7818eb	internal/pipewire: implement Core::Info and generation footer ... These are not directly related but are first encountered on the same message in the capture. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:16:12 +09:00
Ophestra	05391da556	internal/pipewire: implement footer ... The POD itself is serialised without requiring a special case, however its presence is only indicated by the difference in size recorded in the header and payload. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:11:22 +09:00
Ophestra	463f8836e6	internal/pipewire: implement Long type ... Thankfully no special case here. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:05:37 +09:00
Ophestra	2e465c94da	internal/pipewire: implement Id type ... This is, in fact, just a glorified Int type. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 15:01:58 +09:00
Ophestra	26009fd3f7	internal/pipewire: slice at POD boundary ... This prevents incorrectly reading trailing data as part of the current POD. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 14:58:56 +09:00
Ophestra	2d7b896a8c	internal/pipewire: bounds check against wire size ... This covers cases where wire size is not known ahead of time. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 13:42:31 +09:00
Ophestra	a0eb010aab	internal/pipewire: spa_dict trailing garbage within POD ... This performs the check within the bounds of the POD only. This was not caught since spa_dict was only used as the final struct field until now. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 13:39:02 +09:00
Ophestra	b1b27ac1df	internal/pipewire: zero size before validation ... Leftover values from previous invocations cause incorrect behaviour here. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 12:21:37 +09:00
Ophestra	fc3d78fe01	internal/pipewire: implement Core::Sync ... Once again, already entirely supported, the offset is not yet fully verified but makes intuitive sense. Will verify this on future occurrences of the message. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 08:52:06 +09:00
Ophestra	591637264a	internal/pipewire: implement Core::GetRegistry ... This struct is entirely supported, so this change is very straightforward. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 08:34:19 +09:00
Ophestra	e77652bf89	internal/pipewire: move test data to files ... These get very big later on, and would be painful to represent as the compound literal. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 08:09:10 +09:00
Ophestra	88d3e46413	internal/pipewire: implement Client::UpdateProperties ... This is the second message on the captured sample. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:16:11 +09:00
Ophestra	e51e81bb22	internal/pipewire: implement spa_dict type ... This is a terrible type that defies the type system. It is implemented on the concrete type to avoid special cases. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:08:52 +09:00
Ophestra	8f4a3bcf9f	internal/pipewire: use custom marshaler when available ... This reduces special cases. This change also exposes unmarshalled message size on the wire. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:05:22 +09:00
Ophestra	827dc9e1ba	internal/pipewire: implement string type ... This is still NUL terminated strings, and an extra NUL character on an 8-byte string does cause an extra 7 bytes of padding. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 04:00:59 +09:00
Ophestra	d92de1c709	internal/pipewire: check for trailing garbage ... This is useful during development. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 01:59:29 +09:00
Ophestra	5bcafcf734	internal/pipewire: implement Core::Hello ... This implements enough types to correctly marshal and unmarshal Core::Hello. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-25 01:20:30 +09:00
Ophestra	9f7b0c2f46	internal/pipewire: add type constants ... This change also centralises encoding testing. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-24 22:00:09 +09:00
Ophestra	3e87187c4c	internal/pipewire: implement message header ... Test cases are from interactions between pw-container and PipeWire. Results are validated against corresponding body. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-23 16:20:35 +09:00
Ophestra	aab92ce3c1	internal/wayland: clean up pathname socket ... This is cleaner than cleaning up in internal/system as it covers the failure paths. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-19 06:37:04 +09:00
Ophestra	a495e09a8f	internal/wayland: do not double close fd ... These are already closed during securityContextBindPipe on a non-nil error. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-17 22:03:29 +09:00
Ophestra	3afca2bd5b	internal/wayland: expose WAYLAND_VERSION ... This might be useful troubleshooting information. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-17 01:46:01 +09:00
Ophestra	b73a789dfe	.clang-format: increase indent width ... This significantly increases readability. This patch is pretty big so it is being done after mostly everything has settled. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-16 20:57:29 +09:00
Ophestra	38b5ff0cec	internal/wayland: check pathname size ... This avoids passing a truncated pathname to the kernel. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-16 03:34:05 +09:00
Ophestra	3c204b9b40	internal/wayland: increase error detail ... This includes targeted paths in the returned errors. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-16 02:09:50 +09:00
Ophestra	00771efeb4	internal/wayland: remove fd typecasts ... These are no longer necessary since RawConn is no longer used. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-16 01:45:37 +09:00
Ophestra	61972d61f6	internal/wayland: reimplement connect/bind code ... The old implementation is relocated to system/wayland/deprecated.go. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-16 01:23:16 +09:00
Ophestra	fe40af7b7e	internal/wayland: relocate connection struct ... This interface is getting replaced, so relocating it to the deprecated wrapper package before working on its replacement. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-15 23:25:46 +09:00
Ophestra	12751932d1	internal/wayland: improve error handling ... Note: wl_registry_add_listener is undocumented everywhere. Its implementation calls wl_proxy_add_listener which returns 0 on success or -1 on failure. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-15 21:26:31 +09:00
Ophestra	41b49137a8	.clang-format: do not limit line length ... This hard limit destroys readability in some places. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-15 17:06:43 +09:00
Ophestra	c761e1de4d	nix: build with clang ... Clang is better than gcc in various ways. This also pulls in clang-format which is very helpful. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-15 16:36:36 +09:00
Ophestra	a91920310d	internal: relocate packages ... Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-15 13:58:34 +09:00
Ophestra	47244daefb	treewide: migrate ldd callers ... This discontinues use of the deprecated ldd.Exec function for #25. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-14 21:59:59 +09:00
Ophestra	a9d72a5eb1	internal/outcome: rename run from main ... The "main.go" name is quite confusing as this is often only present in main packages. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-14 01:06:14 +09:00