37 Commits

Author	SHA1	Message	Date
Ophestra	0fd357e7f6	container/init: do not suspend output ... Init is not very talkative after process start even when verbose. Suspending output here is pointless and does more harm than good. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 08:11:00 +09:00
Ophestra	57231d4acf	container/init: improve signal handling ... The SIGTERM signal is delivered in many other cases and can lead to strange behaviour. The unconditional resume of the logger also causes strange behaviour in the cancellation forwarding path. This change also passes through additional signals. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 08:02:03 +09:00
Ophestra	622f945c22	container/init: check msg in entrypoint ... This covers invalid call to Init. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 04:20:08 +09:00
Ophestra	ae65491223	container/init: use one channel for wait4 ... When using two channels it is possible for the other case to be reached before all pending winfo are consumed, causing incorrect reporting. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-15 21:35:19 +09:00
Ophestra	a941ac025f	container/init: unwrap descriptive fatal error ... These errors are printed with a descriptive message prefixed to them, so it is more readable to expose the underlying errno. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-09 22:04:35 +09:00
Ophestra	87b5c30ef6	message: relocate from container ... This package is quite useful. This change allows it to be imported without importing container. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-09 05:18:19 +09:00
Ophestra	5d18af0007	container/fhs: move pathname constants ... This allows referencing FHS pathnames without importing container. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-07 21:29:16 +09:00
Ophestra	46cd3a28c8	container: remove global msg ... This frees all container instances of side effects. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-09-29 06:11:47 +09:00
Ophestra	e55822c62f	container/init: reduce verbose noise ... This makes it possible to optionally omit the identifying verbose message, for when the Op implementation can provide a much more useful message in its case, using information not yet available to the String method. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-09-28 21:51:10 +09:00
Ophestra	712cfc06d7	container: wrap container init start errors ... This helps indicate the exact origin and nature of the error. This eliminates generic WrapErr from container. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-30 23:44:48 +09:00
Ophestra	f24dd4ab8c	container/init: handle unwrapped errors ... This is much cleaner from both the return statement and the error handling. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-29 01:37:13 +09:00
Ophestra	a462341a0a	container: repeat and impossible state types ... This moves repeated Op errors and impossible internal state errors off of msg. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-29 01:12:02 +09:00
Ophestra	2baa2d7063	container/init: measure init behaviour ... This used to be entirely done via integration tests, with almost no hope of error injection and coverage profile. These tests significantly increase confidence of future work in this area. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-24 04:52:32 +09:00
Ophestra	0166833431	container/dispatcher: start goroutine in dispatcher ... This allows instrumentation of calls from goroutine without relying on finalizers. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-23 21:58:40 +09:00
Ophestra	b3da3da525	container/init: avoid multiple lastcap calls ... This reduces the size of []kexpect in the test suite. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-23 11:09:11 +09:00
Ophestra	1b3902df78	container/dispatcher: instrument each goroutine individually ... Scheduler nondeterminism cannot be accounted for, so do this instead. There should not be any performance penalty as these calls are optimised out for direct. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-23 11:07:16 +09:00
Ophestra	ea1e3ebae9	container/params: pass fd instead of file ... The file is very difficult to stub. Pass fd instead as it is the value that is actually useful. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-23 00:16:46 +09:00
Ophestra	1c692bfb79	container/init: call lockOSThread through dispatcher ... This degrades test performance if not stubbed out. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-22 22:24:14 +09:00
Ophestra	09d2844981	container/init: wrap syscall helper functions ... This allows tests to stub all kernel behaviour, enabling measurement of all function call arguments and error injection. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-22 19:27:31 +09:00
Ophestra	5d8a2199b6	container/init: op interface valid method ... Check ops early and eliminate duplicate checks. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-21 00:18:50 +09:00
Ophestra	339e4080dc	container/ops: move Op type to init file ... This helps with the eventual separation of all setup ops into individual files. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-20 01:11:24 +09:00
Ophestra	13c7083bc0	container: ptrace protection via Yama LSM ... This is only a nice to have feature as the init process has no additional privileges and the monitor process was never reachable anyway. Closes #4. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-20 00:43:55 +09:00
Ophestra	69a4ab8105	container: move PR_SET_NO_NEW_PRIVS to parent ... This allows some LSM setup in the parent. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-18 11:46:02 +09:00
Ophestra	8aa65f28c6	container: allow additional state between ops ... This is useful for ops that need to be aware of previous instances of themselves. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-17 01:32:07 +09:00
Ophestra	e99d7affb0	container: use absolute for pathname ... This is simultaneously more efficient and less error-prone. This change caused minor API changes in multiple other packages. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-11 04:56:42 +09:00
Ophestra	82608164f6	container/params: remove confusingly named error ... Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-09 17:37:46 +09:00
Ophestra	9a25542c6d	container/init: use mount string constants ... These literals were missed when the constants were first defined. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-04 04:00:05 +09:00
Ophestra	c6be82bcf9	container/path: fhs path constants ... This increases readability since this can help disambiguate absolute paths from similarly named path segments. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-03 21:16:45 +09:00
Ophestra	4e85643865	container: implement autoroot as setup op ... This code is useful beyond just pd behaviour, and implementing it this way also reduces IPC overhead. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-08-01 04:04:36 +09:00
Ophestra	940ee00ffe	container/init: configurable lingering process wait delay ... Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-29 02:38:17 +09:00
Ophestra	d6b07f12ff	container: forward context cancellation ... This allows container processes to exit gracefully. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-28 01:45:38 +09:00
Ophestra	65fe09caf9	container: check cancel signal delivery ... This change also makes some parts of the test more robust. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-28 01:04:29 +09:00
Ophestra	bd3fa53a55	container: access test case by index in helper ... This is more elegant and allows for much easier extension of the tests. Mountinfo is still serialised however due to libPaths nondeterminism. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-26 18:59:19 +09:00
Ophestra	d5c7523726	container/init: fix prctl call ... This is a very silly typo. Luckily has no effect due to an upper layer doing PR_SET_NO_NEW_PRIVS already. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-07 14:06:14 +09:00
Ophestra	356b42a406	container/init: use /proc/self as intermediate ... Setting up via /tmp is okay, /proc/self/fd makes a lot more sense though for reasons described in the comment. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-06 02:14:35 +09:00
Ophestra	d2f9a9b83b	treewide: migrate to hakurei.app ... Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-03 03:30:39 +09:00
Ophestra	1b5ecd9eaf	container: move out of toplevel ... This allows slightly easier use of the vanity url. This also provides some disambiguation between low level containers and hakurei app containers. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-07-03 02:59:43 +09:00