monstersirenfetch/song_test.go
Yonah bb1164d081
song: enrich metadata from API
This should be the last of the API interactions we need.

Signed-off-by: Yonah <contrib@gensokyo.uk>
2025-09-18 04:10:38 +09:00

190 lines
5.1 KiB
Go

package monstersirenfetch_test
import (
"bytes"
"context"
_ "embed"
"errors"
"fmt"
"io"
"os"
"reflect"
"strconv"
"strings"
"testing"
. "git.gensokyo.uk/yonah/monstersirenfetch"
)
//go:embed testdata/song.json
var songJSON []byte
func TestSong(t *testing.T) {
checkJSONRoundTrip(t, SongResponse{Data: Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
SourceURL: "https://res01.hycdn.cn/04ce5de54bb52eb85008644d541d40fa/68CA0442/siren/audio/20240709/a7f650238eaefc9c30a9627d7f78d819.wav",
LyricURL: "https://web.hycdn.cn/siren/lyric/20240709/4a10c70629b68a187fdbef4a27bd32d8.lrc",
Artists: []string{"塞壬唱片-MSR"},
}}, songJSON)
}
func TestSongEnrich(t *testing.T) {
testCases := []struct {
name string
base Song
n Net
want Song
wantErr error
}{
{"get", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{}, Song{}, errors.New("song cid 48794 requested, but is not present")},
{"invalid response", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{
48794: []byte{0},
}, Song{}, errors.Join(newSyntaxError("invalid character '\\x00' looking for beginning of value", 1))},
{"close", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrichErrorCloser{
48794: songJSON,
}, Song{}, os.ErrInvalid},
{"inconsistent cid", Song{
CID: 0xdeadbeef,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{
0xdeadbeef: songJSON,
}, Song{}, &InconsistentSongError[StringInt]{
Field: "cid",
Value: 0xdeadbeef,
NewValue: 48794,
}},
{"inconsistent name", Song{
CID: 48794,
Name: "Warm and Small Light\x00",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{
48794: songJSON,
}, Song{}, &InconsistentSongError[string]{
Field: "name",
Value: "Warm and Small Light\x00",
NewValue: "Warm and Small Light",
}},
{"inconsistent albumCid", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: -1,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{
48794: songJSON,
}, Song{}, &InconsistentSongError[StringInt]{
Field: "albumCid",
Value: -1,
NewValue: 6660,
}},
{"inconsistent artists", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR", "\x00"},
}, stubNetSongEnrich{
48794: songJSON,
}, Song{}, &InconsistentSongError[[]string]{
Field: "artists",
Value: []string{"塞壬唱片-MSR", "\x00"},
NewValue: []string{"塞壬唱片-MSR"},
}},
{"valid", Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
Artists: []string{"塞壬唱片-MSR"},
}, stubNetSongEnrich{
48794: songJSON,
}, Song{
CID: 48794,
Name: "Warm and Small Light",
AlbumCID: 6660,
SourceURL: "https://res01.hycdn.cn/04ce5de54bb52eb85008644d541d40fa/68CA0442/siren/audio/20240709/a7f650238eaefc9c30a9627d7f78d819.wav",
LyricURL: "https://web.hycdn.cn/siren/lyric/20240709/4a10c70629b68a187fdbef4a27bd32d8.lrc",
MvURL: "", MvCoverURL: "",
Artists: []string{"塞壬唱片-MSR"},
}, nil},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
s := new(Song)
*s = tc.base
if err := s.Enrich(t.Context(), tc.n); !reflect.DeepEqual(err, tc.wantErr) {
t.Errorf("Enrich: error = %v, want %v", err, tc.wantErr)
}
if tc.wantErr == nil && !reflect.DeepEqual(s, &tc.want) {
t.Errorf("Enrich: %#v, want %#v", s, &tc.want)
}
})
}
t.Run("invalid", func(t *testing.T) {
t.Run("nil", func(t *testing.T) {
if err := (*Song)(nil).Enrich(t.Context(), nil); !errors.Is(err, os.ErrInvalid) {
t.Errorf("Enrich: error = %v", err)
}
})
t.Run("full", func(t *testing.T) {
if err := (&Song{SourceURL: "\x00"}).Enrich(t.Context(), nil); !errors.Is(err, os.ErrInvalid) {
t.Errorf("Enrich: error = %v", err)
}
})
})
t.Run("error", func(t *testing.T) {
const want = "field cid inconsistent: 48794 differs from 3735928559"
if got := (&InconsistentSongError[StringInt]{Field: "cid", Value: 48794, NewValue: 0xdeadbeef}).Error(); got != want {
t.Errorf("Error: %q, want %q", got, want)
}
})
}
type stubNetSongEnrichErrorCloser stubNetSongEnrich
func (n stubNetSongEnrichErrorCloser) Get(ctx context.Context, url string) (io.ReadCloser, error) {
r, err := stubNetSongEnrich(n).Get(ctx, url)
if r != nil {
r = errorCloser{r}
}
return r, err
}
type stubNetSongEnrich map[StringInt][]byte
func (n stubNetSongEnrich) Get(_ context.Context, url string) (io.ReadCloser, error) {
if i, err := strconv.Atoi(strings.TrimPrefix(url, APIPrefix+"/song/")); err != nil {
return nil, err
} else if b, ok := n[StringInt(i)]; !ok {
return nil, fmt.Errorf("song cid %d requested, but is not present", i)
} else {
return nopCloser{bytes.NewReader(b)}, nil
}
}