cmd/mbf: migrate shell to enter

This reduces duplicate code. This change also adds resolv.conf to the container.

Signed-off-by: Ophestra <cat@gensokyo.uk>

cmd/mbf/main.go

@@ -32,12 +32,11 @@ import (
 	"syscall"
 	"time"
 	"unique"
+	"unsafe"
 
 	"hakurei.app/check"
 	"hakurei.app/command"
 	"hakurei.app/container"
-	"hakurei.app/container/seccomp"
-	"hakurei.app/container/std"
 	"hakurei.app/ext"
 	"hakurei.app/fhs"
 	"hakurei.app/internal/pkg"
@@ -731,7 +730,7 @@ func main() {
 						return cache.EnterExec(
 							ctx,
 							a,
-							true, os.Stdin, os.Stdout, os.Stderr,
+							"", true, os.Stdin, os.Stdout, os.Stderr,
 							rosa.AbsSystem.Append("bin", "mksh"),
 							"sh",
 						)
@@ -934,6 +933,17 @@ func main() {
 			"shell",
 			"Interactive shell in the specified Rosa OS environment",
 			func(args []string) error {
+				resolvconf := "nameserver 1.1.1.1\nnameserver 1.0.0.1\n"
+				if p, err := os.ReadFile(fhs.AbsEtc.Append(
+					"resolv.conf",
+				).String()); err != nil {
+					if !errors.Is(err, os.ErrNotExist) {
+						return err
+					}
+				} else {
+					resolvconf = unsafe.String(unsafe.SliceData(p), len(p))
+				}
+
 				handles := make([]rosa.ArtifactH, len(args), len(args)+3)
 				for i, arg := range args {
 					handles[i] = rosa.ArtifactH(unique.Make(arg))
@@ -953,119 +963,42 @@ func main() {
 				)
 
 				root := make(pkg.Collect, 0, 6+len(args))
+				root = append(root, rosa.NewEtc(false))
 				root = rosa.Native().Std().Append(root, handles...)
 
-				if err := cm.Do(func(cache *pkg.Cache) error {
+				return cm.Do(func(cache *pkg.Cache) error {
-					_, _, err := cache.Cure(&root)
+					return cache.EnterExec(
-					return err
+						ctx,
-				}); err == nil {
+						pkg.NewExec(
-					return errors.New("unreachable")
+							"",
-				} else if !pkg.IsCollected(err) {
+							rosa.Native().Arch(),
-					return err
+							new(pkg.Checksum),
-				}
+							1,
-
+							flagNet,
-				type cureRes struct {
+							false,
-					pathname *check.Absolute
+							fhs.AbsRoot,
-					checksum unique.Handle[pkg.Checksum]
+							[]string{
-				}
+								"SHELL=/system/bin/mksh",
-				cured := make(map[pkg.Artifact]cureRes)
+								"PATH=/system/bin",
-				for _, a := range root {
+								"HOME=/",
-					if err := cm.Do(func(cache *pkg.Cache) error {
+							},
-						pathname, checksum, err := cache.Cure(a)
+							fhs.AbsProc.Append("nonexistent"),
-						if err == nil {
+							nil,
-							cured[a] = cureRes{pathname, checksum}
+							pkg.Path(fhs.AbsRoot, true, root...),
-						}
+							pkg.Path(
-						return err
+								fhs.AbsEtc.Append("resolv.conf"), false,
-					}); err != nil {
+								pkg.NewFile(
-						return err
+									"resolv.conf",
-					}
+									unsafe.Slice(unsafe.StringData(resolvconf), len(resolvconf)),
-				}
+								),
-
+							),
-				// explicitly open for direct error-free use from this point
+						),
-				if cm.c == nil {
+						"localhost",
-					if err := cm.open(); err != nil {
+						flagSession, os.Stdin, os.Stdout, os.Stderr,
-						return err
+						rosa.AbsSystem.Append("bin", "mksh"),
-					}
+						"sh",
-				}
+					)
-
-				layers := pkg.PromoteLayers(root, func(a pkg.Artifact) (
-					*check.Absolute,
-					unique.Handle[pkg.Checksum],
-				) {
-					res := cured[a]
-					return res.pathname, res.checksum
-				}, func(i int, d pkg.Artifact) {
-					r := pkg.Encode(cm.c.Ident(d).Value())
-					if s, ok := d.(fmt.Stringer); ok {
-						if name := s.String(); name != "" {
-							r += "-" + name
-						}
-					}
-					msg.Verbosef("promoted layer %d as %s", i, r)
 				})
-
-				z := container.New(ctx, msg)
-				z.WaitDelay = 3 * time.Second
-				z.SeccompPresets = pkg.SeccompPresets
-				z.SeccompFlags |= seccomp.AllowMultiarch
-				z.ParentPerm = 0700
-				z.HostNet = flagNet
-				z.RetainSession = flagSession
-				z.Hostname = "localhost"
-				z.Uid, z.Gid = (1<<10)-1, (1<<10)-1
-				z.Stdin, z.Stdout, z.Stderr = os.Stdin, os.Stdout, os.Stderr
-				z.Quiet = !cm.verboseInit
-				if s, ok := os.LookupEnv("TERM"); ok {
-					z.Env = append(z.Env, "TERM="+s)
-				}
-
-				var tempdir *check.Absolute
-				if s, err := filepath.Abs(os.TempDir()); err != nil {
-					return err
-				} else if tempdir, err = check.NewAbs(s); err != nil {
-					return err
-				}
-
-				z.Dir = fhs.AbsRoot
-				z.Env = []string{
-					"SHELL=/system/bin/mksh",
-					"PATH=/system/bin",
-					"HOME=/",
-				}
-				z.Path = rosa.AbsSystem.Append("bin", "mksh")
-				z.Args = []string{"mksh"}
-				z.
-					OverlayEphemeral(fhs.AbsRoot, layers...).
-					Place(
-						fhs.AbsEtc.Append("hosts"),
-						[]byte("127.0.0.1 localhost\n"),
-					).
-					Place(
-						fhs.AbsEtc.Append("passwd"),
-						[]byte("media_rw:x:1023:1023::/:/system/bin/sh\n"+
-							"nobody:x:65534:65534::/proc/nonexistent:/system/bin/false\n"),
-					).
-					Place(
-						fhs.AbsEtc.Append("group"),
-						[]byte("media_rw:x:1023:\nnobody:x:65534:\n"),
-					).
-					Bind(tempdir, fhs.AbsTmp, std.BindWritable).
-					Proc(fhs.AbsProc).Dev(fhs.AbsDev, true)
-
-				if flagArch != "" && flagArch != runtime.GOARCH {
-					if entry, ok := pkg.Arch()[flagArch]; ok {
-						z.InitAsRoot = true
-						z.Binfmt = []container.BinfmtEntry{entry}
-					}
-				}
-
-				if err := z.Start(); err != nil {
-					return err
-				}
-				if err := z.Serve(); err != nil {
-					return err
-				}
-				return z.Wait()
 			},
 		).Flag(
 			&flagNet,

internal/pkg/exec.go

@@ -591,6 +591,7 @@ var (
 func (c *Cache) EnterExec(
 	ctx context.Context,
 	a Artifact,
+	hostname string,
 	retainSession bool,
 	stdin io.Reader,
 	stdout, stderr io.Writer,
@@ -671,6 +672,9 @@ func (c *Cache) EnterExec(
 			z.Env = append(z.Env, "TERM="+s)
 		}
 	}
+	if hostname != "" {
+		z.Hostname = hostname
+	}
 
 	if err = z.Start(); err != nil {
 		return