container: enter init path early

There is generally no use case where any setup is required before init, and requiring the explicit function call is error-prone and unnecessary. It also causes trouble with packages using a similar trick. This change moves argv0 check early and makes it an import side effect. The stub will be removed in v0.5.

Signed-off-by: Ophestra <cat@gensokyo.uk>

cmd/hakurei/main.go

@@ -46,7 +46,6 @@ import (
 	"os/signal"
 	"syscall"
 
-	"hakurei.app/container"
 	"hakurei.app/ext"
 	"hakurei.app/message"
 )
@@ -59,9 +58,6 @@ var license string
 type earlyHardeningErrs struct{ yamaLSM, dumpable error }
 
 func main() {
-	// early init path, skips root check and duplicate PR_SET_DUMPABLE
-	container.TryArgv0(nil)
-
 	log.SetFlags(0)
 	log.SetPrefix("hakurei: ")
 	msg := message.New(log.Default())

cmd/mbf/main.go

@@ -37,7 +37,6 @@ import (
 
 	"hakurei.app/check"
 	"hakurei.app/command"
-	"hakurei.app/container"
 	"hakurei.app/ext"
 	"hakurei.app/fhs"
 	"hakurei.app/internal/pkg"
@@ -67,8 +66,6 @@ func writeFileExcl(name string, data []byte, perm os.FileMode) error {
 }
 
 func main() {
-	container.TryArgv0(nil)
-
 	log.SetFlags(0)
 	log.SetPrefix("mbf: ")
 	msg := message.New(log.Default())

cmd/sharefs/fuse.go

@@ -287,7 +287,6 @@ func unsafeAddArgument(args *fuseArgs, arg string) {
 
 func _main(s ...string) (exitCode int) {
 	msg := message.New(log.Default())
-	container.TryArgv0(msg)
 	runtime.LockOSThread()
 
 	// don't mask creation mode, kernel already did that