maemachinebroke/hakurei
1
0
Fork 0
forked from rosa/hakurei
Code Pull Requests Activity
1,054 Commits 7 Branches 12 Tags
8a91234cb4d8cbf6e1d5b909bc11f630d78a93e5
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
cat 8a91234cb4 hst: reword and improve doc comments 
This corrects minor mistakes in doc comments and adds them for undocumented constants.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-12 05:03:14 +09:00
cat db7051a368 internal/app/spcontainer: check fs init behaviour 
This covers every statement. Some of them are unreachable unless the kernel returns garbage.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-12 03:58:53 +09:00
cat 36f312b3ba internal/app/spcontainer: resolve path through dispatcher 
This prevents state from os tainting the test data.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 20:20:41 +09:00
cat 037144b06e system/dbus: use well-known address in spec 
The session bus still performs non-standard formatting since it makes no sense for hakurei to start the session bus.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 18:52:06 +09:00
cat f5a597c406 hst: rename /.hakurei constant 
This provides disambiguation from fhs.AbsTmp.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 14:32:35 +09:00
cat 8874aaf81b hst: remove template bind nix store 
This does not add anything meaningful to the template, since there are already prior examples showing src-only bind ops. Remove this since it causes confusion by covering the previous mount point targeting /nix/store.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 13:59:10 +09:00
cat 04a27c8e47 hst: use plausible overlay template 
The current value is copied from a test case, and does not resemble its intended use case.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 13:51:08 +09:00
cat 9e3df0905b internal/app/spcontainer: check params init behaviour 
This change also significantly reduces duplicate information in test case.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 02:44:02 +09:00
cat 9290748761 internal/app/spaccount: check behaviour 
This begins the effort of fully covering internal/app.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 00:54:04 +09:00
cat 23084888a0 internal/app/spaccount: apply default in shim 
The original code clobbers hst.Config, and was not changed when being ported over.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 00:38:06 +09:00
cat 50f6fcb326 container/stub: mark test overrides as helper 
This fixes line information in test reporting messages.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 22:15:20 +09:00
cat 070e346587 internal/app: relocate params state initialisation 
This is useful for testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 22:00:49 +09:00
cat 24de7c50a0 internal/app: relocate state initialisation 
This is useful for testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 20:15:58 +09:00
cat f6dd9dab6a internal/app: hold path hiding in op 
This makes no sense to be part of the global state.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 19:56:30 +09:00
cat 776650af01 hst/config: negative WaitDelay bypasses default 
This behaviour might be useful, so do not lock it out. This change also fixes an oversight where the unchecked value is used to determine ForwardCancel.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 05:11:32 +09:00
cat 109aaee659 internal/app: copy parts of config to state 
This is less error-prone than passing the address to the entire hst.Config struct, and reduces the likelihood of accidentally clobbering hst.Config. This also improves ease of testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 03:19:09 +09:00
cat 22ee5ae151 internal/app: filter ops in implementation 
This is cleaner and less error-prone, and should also result in negligibly less memory allocation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 02:23:34 +09:00
cat 4246256d78 internal/app: hold config address in state 
This can be removed eventually as it is barely used.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 01:21:01 +09:00
cat a941ac025f container/init: unwrap descriptive fatal error 
These errors are printed with a descriptive message prefixed to them, so it is more readable to expose the underlying errno.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 22:04:35 +09:00
cat 87b5c30ef6 message: relocate from container 
This package is quite useful. This change allows it to be imported without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 05:18:19 +09:00
cat df9b77b077 internal/app: do not encode config early 
Finalise no longer clobbers hst.Config.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 04:38:54 +09:00
cat a40d182706 internal/app: build container state in shim 
This significantly decreases ipc overhead.

Closes #3.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 22:30:40 +09:00
cat e5baaf416f internal/app: check transmitted ops 
This simulates params to shim and this is the last step before params to shim is merged.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 20:02:09 +09:00
cat ee6c471fe6 internal/app: relocate ops condition 
This allows reuse and finer grained testing of fromConfig.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 19:39:00 +09:00
cat 16bf3178d3 internal/app: relocate dynamic exported state 
This allows reuse of the populateEarly method in test instrumentation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:34:17 +09:00
cat 034c59a26a internal/app: relocate late sys/params outcome 
This will end up merged with another op after reordering. For now relocate it into its dedicated op for test instrumentation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:26:50 +09:00
cat 5bf28901a4 cmd/hsu: check against setgid bit 
The getgroups behaviour is already checked for, but it never hurts to be more careful in a setuid program.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:22:24 +09:00
cat 9b507715d4 hst/dbus: validate interface strings 
This is relocated to hst to validate early.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 04:57:22 +09:00
cat 12ab7ea3b4 hst/fs: access ops through interface 
This removes the final hakurei.app/container import from hst.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 23:59:48 +09:00
cat 1f0226f7e0 container/check: relocate overlay escape 
This is used in hst to format strings.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 23:56:19 +09:00
cat 584ce3da68 container/bits: move bind bits 
This allows referring to the bits without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 21:38:31 +09:00
cat 5d18af0007 container/fhs: move pathname constants 
This allows referencing FHS pathnames without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 21:29:16 +09:00
cat 0e6c1a5026 container/check: move absolute pathname 
This allows use of absolute pathname values without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 20:57:58 +09:00
cat d23b4dc9e6 hst/dbus: move dbus config struct 
This allows holding a xdg-dbus-proxy configuration without importing system/dbus.

It also makes more sense in the project structure since the config struct is part of the hst API however the rest of the implementation is not.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 19:03:51 +09:00
cat 3ce63e95d7 container: move seccomp preset bits 
This allows holding the bits without cgo.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 18:28:20 +09:00
cat 2489766efe hst/config: identity bounds check early 
This makes sense to do here instead of in internal/app.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 17:58:28 +09:00
cat 9e48d7f562 hst/config: move container fields from toplevel 
This change also moves pd behaviour to cmd/hakurei, as this does not belong in the hst API.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 04:24:45 +09:00
cat f280994957 internal/app: check nscd socket for path hiding 
This can seriously break things, and exposes extra host attack surface, so include it here.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 20:47:30 +09:00
cat ae7b343cde hst: reword and move constants 
These values are considered part of the stable, exported API, so move them to hst.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 17:40:32 +09:00
cat a63a372fe0 internal/app: merge static stub 
These tests now serve as integration tests, and finer grained tests for each op will be added slowly.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 17:15:14 +09:00
cat 16f9001f5f hst/config: update doc comments 
Some information here are horribly out of date. This change updates and improves all doc comments.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 04:12:53 +09:00
cat 80ad2e4e23 internal/app: do not offset base value 
This value is applied to the shim, it is incorrect to offset the base value as well.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:59:52 +09:00
cat 92b83bd599 internal/app: apply pd behaviour to outcomeState 
This avoids needlessly clobbering hst.Config.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:53:23 +09:00
cat 8ace214832 system/wayland: hang up security-context-v1 internally 
This should have been an implementation detail and should not be up to the caller to close.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:25:13 +09:00
cat eb5ee4fece internal/app: modularise outcome finalise 
This is the initial effort of splitting up host and container side of finalisation for params to shim. The new layout also enables much finer grained unit testing of each step, as well as partition access to per-app state for each step.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 02:52:50 +09:00
cat 9462af08f3 system/dbus: dump buffer internally 
This should have been an implementation detail and should not be up to the caller to call it.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-04 20:31:14 +09:00
cat a5f0aa3f30 internal/app: declutter and merge small files 
This should make internal/app easier to work with for the upcoming params to shim.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 16:59:29 +09:00
cat dd0bb0a391 internal/app: check username validation 
This stuff should be hardcoded in libc, but check it anyway.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 16:42:42 +09:00
cat d16da6da8c system: enforce absolute paths 
This is less error-prone, and is quite easy to integrate considering internal/app has already migrated to container.Absolute.

Closes #11.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 02:26:14 +09:00
cat e58181a930 internal/app/paths: defer extra formatting 
This reduces payload size for params to shim.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-30 00:21:26 +09:00
cat 71e70b7b5f internal/app/paths: do not print messages 
This change was missed while merging the rest of the logging changes.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 09:30:57 +09:00
cat afa1a8043e helper/proc: raise FulfillmentTimeout in tests 
This appears to be yet another source of spurious test failures.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 07:44:33 +09:00
cat 1ba1cb8865 hst/config: remove seccomp bit fields 
These serve little purpose and are not friendly for use from other languages.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 07:07:16 +09:00
cat 44ba7a5f02 hst/enablement: move bits from system 
This is part of the hst API, should not be in the implementation package.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:34:29 +09:00
cat dc467493d8 internal: remove hlog 
This package has been fully replaced by container.Msg.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:21:04 +09:00
cat 46cd3a28c8 container: remove global msg 
This frees all container instances of side effects.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:11:47 +09:00
cat ad1bc6794f release: 0.2.2 
Unfortunately removal of internal/hlog brought about some changes that breaks API. This will likely be the last 0.2.x release.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-28 21:58:19 +09:00
cat e55822c62f container/init: reduce verbose noise 
This makes it possible to optionally omit the identifying verbose message, for when the Op implementation can provide a much more useful message in its case, using information not yet available to the String method.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-28 21:51:10 +09:00
cat 802e6afa34 container/output: move global output to msg 
Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-27 19:55:37 +09:00
cat e906cae9ee container/output: export suspendable writer 
This is quite useful for other packages as well. This change prepares internal/hlog for removal.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-27 19:46:35 +09:00
cat ae2df2c450 internal: remove sys package 
This package is replaced by container/stub. Remove and replace it with unexported implementation for the upcoming test suite rewrite.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-25 13:51:54 +09:00
cat 6e3f34f2ec internal/app: merge finalise test cases 
This cleans everything up a bit for the upcoming test suite rewrite.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-25 12:11:02 +09:00
cat 65a0bb9729 internal/sys/hsu: expose hsurc identifier 
This maintains a compatible interface for now, to ease merging of the upcoming changes to internal/app.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 21:17:04 +09:00
cat afa7a0800d cmd/hsu: return hsurc id 
The uid format is stable, this value is what caller has to obtain through hsu.

Closes #14.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 21:10:13 +09:00
cat 773253fdf5 test/sandbox: raise timeout 
The integration vm is being very slow for some reason. This change should reduce spurious timeouts.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 19:41:59 +09:00
cat 409ed172c8 internal/app: handle LookupGroup error 
This could return errnos from the cgo calls.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 19:36:55 +09:00
cat 1c4f593566 internal/app: unexport outcome, remove app struct 
The App struct no longer does anything, and the outcome struct is entirely opaque.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 18:44:14 +09:00
cat b99c63337d internal/app: do not return from shim start 
The whole RunState ugliness and the other horrendous error handling conditions for internal/app come from an old design proposal for maintaining all app containers under the same daemon process for a user. The proposal was ultimately rejected but the implementation remained. It is removed here to alleviate internal/app from much of its ugliness and unreadability.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-24 13:37:38 +09:00
cat f09133a224 test: check init lingering timeout behaviour 
This checks init timeout on lingering process after initial process termination.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-22 21:56:29 +09:00
cat 16409b37a2 internal/app: compensate shim timeout 
This catches cases where the shim has somehow locked up, so it should wait out the full shim WaitDelay as well.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-16 02:23:19 +09:00
cat a2a291791c internal/sys: separate hsu uid cache 
This begins the effort of the removal of the sys package.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-15 02:30:47 +09:00
cat 8690419c2d hst: replace internal/app error 
This turns out to still be quite useful across internal/app and its relatives. Perhaps a cleaner replacement for baseError.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-15 01:44:43 +09:00
cat 1cdc6b4246 test/sandbox: create marker in /var/tmp 
This prepares the test suite for private TMPDIR.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 16:45:17 +09:00
cat 56aad8dc11 test/sandbox/tool: marker pathname from flag 
Since this is going to be placed in a shared directory, it needs to be unique to the identity. Instead of trying to figure out identity from mountinfo, just have the test script pass hardcoded values.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 15:57:41 +09:00
cat 83c4f8b767 test/sandbox: check extra writable paths 
This is not always obvious from mountinfo.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 15:12:51 +09:00
cat d0ddd71934 test/sandbox: bind /var/tmp writable 
This makes it possible to place markers with private tmpdir.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 14:59:53 +09:00
cat 70e02090f7 nix: use slightly less ambiguous type 
I had trouble getting Nix to merge json arrays properly, I am not sure that this helps.

At this point I have given up trying to understand Nix type system, and I am just trying to keep the Nix stuff going with extensive tests until it can be replaced by lkl for testing and planterette for general usage.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 14:45:14 +09:00
cat ca247b8037 internal/app: mount /dev/shm early 
This avoids covering /dev/shm mounts from hst.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-14 01:49:42 +09:00
cat 3f25c3f0af container: initialise cmd early 
This allows use of more cmd methods.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-13 20:01:33 +09:00
cat e271fa77aa nix: update flake lock 
Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-13 12:07:57 +09:00
cat f876043844 internal/hlog: remove error wrapping 
This was a stopgap solution that lasted for way too long. This finally removes it and prepares internal/app for some major changes.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-12 06:52:35 +09:00
cat 6265aea73a system: partial I inherit dispatcher 
This enables I struct methods to be checked.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-11 02:02:31 +09:00
cat c8a0effe90 system/wayland: use syscall dispatcher 
This enables wayland op methods to be instrumented.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-11 01:48:18 +09:00
cat 8df01b71d4 system: remove test package 
This prepares the Commit and Revert methods for testing via stub.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-10 23:50:22 +09:00
cat 985c4dd2fc system/xhost: wrap revert error correctly 
This otherwise creates a confusing error message on a revert failure.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-08 04:17:39 +09:00
cat da2b9c01ce system/tmpfiles: do not fail for smaller files 
The limit is meant to be an upper bound. Handle EOF and print verbose message for it instead of failing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-08 03:22:10 +09:00
cat 323d132c40 system/mkdir: use syscall dispatcher 
This enables mkdir op methods to be instrumented.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 22:30:08 +09:00
cat 6cc2b406a4 system/link: use syscall dispatcher 
This enables hardlink op methods to be instrumented.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 19:47:58 +09:00
cat fcd0f2ede7 system/output: pass through LinkError 
This has similar formatting to PathError.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 17:41:06 +09:00
cat e68db7fbfc system: unexport Op implementations 
None of these are valid with their zero value, and the implementations assume they are created by the builder methods. They are by all means an implementation detail and exporting them makes no sense.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 16:16:03 +09:00
cat ac81cfbedc system/dbus: print incomplete string in buffer 
Not sure if this will ever be reached, but nice to have nonetheless.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 15:50:29 +09:00
cat 05db06c87b system/dbus: use syscall dispatcher 
This allows dbus op methods and builder to be instrumented.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 14:25:19 +09:00
cat e603b688ca system/dispatcher: expose test reporting to builder 
This is currently unused but useful for builders with errors.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 12:59:33 +09:00
cat a9def08533 system/dbus: drop proxy output beyond threshold 
This prevents xdg-dbus-proxy from running the priv process out of memory.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-06 02:56:21 +09:00
cat ecaf43358d system/dbus: create context in subtest 
This is causing a huge amount of spurious test failures due to the poor performance of the integration vm. This should finally put an end to the annoyance.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-05 05:15:40 +09:00
cat 197fa65b8f system/dbus: remove redundant proxy pairs 
This is left over from before dbus.Final. Remove them now as they serve no purpose.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-05 02:07:56 +09:00
cat e81a45e849 container/dispatcher: optional stub wait4 signal association 
This synchronises the wait4 return after the toplevel signal call in lowlastcap_signaled_cancel_forward_error.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-04 20:28:49 +09:00
cat 3920acf8c2 container/stub: remove function call in handleExit 
This gets inlined and does not cause problems usually but turns out -coverpkg uninlines it and breaks the recovery.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-04 19:39:12 +09:00
cat 19630a9593 container/dispatcher: remove wait4 test log 
Turns out the reporting methods are not safe for concurrent use, despite the claim in testing.T doc comment.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-04 05:30:57 +09:00
cat 4051577d6b container/stub: override goexit methods 
FailNow, Fatal, Fatalf, SkipNow, Skip and Skipf must be called from the goroutine created by the test.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-04 04:51:49 +09:00