maemachinebroke/hakurei
1
0
Fork 0
forked from rosa/hakurei
Code Pull Requests Activity
1,095 Commits 7 Branches 12 Tags
b9459a80c7d178d6c5b199dcab77749cb3686741
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
cat b9459a80c7 container/init: check use constants for open flags 
These bits are arch-specific.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-21 03:13:58 +09:00
cat f8189d1488 container/syscall: dot-import syscall 
This avoids having arch-specific constants for arm64.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-21 03:09:14 +09:00
cat 5063b774c1 hst: expose version string 
The hst API is tied to this version string.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-21 01:56:44 +09:00
cat 766dd89ffa internal: clean up build strings 
These names are less ambiguous and should be understandable without reading the source code.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-21 01:49:36 +09:00
cat 699c19e972 hst/container: optional runtime and tmpdir sharing 
Sharing and persisting these directories do not always make sense. Make it optional here.

Closes #16.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 04:11:38 +09:00
cat b5b30aea2e test: place marker in common path 
This discontinues the dependency on shared tmpdir and xdg_runtime_dir implementation detail, for #16.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 03:50:48 +09:00
cat c0e860000a internal/app: remove spfinal 
This no longer needs to be an independent outcomeOp since spFilesystemOp is moved late.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 02:58:46 +09:00
cat d87020f0ca hst/config: validate env early 
This should happen in hst since it requires no system state.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 02:39:49 +09:00
cat e47aebb7a0 internal/app/outcome: apply configured filesystems late 
This enables configured filesystems to cover system mount points.

Closes #8.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 01:41:52 +09:00
cat 543bf69102 internal/app/spx11: check behaviour 
This outcomeOp will likely never change.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 01:00:12 +09:00
cat 4cfb1fda8f internal/app/spwayland: check behaviour 
This op is quite clean. Might get slightly more complex at some point passing socket fd.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-19 00:30:56 +09:00
cat c12183959a internal/app/dispatcher: report correct field 
This was mistakenly reporting sharePath on inequivalence causing very confusing output.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 23:59:10 +09:00
cat f5845e312e internal/app/sptmpdir: check behaviour 
Another simple one. This will change when shared tmpdir and xdg runtime dir becomes optional.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 23:46:10 +09:00
cat a103c4a7c7 internal/app/hsu: check behaviour 
The stub exec.ExitError is hairy as usual, but internal/app is not cross-platform, so this is okay.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 20:45:42 +09:00
cat 67ec82ae1b ldd/exec: raise timeout 
This mostly helps with tests.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 18:03:09 +09:00
cat f6f0cb56ae internal/app/hsu: remove wrapper method 
This was added to reduce the size of diffs.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 17:35:20 +09:00
cat d4284c109d internal/app/spruntime: emulate pam_systemd type 
This sets XDG_SESSION_TYPE to the corresponding values specified in pam_systemd(8) according to enablements.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 04:33:04 +09:00
cat 030ad2a73b internal/app/spruntime: check behaviour 
This one is quite simple and has no state. Needs to emulate pam_systemd behaviour so that will change.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 03:41:49 +09:00
cat 78d7955abd internal/app/sppulse: check cookie discovery 
There's quite a bit of code duplication here, but since this is already quite simple it is best to leave it as is for now.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 01:30:33 +09:00
cat b066495a7d internal/app/sppulse: check buf error injection 
The loadFile behaviour does not guarantee the buffer to be zeroed or not clobbered if an error is returned, but for the current implementation it is good to check.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-18 01:01:52 +09:00
cat 82299d34c6 internal/app/sppulse: correctly handle small cookie 
The trailing zero bytes need to be sliced off, so send cookie size alongside buffer content.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-17 08:03:03 +09:00
cat 792013cefb internal/app/sppulse: check behaviour 
Still needs to check the relocated functions separately.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-17 06:32:21 +09:00
cat 3f39132935 internal/app/dispatcher: reduce check code duplication 
This also improves readability of test cases.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-17 05:47:12 +09:00
cat c922c3f80e internal/app/sppulse: relocate hard to test code 
These are better tested separately instead of creating many op test cases.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-16 05:47:49 +09:00
cat 6cf58ca1b3 internal/app/spfinal: check behaviour 
This will be merged with spFilesystemOp eventually.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-16 02:08:31 +09:00
cat 425421d9b1 hst/container: rename constants 
The shim is an implementation detail and should not be mentioned in the API.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-16 00:27:00 +09:00
cat 5e0f15d76b hst/container: additional shim exit codes 
These are now considered stable, defined behaviour and can be used by external programs to determine shim outcome.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-15 22:09:33 +09:00
cat ae65491223 container/init: use one channel for wait4 
When using two channels it is possible for the other case to be reached before all pending winfo are consumed, causing incorrect reporting.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-15 21:35:19 +09:00
cat 52e3324ef4 test/sandbox: ignore nondeterministic mount point 
No idea what systemd is doing with this to cause its options to change.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 07:08:39 +09:00
cat f95e0a7568 hst/config: hold acl struct by value 
Doc comments are also reworded for clarity.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 07:02:14 +09:00
cat 4c647add0d hst/container: pack boolean options 
The memory saving is relatively insignificant, however this increases serialisation efficiency.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 06:39:00 +09:00
cat a341466942 hst: separate container config 
The booleans are getting packed into a single field. This requires non-insignificant amount of code for JSON serialisation to stay compatible.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 04:23:05 +09:00
cat e4ee8df83c internal/app/spdbus: check behaviour 
This is not done very cleanly, however this op is pending removal for the in-process dbus proxy so not worth spending too much effort here. As long as it checks all paths it is good enough.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 01:51:01 +09:00
cat 048c1957f1 helper/args: variadic check function 
This package turns out to be much less widely used than anticipated, and might be facing removal. This change makes test cases cleaner.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 01:48:56 +09:00
cat 790d77075e system/dbus: remove builder state leak 
This enables external testing of system.I state.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-14 01:33:44 +09:00
cat e5ff40e7d3 container: synchronise after notify 
This should eliminate intermittent failures in the forward test.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 19:17:19 +09:00
cat 123d7fbfd5 container/seccomp: remove export pipe 
This was only useful when wrapping bwrap.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 18:51:35 +09:00
cat 7638a44fa6 treewide: parallel tests 
Most tests already had no global state, however parallel was never enabled. This change enables it for all applicable tests.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 04:38:48 +09:00
cat a14b6535a6 helper/stub: write ready byte late 
Hopefully eliminates spurious failures.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 01:55:44 +09:00
cat 763ab27e09 system: remove tmpfiles 
This is no longer used.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 01:12:44 +09:00
cat bff2a1e748 container/initplace: remove indirect method 
This is no longer useful and is highly error-prone.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-13 01:06:45 +09:00
cat 8a91234cb4 hst: reword and improve doc comments 
This corrects minor mistakes in doc comments and adds them for undocumented constants.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-12 05:03:14 +09:00
cat db7051a368 internal/app/spcontainer: check fs init behaviour 
This covers every statement. Some of them are unreachable unless the kernel returns garbage.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-12 03:58:53 +09:00
cat 36f312b3ba internal/app/spcontainer: resolve path through dispatcher 
This prevents state from os tainting the test data.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 20:20:41 +09:00
cat 037144b06e system/dbus: use well-known address in spec 
The session bus still performs non-standard formatting since it makes no sense for hakurei to start the session bus.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 18:52:06 +09:00
cat f5a597c406 hst: rename /.hakurei constant 
This provides disambiguation from fhs.AbsTmp.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 14:32:35 +09:00
cat 8874aaf81b hst: remove template bind nix store 
This does not add anything meaningful to the template, since there are already prior examples showing src-only bind ops. Remove this since it causes confusion by covering the previous mount point targeting /nix/store.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 13:59:10 +09:00
cat 04a27c8e47 hst: use plausible overlay template 
The current value is copied from a test case, and does not resemble its intended use case.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 13:51:08 +09:00
cat 9e3df0905b internal/app/spcontainer: check params init behaviour 
This change also significantly reduces duplicate information in test case.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 02:44:02 +09:00
cat 9290748761 internal/app/spaccount: check behaviour 
This begins the effort of fully covering internal/app.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 00:54:04 +09:00
cat 23084888a0 internal/app/spaccount: apply default in shim 
The original code clobbers hst.Config, and was not changed when being ported over.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-11 00:38:06 +09:00
cat 50f6fcb326 container/stub: mark test overrides as helper 
This fixes line information in test reporting messages.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 22:15:20 +09:00
cat 070e346587 internal/app: relocate params state initialisation 
This is useful for testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 22:00:49 +09:00
cat 24de7c50a0 internal/app: relocate state initialisation 
This is useful for testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 20:15:58 +09:00
cat f6dd9dab6a internal/app: hold path hiding in op 
This makes no sense to be part of the global state.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 19:56:30 +09:00
cat 776650af01 hst/config: negative WaitDelay bypasses default 
This behaviour might be useful, so do not lock it out. This change also fixes an oversight where the unchecked value is used to determine ForwardCancel.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 05:11:32 +09:00
cat 109aaee659 internal/app: copy parts of config to state 
This is less error-prone than passing the address to the entire hst.Config struct, and reduces the likelihood of accidentally clobbering hst.Config. This also improves ease of testing.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 03:19:09 +09:00
cat 22ee5ae151 internal/app: filter ops in implementation 
This is cleaner and less error-prone, and should also result in negligibly less memory allocation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 02:23:34 +09:00
cat 4246256d78 internal/app: hold config address in state 
This can be removed eventually as it is barely used.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-10 01:21:01 +09:00
cat a941ac025f container/init: unwrap descriptive fatal error 
These errors are printed with a descriptive message prefixed to them, so it is more readable to expose the underlying errno.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 22:04:35 +09:00
cat 87b5c30ef6 message: relocate from container 
This package is quite useful. This change allows it to be imported without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 05:18:19 +09:00
cat df9b77b077 internal/app: do not encode config early 
Finalise no longer clobbers hst.Config.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-09 04:38:54 +09:00
cat a40d182706 internal/app: build container state in shim 
This significantly decreases ipc overhead.

Closes #3.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 22:30:40 +09:00
cat e5baaf416f internal/app: check transmitted ops 
This simulates params to shim and this is the last step before params to shim is merged.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 20:02:09 +09:00
cat ee6c471fe6 internal/app: relocate ops condition 
This allows reuse and finer grained testing of fromConfig.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 19:39:00 +09:00
cat 16bf3178d3 internal/app: relocate dynamic exported state 
This allows reuse of the populateEarly method in test instrumentation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:34:17 +09:00
cat 034c59a26a internal/app: relocate late sys/params outcome 
This will end up merged with another op after reordering. For now relocate it into its dedicated op for test instrumentation.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:26:50 +09:00
cat 5bf28901a4 cmd/hsu: check against setgid bit 
The getgroups behaviour is already checked for, but it never hurts to be more careful in a setuid program.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 18:22:24 +09:00
cat 9b507715d4 hst/dbus: validate interface strings 
This is relocated to hst to validate early.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-08 04:57:22 +09:00
cat 12ab7ea3b4 hst/fs: access ops through interface 
This removes the final hakurei.app/container import from hst.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 23:59:48 +09:00
cat 1f0226f7e0 container/check: relocate overlay escape 
This is used in hst to format strings.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 23:56:19 +09:00
cat 584ce3da68 container/bits: move bind bits 
This allows referring to the bits without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 21:38:31 +09:00
cat 5d18af0007 container/fhs: move pathname constants 
This allows referencing FHS pathnames without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 21:29:16 +09:00
cat 0e6c1a5026 container/check: move absolute pathname 
This allows use of absolute pathname values without importing container.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 20:57:58 +09:00
cat d23b4dc9e6 hst/dbus: move dbus config struct 
This allows holding a xdg-dbus-proxy configuration without importing system/dbus.

It also makes more sense in the project structure since the config struct is part of the hst API however the rest of the implementation is not.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 19:03:51 +09:00
cat 3ce63e95d7 container: move seccomp preset bits 
This allows holding the bits without cgo.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 18:28:20 +09:00
cat 2489766efe hst/config: identity bounds check early 
This makes sense to do here instead of in internal/app.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 17:58:28 +09:00
cat 9e48d7f562 hst/config: move container fields from toplevel 
This change also moves pd behaviour to cmd/hakurei, as this does not belong in the hst API.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-07 04:24:45 +09:00
cat f280994957 internal/app: check nscd socket for path hiding 
This can seriously break things, and exposes extra host attack surface, so include it here.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 20:47:30 +09:00
cat ae7b343cde hst: reword and move constants 
These values are considered part of the stable, exported API, so move them to hst.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 17:40:32 +09:00
cat a63a372fe0 internal/app: merge static stub 
These tests now serve as integration tests, and finer grained tests for each op will be added slowly.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 17:15:14 +09:00
cat 16f9001f5f hst/config: update doc comments 
Some information here are horribly out of date. This change updates and improves all doc comments.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 04:12:53 +09:00
cat 80ad2e4e23 internal/app: do not offset base value 
This value is applied to the shim, it is incorrect to offset the base value as well.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:59:52 +09:00
cat 92b83bd599 internal/app: apply pd behaviour to outcomeState 
This avoids needlessly clobbering hst.Config.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:53:23 +09:00
cat 8ace214832 system/wayland: hang up security-context-v1 internally 
This should have been an implementation detail and should not be up to the caller to close.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 03:25:13 +09:00
cat eb5ee4fece internal/app: modularise outcome finalise 
This is the initial effort of splitting up host and container side of finalisation for params to shim. The new layout also enables much finer grained unit testing of each step, as well as partition access to per-app state for each step.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-05 02:52:50 +09:00
cat 9462af08f3 system/dbus: dump buffer internally 
This should have been an implementation detail and should not be up to the caller to call it.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-04 20:31:14 +09:00
cat a5f0aa3f30 internal/app: declutter and merge small files 
This should make internal/app easier to work with for the upcoming params to shim.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 16:59:29 +09:00
cat dd0bb0a391 internal/app: check username validation 
This stuff should be hardcoded in libc, but check it anyway.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 16:42:42 +09:00
cat d16da6da8c system: enforce absolute paths 
This is less error-prone, and is quite easy to integrate considering internal/app has already migrated to container.Absolute.

Closes #11.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-10-03 02:26:14 +09:00
cat e58181a930 internal/app/paths: defer extra formatting 
This reduces payload size for params to shim.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-30 00:21:26 +09:00
cat 71e70b7b5f internal/app/paths: do not print messages 
This change was missed while merging the rest of the logging changes.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 09:30:57 +09:00
cat afa1a8043e helper/proc: raise FulfillmentTimeout in tests 
This appears to be yet another source of spurious test failures.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 07:44:33 +09:00
cat 1ba1cb8865 hst/config: remove seccomp bit fields 
These serve little purpose and are not friendly for use from other languages.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 07:07:16 +09:00
cat 44ba7a5f02 hst/enablement: move bits from system 
This is part of the hst API, should not be in the implementation package.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:34:29 +09:00
cat dc467493d8 internal: remove hlog 
This package has been fully replaced by container.Msg.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:21:04 +09:00
cat 46cd3a28c8 container: remove global msg 
This frees all container instances of side effects.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-29 06:11:47 +09:00
cat ad1bc6794f release: 0.2.2 
Unfortunately removal of internal/hlog brought about some changes that breaks API. This will likely be the last 0.2.x release.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-28 21:58:19 +09:00
cat e55822c62f container/init: reduce verbose noise 
This makes it possible to optionally omit the identifying verbose message, for when the Op implementation can provide a much more useful message in its case, using information not yet available to the String method.

Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-28 21:51:10 +09:00
cat 802e6afa34 container/output: move global output to msg 
Signed-off-by: Ophestra <cat@gensokyo.uk>
 2025-09-27 19:55:37 +09:00