rosa/hakurei
6
3
Fork 2
Code Issues 10 Pull Requests 2 Actions 2 Packages Projects Releases 15 Wiki Activity

system: wrap op errors
All checks were successful
Test / Create distribution (push) Successful in 26s
Details
Test / Hakurei (race detector) (push) Successful in 42s
Details
Test / Hakurei (push) Successful in 42s
Details
Test / Sandbox (race detector) (push) Successful in 41s
Details
Test / Sandbox (push) Successful in 41s
Details
Test / Hpkg (push) Successful in 40s
Details
Test / Flake checks (push) Successful in 1m24s
Details

Browse Source 
This passes more information allowing for better error handling. This eliminates generic WrapErr from system.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra
2025-08-30 22:49:12 +09:00
parent d13dfeca22
commit 57ade7aeaa
11 changed files with 297 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
system/acl.go
View File

@@ -36,8 +36,7 @@ func (a *ACL) Type() Enablement { return a.et }
func (a *ACL) apply(sys *I) error {
msg.Verbose("applying ACL", a)
return wrapErrSuffix(acl.Update(a.path, sys.uid, a.perms...),
fmt.Sprintf("cannot apply ACL entry to %q:", a.path))
return newOpError("acl", acl.Update(a.path, sys.uid, a.perms...), false)
}
func (a *ACL) revert(sys *I, ec *Criteria) error {
@@ -49,8 +48,7 @@ func (a *ACL) revert(sys *I, ec *Criteria) error {
msg.Verbosef("target of ACL %s no longer exists", a)
err = nil
}
return wrapErrSuffix(err,
fmt.Sprintf("cannot strip ACL entry from %q:", a.path))
return newOpError("acl", err, true)
} else {
msg.Verbose("skipping ACL", a)
return nil