rosa/hakurei
6
4
Fork 2
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 18 Wiki Activity

cmd/mbf: clone pkgserver order slices
All checks were successful
Test / Create distribution (push) Successful in 36s
Details
Test / ShareFS (push) Successful in 41s
Details
Test / Sandbox (race detector) (push) Successful in 46s
Details
Test / Sandbox (push) Successful in 48s
Details
Test / Hakurei (push) Successful in 52s
Details
Test / Hakurei (race detector) (push) Successful in 52s
Details
Test / Flake checks (push) Successful in 1m19s
Details

Browse Source 
These are no longer arrays, so must be cloned for sorting.

Signed-off-by: Ophestra <cat@gensokyo.uk>
This commit is contained in:
Ophestra
2026-05-17 18:30:57 +09:00
parent a967aa3b6e
commit 6b87bac401
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/mbf/internal/pkgserver/index.go
View File

@@ -87,21 +87,21 @@ func (index *packageIndex) populate(report *rosa.Report) (err error) {
} }
index.sorts[declarationAscending] = work index.sorts[declarationAscending] = work
index.sorts[declarationDescending] = work index.sorts[declarationDescending] = slices.Clone(work)
slices.Reverse(index.sorts[declarationDescending][:]) slices.Reverse(index.sorts[declarationDescending][:])
index.sorts[nameAscending] = work index.sorts[nameAscending] = slices.Clone(work)
slices.SortFunc(index.sorts[nameAscending][:], func(a, b *metadata) int { slices.SortFunc(index.sorts[nameAscending][:], func(a, b *metadata) int {
return strings.Compare(a.Name, b.Name) return strings.Compare(a.Name, b.Name)
}) })
index.sorts[nameDescending] = index.sorts[nameAscending] index.sorts[nameDescending] = slices.Clone(index.sorts[nameAscending])
slices.Reverse(index.sorts[nameDescending][:]) slices.Reverse(index.sorts[nameDescending][:])
index.sorts[sizeAscending] = work index.sorts[sizeAscending] = slices.Clone(work)
slices.SortFunc(index.sorts[sizeAscending][:], func(a, b *metadata) int { slices.SortFunc(index.sorts[sizeAscending][:], func(a, b *metadata) int {
return cmp.Compare(a.Size, b.Size) return cmp.Compare(a.Size, b.Size)
}) })
index.sorts[sizeDescending] = index.sorts[sizeAscending] index.sorts[sizeDescending] = slices.Clone(index.sorts[sizeAscending])
slices.Reverse(index.sorts[sizeDescending][:]) slices.Reverse(index.sorts[sizeDescending][:])
return return