100 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
cat	23ae7822bf	cmd/hakurei/parse: use new store interface ... This greatly reduces overhead. The iterator also significantly cleans up the usage code. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 16:00:41 +09:00
cat	898b5aed3d	internal/store: iterator over all entries ... This is quite convenient for searching the store or printing active instance information. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 15:54:00 +09:00
cat	7c3c3135d8	internal/outcome: track state in TMPDIR ... The SharePath is a more stable path than RunDirPath, since it is available all the time and should remain consistent. This also fits better into the intended use case of XDG_RUNTIME_DIR. Closes #17. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 12:40:58 +09:00
cat	f33aea9ff9	internal/env: cleaner runtime dir fallback ... This now places rundir inside the fallback runtime dir, so special case in internal/outcome is avoided. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 12:22:32 +09:00
cat	e7fc311d0b	internal/outcome/shim: cover reparent and exit request paths ... These test cases were missed when making the changes. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 11:58:09 +09:00
cat	f5274067f6	internal/outcome/process: nil-safe unlock when failing to lock ... This also prints a debug message which might be useful. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 11:47:51 +09:00
cat	e7161f8e61	internal/outcome: measure finalise time ... This also increases precision of state time output. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 05:17:33 +09:00
cat	6931ad95c3	internal/outcome/shim: EOF as exit request fallback ... In some cases the signal might be delivered before the signal handler is installed, and synchronising against such a case is too expensive. Instead, use the pipe being closed as a fallback to the regular exit request. This change also moves installation of the signal handler early. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 04:41:26 +09:00
cat	2ba599b399	internal/outcome/process: use new store interface ... This change also spawns shim before committing system state, leaving it blocking on the setup pipe. The internal/outcome/process structure is also entirely reworked to be much more readable and less error-prone, while enabling basic performance measurements. A long-standing bug where segment lock is not held during Commit is also resolved. Closes #19. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-02 04:25:45 +09:00
cat	d3d3417125	internal/outcome/process: relocate start and serve ... This is useful for reordering these operations for further cleanup. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-11-01 19:14:59 +09:00
cat	651cdf9ccb	internal/outcome: remove guard on main ... This is no longer exported. Such a check is pointless. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-31 22:58:26 +09:00
cat	68ff0a2ba6	container/params: expose pipe ... This increases flexibility of how caller wants to handle the I/O. Also makes it no longer rely on finalizer. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-31 22:39:02 +09:00
cat	6a0ecced90	internal/store: expose save via handle ... The handle is otherwise inaccessible without the compat interface. This change also moves compatibility methods to separate adapter structs to avoid inadvertently using them. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-31 04:20:22 +09:00
cat	b667fea1cb	internal/store: export new interface ... This exposes store operations safe for direct access, and enables #19 to be implemented in internal/outcome. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-31 03:41:26 +09:00
cat	b25ade5f3d	internal/store: rename compat interface ... The new store implementation will be exported as Store. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-30 18:53:59 +09:00
cat	ebdcff1049	internal/store: rename from state ... This reduces collision with local variable names, and generally makes sense for the new store package, since it no longer specifies the state struct. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-30 18:43:55 +09:00
cat	46c5ce4936	internal/outcome/shim: check full behaviour ... This took significant effort to stub out, and achieves full coverage after c5aefe5e9d. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-30 05:20:49 +09:00
cat	36f8064905	internal/outcome/process: output via msg ... This makes it possible to instrument output behaviour through stub. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-30 03:41:38 +09:00
cat	eeb9f98e5b	internal/outcome/shim: move signal constants ... The magic numbers hurt readability. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-30 01:20:51 +09:00
cat	3f9f331501	internal/outcome/shim: remove noop resume ... The shim does not suspend output to begin with. These are leftovers from when container startup code suspends output. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 23:31:39 +09:00
cat	2563391086	internal/outcome/shim: params check early ... This is unreachable, but keeping it here as a failsafe until more test cases are added. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 23:10:12 +09:00
cat	a0b4e47acc	internal/outcome: rename from app ... This is less ambiguous, and more accurately describes the purpose of the package. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 04:33:13 +09:00
cat	a52f7038e5	internal/env: relocate from app ... This package is much cleaner to stub independently, and makes no sense to lump into app. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 04:11:49 +09:00
cat	274686d10d	internal/validate: relocate from app ... These are free of the dispatcher from internal/app. This change relocates them into their own package. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 03:40:09 +09:00
cat	65342d588f	internal/app/state: improve store internals ... This fully exposes the store internals for #19 and are final preparations for removing the legacy store interface. This change also fixes a potential deadlock in the handle initialisation mkdir failure path. This however is never reachable in hakurei as the store is never accessed concurrently. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-29 03:21:00 +09:00
cat	5e5826459e	internal/app/state: improve handles internals ... This replaces the Store interface with something better reflecting the underlying data format for #19. An implementation of Store is provided on top of the new code to ease transition. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-28 22:00:54 +09:00
cat	4a463b7f03	internal/app/state: use absolute pathnames ... This is less error-prone and fits better into internal/app which already uses check.Absolute for all pathnames. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-26 03:41:19 +09:00
cat	dacd9550e0	internal/app/state: acquire big lock for toplevel operations ... This avoids getting into an inconsistent state for simultaneous calls to List and Do on a previously unknown identity. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-26 03:27:56 +09:00
cat	546b00429f	treewide: update doc comments ... Some internal/app/state types were relocated to hst as part of the API. This change updates doc comments referring to them. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-26 03:00:04 +09:00
cat	86f4219062	internal/app/state/data: check full entry behaviour ... This eventually gets relocated to internal/app. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-26 01:49:14 +09:00
cat	fe2929d5f7	internal/app/state: include et header ... This is the initial step of implementing #19. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-25 22:01:26 +09:00
cat	470e545d27	internal/app/state: use internal/lockedfile ... This is a pretty solid implementation backed by robust tests, with a much cleaner interface. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-25 21:29:24 +09:00
cat	8d3381821f	internal/app/state: export correct backend value ... This references the underlying multiBackend due to a typo, making the whole dance with c a noop. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-25 21:11:05 +09:00
cat	e9d00b9071	container/executable: handle nil msg ... This is useful in some tests. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-25 21:08:54 +09:00
cat	4f41afee0f	internal/app/state: fixed size et-only header ... This header improves the robustness of the format and significantly reduces cleanup overhead. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-25 19:15:06 +09:00
cat	7de593e816	cmd/hakurei: short identifier from lower half ... The upper half is now a nanosecond timestamp. Lower half is still random bytes, so use lower half for short identifier. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-24 00:47:39 +09:00
cat	2442eda8d9	hst/instance: embed config struct ... This makes the resulting json easier to parse since it can now be deserialised into the config struct. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-24 00:42:16 +09:00
cat	05488bfb8f	hst/instance: store priv side pid ... This can receive signals, so is more useful to the caller. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 23:19:55 +09:00
cat	dd94818f20	hst/instance: define instance state ... This is now part of the hst API. This change also improves identifier generation and serialisation. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 22:59:02 +09:00
cat	0fd357e7f6	container/init: do not suspend output ... Init is not very talkative after process start even when verbose. Suspending output here is pointless and does more harm than good. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 08:11:00 +09:00
cat	57231d4acf	container/init: improve signal handling ... The SIGTERM signal is delivered in many other cases and can lead to strange behaviour. The unconditional resume of the logger also causes strange behaviour in the cancellation forwarding path. This change also passes through additional signals. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 08:02:03 +09:00
cat	c5aefe5e9d	internal/app/shim: check behaviour ... This does not yet have full coverage. Test cases covering failsafe paths and error injection will be added eventually. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 06:07:41 +09:00
cat	0f8ffee44d	internal/app: test case for hst template ... This helps with other areas of the test suite as they're all based on hst.Template. This also helps contributors understand the behaviour of internal/app as hst.Template covers almost every aspect of it. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 04:46:58 +09:00
cat	1685a4d000	cmd/hsu: reduce excessive test range ... This is quite a simple piece of code, this many test cases is excessive and wastes time in the integration vm. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-23 04:32:32 +09:00
cat	6c338b433a	internal/app: reduce test case indentation ... This improves readability on narrower displays. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 07:40:32 +09:00
cat	8accd3b219	internal/app/shim: use syscall dispatcher ... This enables instrumented testing of the shim. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 06:58:45 +09:00
cat	c5f59c5488	container/syscall: export prctl wrapper ... This is useful as package "syscall" does not provide such a wrapper. This change also improves error handling to fully conform to the manpage. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 05:26:54 +09:00
cat	fcd9becf9a	cmd/hsu: run in locked thread ... Goroutine scheduling is not helpful in the setuid wrapper, it is not particularly harmful but lock here anyway. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 05:09:08 +09:00
cat	622f945c22	container/init: check msg in entrypoint ... This covers invalid call to Init. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-22 04:20:08 +09:00
cat	e94acc424c	container/comp: rename from bits ... This package will also hold syscall lookup tables for seccomp. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 20:54:03 +09:00
cat	b1a4d801be	hst/container: flags string representation ... This is useful for a user-facing representation other than JSON. This also gets rid of the ugly, outdated flags string builder in cmd/hakurei. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 20:29:52 +09:00
cat	56beae17fe	test: assert hst CGO_ENABLED=0 ... The hst package only deals with data serialisation, however since many parts of hakurei make use of C libraries in some way it can be easy to inadvertently depend on cgo. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 19:49:04 +09:00
cat	ea978101b1	cmd/hakurei/parse: close config fd ... This is cleaner than relying on the finalizer. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 06:05:36 +09:00
cat	fbd1638e7f	test/interactive/trace: update nix attribute ... Updated according to evaluation warning. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 06:03:09 +09:00
cat	d42067df7c	cmd/hakurei/json: friendly error messages ... This change handles errors returned by encoding/json and prints significantly cleaner messages. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 05:17:25 +09:00
cat	b9459a80c7	container/init: check use constants for open flags ... These bits are arch-specific. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 03:13:58 +09:00
cat	f8189d1488	container/syscall: dot-import syscall ... This avoids having arch-specific constants for arm64. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 03:09:14 +09:00
cat	5063b774c1	hst: expose version string ... The hst API is tied to this version string. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 01:56:44 +09:00
cat	766dd89ffa	internal: clean up build strings ... These names are less ambiguous and should be understandable without reading the source code. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-21 01:49:36 +09:00
cat	699c19e972	hst/container: optional runtime and tmpdir sharing ... Sharing and persisting these directories do not always make sense. Make it optional here. Closes #16. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 04:11:38 +09:00
cat	b5b30aea2e	test: place marker in common path ... This discontinues the dependency on shared tmpdir and xdg_runtime_dir implementation detail, for #16. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 03:50:48 +09:00
cat	c0e860000a	internal/app: remove spfinal ... This no longer needs to be an independent outcomeOp since spFilesystemOp is moved late. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 02:58:46 +09:00
cat	d87020f0ca	hst/config: validate env early ... This should happen in hst since it requires no system state. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 02:39:49 +09:00
cat	e47aebb7a0	internal/app/outcome: apply configured filesystems late ... This enables configured filesystems to cover system mount points. Closes #8. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 01:41:52 +09:00
cat	543bf69102	internal/app/spx11: check behaviour ... This outcomeOp will likely never change. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 01:00:12 +09:00
cat	4cfb1fda8f	internal/app/spwayland: check behaviour ... This op is quite clean. Might get slightly more complex at some point passing socket fd. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-19 00:30:56 +09:00
cat	c12183959a	internal/app/dispatcher: report correct field ... This was mistakenly reporting sharePath on inequivalence causing very confusing output. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 23:59:10 +09:00
cat	f5845e312e	internal/app/sptmpdir: check behaviour ... Another simple one. This will change when shared tmpdir and xdg runtime dir becomes optional. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 23:46:10 +09:00
cat	a103c4a7c7	internal/app/hsu: check behaviour ... The stub exec.ExitError is hairy as usual, but internal/app is not cross-platform, so this is okay. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 20:45:42 +09:00
cat	67ec82ae1b	ldd/exec: raise timeout ... This mostly helps with tests. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 18:03:09 +09:00
cat	f6f0cb56ae	internal/app/hsu: remove wrapper method ... This was added to reduce the size of diffs. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 17:35:20 +09:00
cat	d4284c109d	internal/app/spruntime: emulate pam_systemd type ... This sets XDG_SESSION_TYPE to the corresponding values specified in pam_systemd(8) according to enablements. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 04:33:04 +09:00
cat	030ad2a73b	internal/app/spruntime: check behaviour ... This one is quite simple and has no state. Needs to emulate pam_systemd behaviour so that will change. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 03:41:49 +09:00
cat	78d7955abd	internal/app/sppulse: check cookie discovery ... There's quite a bit of code duplication here, but since this is already quite simple it is best to leave it as is for now. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 01:30:33 +09:00
cat	b066495a7d	internal/app/sppulse: check buf error injection ... The loadFile behaviour does not guarantee the buffer to be zeroed or not clobbered if an error is returned, but for the current implementation it is good to check. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-18 01:01:52 +09:00
cat	82299d34c6	internal/app/sppulse: correctly handle small cookie ... The trailing zero bytes need to be sliced off, so send cookie size alongside buffer content. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-17 08:03:03 +09:00
cat	792013cefb	internal/app/sppulse: check behaviour ... Still needs to check the relocated functions separately. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-17 06:32:21 +09:00
cat	3f39132935	internal/app/dispatcher: reduce check code duplication ... This also improves readability of test cases. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-17 05:47:12 +09:00
cat	c922c3f80e	internal/app/sppulse: relocate hard to test code ... These are better tested separately instead of creating many op test cases. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-16 05:47:49 +09:00
cat	6cf58ca1b3	internal/app/spfinal: check behaviour ... This will be merged with spFilesystemOp eventually. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-16 02:08:31 +09:00
cat	425421d9b1	hst/container: rename constants ... The shim is an implementation detail and should not be mentioned in the API. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-16 00:27:00 +09:00
cat	5e0f15d76b	hst/container: additional shim exit codes ... These are now considered stable, defined behaviour and can be used by external programs to determine shim outcome. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-15 22:09:33 +09:00
cat	ae65491223	container/init: use one channel for wait4 ... When using two channels it is possible for the other case to be reached before all pending winfo are consumed, causing incorrect reporting. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-15 21:35:19 +09:00
cat	52e3324ef4	test/sandbox: ignore nondeterministic mount point ... No idea what systemd is doing with this to cause its options to change. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 07:08:39 +09:00
cat	f95e0a7568	hst/config: hold acl struct by value ... Doc comments are also reworded for clarity. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 07:02:14 +09:00
cat	4c647add0d	hst/container: pack boolean options ... The memory saving is relatively insignificant, however this increases serialisation efficiency. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 06:39:00 +09:00
cat	a341466942	hst: separate container config ... The booleans are getting packed into a single field. This requires non-insignificant amount of code for JSON serialisation to stay compatible. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 04:23:05 +09:00
cat	e4ee8df83c	internal/app/spdbus: check behaviour ... This is not done very cleanly, however this op is pending removal for the in-process dbus proxy so not worth spending too much effort here. As long as it checks all paths it is good enough. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 01:51:01 +09:00
cat	048c1957f1	helper/args: variadic check function ... This package turns out to be much less widely used than anticipated, and might be facing removal. This change makes test cases cleaner. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 01:48:56 +09:00
cat	790d77075e	system/dbus: remove builder state leak ... This enables external testing of system.I state. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-14 01:33:44 +09:00
cat	e5ff40e7d3	container: synchronise after notify ... This should eliminate intermittent failures in the forward test. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 19:17:19 +09:00
cat	123d7fbfd5	container/seccomp: remove export pipe ... This was only useful when wrapping bwrap. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 18:51:35 +09:00
cat	7638a44fa6	treewide: parallel tests ... Most tests already had no global state, however parallel was never enabled. This change enables it for all applicable tests. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 04:38:48 +09:00
cat	a14b6535a6	helper/stub: write ready byte late ... Hopefully eliminates spurious failures. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 01:55:44 +09:00
cat	763ab27e09	system: remove tmpfiles ... This is no longer used. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 01:12:44 +09:00
cat	bff2a1e748	container/initplace: remove indirect method ... This is no longer useful and is highly error-prone. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-13 01:06:45 +09:00
cat	8a91234cb4	hst: reword and improve doc comments ... This corrects minor mistakes in doc comments and adds them for undocumented constants. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-12 05:03:14 +09:00
cat	db7051a368	internal/app/spcontainer: check fs init behaviour ... This covers every statement. Some of them are unreachable unless the kernel returns garbage. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-12 03:58:53 +09:00
cat	36f312b3ba	internal/app/spcontainer: resolve path through dispatcher ... This prevents state from os tainting the test data. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-11 20:20:41 +09:00
cat	037144b06e	system/dbus: use well-known address in spec ... The session bus still performs non-standard formatting since it makes no sense for hakurei to start the session bus. Signed-off-by: Ophestra <cat@gensokyo.uk>	2025-10-11 18:52:06 +09:00