All checks were successful
Test / Create distribution (push) Successful in 1m17s
Test / Sandbox (push) Successful in 3m5s
Test / Hakurei (push) Successful in 4m12s
Test / ShareFS (push) Successful in 4m25s
Test / Sandbox (race detector) (push) Successful in 5m39s
Test / Hakurei (race detector) (push) Successful in 6m44s
Test / Flake checks (push) Successful in 1m24s
This makes package check portable, and removes nonportable behaviour from package pkg, pipewire, and system. All other packages remain nonportable due to their nature. No latency increase was observed due to this change on amd64 and arm64 linux. Signed-off-by: Ophestra <cat@gensokyo.uk>
259 lines
8.0 KiB
Go
259 lines
8.0 KiB
Go
package container
|
|
|
|
import (
|
|
"io"
|
|
"math"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"syscall"
|
|
"testing"
|
|
"unsafe"
|
|
|
|
"hakurei.app/check"
|
|
"hakurei.app/vfs"
|
|
)
|
|
|
|
func TestToSysroot(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
want string
|
|
}{
|
|
{"", "/sysroot"},
|
|
{"/", "/sysroot"},
|
|
{"//etc///", "/sysroot/etc"},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := toSysroot(tc.name); got != tc.want {
|
|
t.Errorf("toSysroot: %q, want %q", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestToHost(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
want string
|
|
}{
|
|
{"", "/host"},
|
|
{"/", "/host"},
|
|
{"//etc///", "/host/etc"},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := toHost(tc.name); got != tc.want {
|
|
t.Errorf("toHost: %q, want %q", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// InternalToHostOvlEscape exports toHost passed to [check.EscapeOverlayDataSegment].
|
|
func InternalToHostOvlEscape(s string) string { return check.EscapeOverlayDataSegment(toHost(s)) }
|
|
|
|
func TestCreateFile(t *testing.T) {
|
|
t.Run("nonexistent", func(t *testing.T) {
|
|
t.Run("mkdir", func(t *testing.T) {
|
|
wantErr := &os.PathError{
|
|
Op: "mkdir",
|
|
Path: "/proc/nonexistent",
|
|
Err: syscall.ENOENT,
|
|
}
|
|
if err := createFile(filepath.Join(Nonexistent, ":3"), 0644, 0755, nil); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("createFile: error = %#v, want %#v", err, wantErr)
|
|
}
|
|
})
|
|
|
|
t.Run("open", func(t *testing.T) {
|
|
wantErr := &os.PathError{
|
|
Op: "open",
|
|
Path: "/proc/nonexistent",
|
|
Err: syscall.ENOENT,
|
|
}
|
|
if err := createFile(filepath.Join(Nonexistent), 0644, 0755, nil); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("createFile: error = %#v, want %#v", err, wantErr)
|
|
}
|
|
})
|
|
})
|
|
|
|
t.Run("touch", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
pathname := filepath.Join(tempDir, "empty")
|
|
if err := createFile(pathname, 0644, 0755, nil); err != nil {
|
|
t.Fatalf("createFile: error = %v", err)
|
|
}
|
|
if d, err := os.ReadFile(pathname); err != nil {
|
|
t.Fatalf("ReadFile: error = %v", err)
|
|
} else if len(d) != 0 {
|
|
t.Fatalf("createFile: %q", string(d))
|
|
}
|
|
})
|
|
|
|
t.Run("write", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
pathname := filepath.Join(tempDir, "zero")
|
|
if err := createFile(pathname, 0644, 0755, []byte{0}); err != nil {
|
|
t.Fatalf("createFile: error = %v", err)
|
|
}
|
|
if d, err := os.ReadFile(pathname); err != nil {
|
|
t.Fatalf("ReadFile: error = %v", err)
|
|
} else if string(d) != "\x00" {
|
|
t.Fatalf("createFile: %q, want %q", string(d), "\x00")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestEnsureFile(t *testing.T) {
|
|
t.Run("create", func(t *testing.T) {
|
|
if err := ensureFile(filepath.Join(t.TempDir(), "ensure"), 0644, 0755); err != nil {
|
|
t.Errorf("ensureFile: error = %v", err)
|
|
}
|
|
})
|
|
|
|
t.Run("stat", func(t *testing.T) {
|
|
t.Run("inaccessible", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
pathname := filepath.Join(tempDir, "inaccessible")
|
|
if f, err := os.Create(pathname); err != nil {
|
|
t.Fatalf("Create: error = %v", err)
|
|
} else {
|
|
_ = f.Close()
|
|
}
|
|
|
|
if err := os.Chmod(tempDir, 0); err != nil {
|
|
t.Fatalf("Chmod: error = %v", err)
|
|
}
|
|
|
|
wantErr := &os.PathError{
|
|
Op: "stat",
|
|
Path: pathname,
|
|
Err: syscall.EACCES,
|
|
}
|
|
if err := ensureFile(pathname, 0644, 0755); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("ensureFile: error = %#v, want %#v", err, wantErr)
|
|
}
|
|
|
|
if err := os.Chmod(tempDir, 0755); err != nil {
|
|
t.Fatalf("Chmod: error = %v", err)
|
|
}
|
|
})
|
|
|
|
t.Run("directory", func(t *testing.T) {
|
|
pathname := t.TempDir()
|
|
wantErr := &os.PathError{Op: "ensure", Path: pathname, Err: syscall.EISDIR}
|
|
if err := ensureFile(pathname, 0644, 0755); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("ensureFile: error = %#v, want %#v", err, wantErr)
|
|
}
|
|
})
|
|
|
|
t.Run("ensure", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
pathname := filepath.Join(tempDir, "ensure")
|
|
if f, err := os.Create(pathname); err != nil {
|
|
t.Fatalf("Create: error = %v", err)
|
|
} else {
|
|
_ = f.Close()
|
|
}
|
|
|
|
if err := ensureFile(pathname, 0644, 0755); err != nil {
|
|
t.Errorf("ensureFile: error = %v", err)
|
|
}
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestProcPaths(t *testing.T) {
|
|
t.Run("host", func(t *testing.T) {
|
|
t.Run("stdout", func(t *testing.T) {
|
|
want := "/host/proc/self/fd/1"
|
|
if got := hostProc.stdout(); got != want {
|
|
t.Errorf("stdout: %q, want %q", got, want)
|
|
}
|
|
})
|
|
t.Run("fd", func(t *testing.T) {
|
|
want := "/host/proc/self/fd/2147483647"
|
|
if got := hostProc.fd(math.MaxInt32); got != want {
|
|
t.Errorf("stdout: %q, want %q", got, want)
|
|
}
|
|
})
|
|
})
|
|
|
|
t.Run("mountinfo", func(t *testing.T) {
|
|
t.Run("nonexistent", func(t *testing.T) {
|
|
nonexistentProc := newProcPaths(direct{}, t.TempDir())
|
|
wantErr := &os.PathError{
|
|
Op: "open",
|
|
Path: nonexistentProc.self + "/mountinfo",
|
|
Err: syscall.ENOENT,
|
|
}
|
|
if err := nonexistentProc.mountinfo(func(*vfs.MountInfoDecoder) error { return syscall.EINVAL }); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("mountinfo: error = %v, want %v", err, wantErr)
|
|
}
|
|
})
|
|
|
|
t.Run("sample", func(t *testing.T) {
|
|
tempDir := t.TempDir()
|
|
if err := os.MkdirAll(filepath.Join(tempDir, "proc/self"), 0755); err != nil {
|
|
t.Fatalf("MkdirAll: error = %v", err)
|
|
}
|
|
|
|
t.Run("clean", func(t *testing.T) {
|
|
if err := os.WriteFile(filepath.Join(tempDir, "proc/self/mountinfo"), []byte(`15 20 0:3 / /proc rw,relatime - proc /proc rw
|
|
16 20 0:15 / /sys rw,relatime - sysfs /sys rw
|
|
17 20 0:5 / /dev rw,relatime - devtmpfs udev rw,size=1983516k,nr_inodes=495879,mode=755`), 0644); err != nil {
|
|
t.Fatalf("WriteFile: error = %v", err)
|
|
}
|
|
|
|
var mountInfo *vfs.MountInfo
|
|
if err := newProcPaths(direct{}, tempDir).mountinfo(func(d *vfs.MountInfoDecoder) error { return d.Decode(&mountInfo) }); err != nil {
|
|
t.Fatalf("mountinfo: error = %v", err)
|
|
}
|
|
|
|
wantMountInfo := &vfs.MountInfo{Next: &vfs.MountInfo{Next: &vfs.MountInfo{
|
|
MountInfoEntry: vfs.MountInfoEntry{ID: 17, Parent: 20, Devno: vfs.DevT{0, 5}, Root: "/", Target: "/dev", VfsOptstr: "rw,relatime", OptFields: []string{}, FsType: "devtmpfs", Source: "udev", FsOptstr: "rw,size=1983516k,nr_inodes=495879,mode=755"}},
|
|
MountInfoEntry: vfs.MountInfoEntry{ID: 16, Parent: 20, Devno: vfs.DevT{0, 15}, Root: "/", Target: "/sys", VfsOptstr: "rw,relatime", OptFields: []string{}, FsType: "sysfs", Source: "/sys", FsOptstr: "rw"}},
|
|
MountInfoEntry: vfs.MountInfoEntry{ID: 15, Parent: 20, Devno: vfs.DevT{0, 3}, Root: "/", Target: "/proc", VfsOptstr: "rw,relatime", OptFields: []string{}, FsType: "proc", Source: "/proc", FsOptstr: "rw"},
|
|
}
|
|
if !reflect.DeepEqual(mountInfo, wantMountInfo) {
|
|
t.Errorf("Decode: %#v, want %#v", mountInfo, wantMountInfo)
|
|
}
|
|
})
|
|
|
|
t.Run("closed", func(t *testing.T) {
|
|
p := newProcPaths(direct{}, tempDir)
|
|
wantErr := &os.PathError{
|
|
Op: "close",
|
|
Path: p.self + "/mountinfo",
|
|
Err: os.ErrClosed,
|
|
}
|
|
if err := p.mountinfo(func(d *vfs.MountInfoDecoder) error {
|
|
v := reflect.ValueOf(d).Elem().FieldByName("s").Elem().FieldByName("r")
|
|
v = reflect.NewAt(v.Type(), unsafe.Pointer(v.UnsafeAddr()))
|
|
if f, ok := v.Elem().Interface().(io.ReadCloser); !ok {
|
|
t.Fatal("implementation of bufio.Scanner no longer compatible with this fault injection")
|
|
return syscall.ENOTRECOVERABLE
|
|
} else {
|
|
return f.Close()
|
|
}
|
|
}); !reflect.DeepEqual(err, wantErr) {
|
|
t.Errorf("mountinfo: error = %#v, want %#v", err, wantErr)
|
|
}
|
|
})
|
|
|
|
t.Run("malformed", func(t *testing.T) {
|
|
filepath.Join(tempDir, "proc/self/mountinfo")
|
|
if err := os.WriteFile(filepath.Join(tempDir, "proc/self/mountinfo"), []byte{0}, 0644); err != nil {
|
|
t.Fatalf("WriteFile: error = %v", err)
|
|
}
|
|
|
|
wantErr := &vfs.DecoderError{Op: "parse", Line: 0, Err: vfs.ErrMountInfoFields}
|
|
if err := newProcPaths(direct{}, tempDir).mountinfo(func(d *vfs.MountInfoDecoder) error { return d.Decode(new(*vfs.MountInfo)) }); !reflect.DeepEqual(err, wantErr) {
|
|
t.Fatalf("mountinfo: error = %v, want %v", err, wantErr)
|
|
}
|
|
})
|
|
})
|
|
})
|
|
}
|